NetBSD Problem Report #56595
From triaxx@netbsd.org Sat Jan 1 05:44:14 2022
Return-Path: <triaxx@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id AE0341A9239
for <gnats-bugs@gnats.NetBSD.org>; Sat, 1 Jan 2022 05:44:14 +0000 (UTC)
Message-Id: <20220101054413.729151A923C@mollari.NetBSD.org>
Date: Sat, 1 Jan 2022 05:44:13 +0000 (UTC)
From: triaxx@netbsd.org
Reply-To: triaxx@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: pkglint: warning with invalid character "!" in go-modules.mk
X-Send-Pr-Version: 3.95
>Number: 56595
>Category: pkg
>Synopsis: pkglint: warning with invalid character "!" in go-modules.mk
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: rillig@NetBSD.org
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat Jan 01 05:45:00 +0000 2022
>Closed-Date: Sat Jan 01 12:46:40 +0000 2022
>Last-Modified: Sat Jan 01 12:46:40 +0000 2022
>Originator: Frédéric Fauberteau
>Release: NetBSD 9.2
>Organization:
>Environment:
System: NetBSD ultralisk.triaxx.org 9.2 NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
Pkgsrc: HEAD
>Description:
$ pkglint --version
21.4.0
$ pwd
/usr/pkgsrc/www/grafana
$ pkglint
WARN: go-modules.mk:83: The pathname pattern "github.com/!andreas!briese/bbloom/@v/v0.0.0-20190306092124-e2d15f34fcf9.mod" contains the invalid characters "!!".
WARN: go-modules.mk:84: The pathname pattern "github.com/!andreas!briese/bbloom/@v/v0.0.0-20190306092124-e2d15f34fcf9.zip" contains the invalid characters "!!".
WARN: go-modules.mk:85: The pathname pattern "github.com/!azure/azure-amqp-common-go/v3/@v/v3.0.0.mod" contains the invalid character "!".
WARN: go-modules.mk:86: The pathname pattern "github.com/!azure/azure-amqp-common-go/v3/@v/v3.0.0.zip" contains the invalid character "!".
WARN: go-modules.mk:87: The pathname pattern "github.com/!azure/azure-event-hubs-go/v3/@v/v3.2.0.mod" contains the invalid character "!".
[...]
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->rillig@NetBSD.org
Responsible-Changed-By: triaxx@NetBSD.org
Responsible-Changed-When: Sat, 01 Jan 2022 06:11:59 +0000
Responsible-Changed-Why:
Over to maintainer.
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56595: pkglint: warning with invalid character "!" in
go-modules.mk
Date: Sat, 1 Jan 2022 12:34:18 +0000 (UTC)
On Sat, 1 Jan 2022, triaxx@netbsd.org wrote:
> WARN: go-modules.mk:83: The pathname pattern "github.com/!andreas!briese/bbloom/@v/v0.0.0-20190306092124-e2d15f34fcf9.mod" contains the invalid characters "!!".
> WARN: go-modules.mk:84: The pathname pattern "github.com/!andreas!briese/bbloom/@v/v0.0.0-20190306092124-e2d15f34fcf9.zip" contains the invalid characters "!!".
> WARN: go-modules.mk:85: The pathname pattern "github.com/!azure/azure-amqp-common-go/v3/@v/v3.0.0.mod" contains the invalid character "!".
> WARN: go-modules.mk:86: The pathname pattern "github.com/!azure/azure-amqp-common-go/v3/@v/v3.0.0.zip" contains the invalid character "!".
> WARN: go-modules.mk:87: The pathname pattern "github.com/!azure/azure-event-hubs-go/v3/@v/v3.2.0.mod" contains the invalid character "!".
Note that these ! characters are legitimate. The Go module system replaces
uppercase letters with a ! and a lowercase one, to avoid issues on
case-insensitive file systems.
--
Benny
From: "Roland Illig" <rillig@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/56595 CVS commit: pkgsrc/pkgtools/pkglint
Date: Sat, 1 Jan 2022 12:44:25 +0000
Module Name: pkgsrc
Committed By: rillig
Date: Sat Jan 1 12:44:25 UTC 2022
Modified Files:
pkgsrc/pkgtools/pkglint: Makefile
pkgsrc/pkgtools/pkglint/files: autofix_test.go check_test.go
files_test.go lineslexer_test.go mkassignchecker.go mkline_test.go
mklinechecker_test.go mklineparser_test.go mklines_test.go
mkparser_test.go mkshparser_test.go mkshwalker_test.go
mktokenslexer_test.go package_test.go pkglint.go pkglint_test.go
pkgsrc.go pkgsrc_test.go plist_test.go scope_test.go shell_test.go
shtokenizer_test.go tools_test.go util_test.go var_test.go
varalignblock_test.go vardefs.go vartype.go vartype_test.go
vartypecheck.go vartypecheck_test.go
Log Message:
pkgtools/pkglint: update to 21.4.1
Changes since 21.4.0:
Running 'pkglint doc/CHANGES-2021' now warns about issues for this
single file. Previously, it was necessary to specify '-Cglobal' as
well, but then pkglint also warned about issues in all other CHANGES
files.
Pkglint no longer warns about the characters '!' and '@' in
GO_MODULES_FILES, since these are legitimate. Fixes PR pkg/56595.
Small cleanups in the pkglint testing infrastructure.
To generate a diff of this commit:
cvs rdiff -u -r1.706 -r1.707 pkgsrc/pkgtools/pkglint/Makefile
cvs rdiff -u -r1.42 -r1.43 pkgsrc/pkgtools/pkglint/files/autofix_test.go
cvs rdiff -u -r1.77 -r1.78 pkgsrc/pkgtools/pkglint/files/check_test.go
cvs rdiff -u -r1.33 -r1.34 pkgsrc/pkgtools/pkglint/files/files_test.go
cvs rdiff -u -r1.3 -r1.4 pkgsrc/pkgtools/pkglint/files/lineslexer_test.go
cvs rdiff -u -r1.11 -r1.12 pkgsrc/pkgtools/pkglint/files/mkassignchecker.go
cvs rdiff -u -r1.83 -r1.84 pkgsrc/pkgtools/pkglint/files/mkline_test.go \
pkgsrc/pkgtools/pkglint/files/pkglint.go
cvs rdiff -u -r1.65 -r1.66 \
pkgsrc/pkgtools/pkglint/files/mklinechecker_test.go \
pkgsrc/pkgtools/pkglint/files/pkgsrc.go
cvs rdiff -u -r1.13 -r1.14 pkgsrc/pkgtools/pkglint/files/mklineparser_test.go
cvs rdiff -u -r1.66 -r1.67 pkgsrc/pkgtools/pkglint/files/mklines_test.go
cvs rdiff -u -r1.41 -r1.42 pkgsrc/pkgtools/pkglint/files/mkparser_test.go
cvs rdiff -u -r1.24 -r1.25 pkgsrc/pkgtools/pkglint/files/mkshparser_test.go
cvs rdiff -u -r1.12 -r1.13 pkgsrc/pkgtools/pkglint/files/mkshwalker_test.go
cvs rdiff -u -r1.6 -r1.7 pkgsrc/pkgtools/pkglint/files/mktokenslexer_test.go
cvs rdiff -u -r1.88 -r1.89 pkgsrc/pkgtools/pkglint/files/package_test.go
cvs rdiff -u -r1.71 -r1.72 pkgsrc/pkgtools/pkglint/files/pkglint_test.go
cvs rdiff -u -r1.54 -r1.55 pkgsrc/pkgtools/pkglint/files/pkgsrc_test.go
cvs rdiff -u -r1.53 -r1.54 pkgsrc/pkgtools/pkglint/files/plist_test.go \
pkgsrc/pkgtools/pkglint/files/vartype.go
cvs rdiff -u -r1.2 -r1.3 pkgsrc/pkgtools/pkglint/files/scope_test.go
cvs rdiff -u -r1.72 -r1.73 pkgsrc/pkgtools/pkglint/files/shell_test.go
cvs rdiff -u -r1.26 -r1.27 pkgsrc/pkgtools/pkglint/files/shtokenizer_test.go \
pkgsrc/pkgtools/pkglint/files/tools_test.go
cvs rdiff -u -r1.56 -r1.57 pkgsrc/pkgtools/pkglint/files/util_test.go
cvs rdiff -u -r1.8 -r1.9 pkgsrc/pkgtools/pkglint/files/var_test.go
cvs rdiff -u -r1.17 -r1.18 \
pkgsrc/pkgtools/pkglint/files/varalignblock_test.go
cvs rdiff -u -r1.103 -r1.104 pkgsrc/pkgtools/pkglint/files/vardefs.go
cvs rdiff -u -r1.27 -r1.28 pkgsrc/pkgtools/pkglint/files/vartype_test.go
cvs rdiff -u -r1.99 -r1.100 pkgsrc/pkgtools/pkglint/files/vartypecheck.go
cvs rdiff -u -r1.90 -r1.91 pkgsrc/pkgtools/pkglint/files/vartypecheck_test.go
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Sat, 01 Jan 2022 12:46:40 +0000
State-Changed-Why:
Fixed in pkglint 21.4.1, released a minute ago.
Thank you for the PR.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.