NetBSD Problem Report #56873

From gson@gson.org  Thu Jun  9 15:16:09 2022
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D579C1A921F
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  9 Jun 2022 15:16:09 +0000 (UTC)
Message-Id: <20220609151600.687832547A7@guava.gson.org>
Date: Thu,  9 Jun 2022 18:16:00 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: xentools packages do not build on NetBSD-current
X-Send-Pr-Version: 3.95

>Number:         56873
>Category:       pkg
>Synopsis:       xentools packages do not build on NetBSD-current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 09 15:20:00 +0000 2022
>Last-Modified:  Fri Jun 10 10:50:01 +0000 2022
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date 2022.06.08.13.08.44
>Organization:

>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

The xentools411, xentools413, and xentools415 packages all fail to
build on -current.  For example, the xentools413 build fails with
these error messages:

    xentoollog_stubs.c:57: error: "Some_val" redefined [-Werror]
       57 | #define Some_val(v) Field(v,0)
          | 
    In file included from /usr/pkg/lib/ocaml/caml/alloc.h:24,
                     from xentoollog_stubs.c:23:
    /usr/pkg/lib/ocaml/caml/mlvalues.h:404: note: this is the location of the previous definition
      404 | #define Some_val(v) Field(v, 0)
          | 
    cc1: all warnings being treated as errors

A tabular report showing all three failures is at

  https://www.gson.org/netbsd/bugs/xen/results/2022-06-09/index.html

>How-To-Repeat:

>Fix:

>Audit-Trail:
From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56873 CVS commit: pkgsrc/sysutils/xentools415
Date: Thu, 9 Jun 2022 17:11:27 +0000

 Module Name:	pkgsrc
 Committed By:	bouyer
 Date:		Thu Jun  9 17:11:27 UTC 2022

 Modified Files:
 	pkgsrc/sysutils/xentools415: distinfo
 Added Files:
 	pkgsrc/sysutils/xentools415/patches:
 	    patch-tools_ocaml_libs_xc_xenctrl_stubs.c
 	    patch-tools_ocaml_libs_xentoollog_xentoollog_stubs.c
 	    patch-tools_ocaml_libs_xl_xenlight_stubs.c

 Log Message:
 Avoid redefinition of Val_none and Some_val; fixes PR pkg/56873


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/sysutils/xentools415/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xc_xenctrl_stubs.c \
     pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xentoollog_xentoollog_stubs.c \
     pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xl_xenlight_stubs.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Manuel Bouyer <bouyer@antioche.eu.org>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56873: xentools packages do not build on NetBSD-current
Date: Thu, 9 Jun 2022 19:11:15 +0200

 On Thu, Jun 09, 2022 at 03:20:00PM +0000, Andreas Gustafsson wrote:
 > >Number:         56873
 > >Category:       pkg
 > >Synopsis:       xentools packages do not build on NetBSD-current
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Thu Jun 09 15:20:00 +0000 2022
 > >Originator:     Andreas Gustafsson
 > >Release:        NetBSD-current, source date 2022.06.08.13.08.44
 > >Organization:
 >   
 > >Environment:
 > System: NetBSD
 > Architecture: x86_64
 > Machine: amd64
 > >Description:
 > 
 > The xentools411, xentools413, and xentools415 packages all fail to
 > build on -current.  For example, the xentools413 build fails with
 > these error messages:
 > 
 >     xentoollog_stubs.c:57: error: "Some_val" redefined [-Werror]
 >        57 | #define Some_val(v) Field(v,0)
 >           | 
 >     In file included from /usr/pkg/lib/ocaml/caml/alloc.h:24,
 >                      from xentoollog_stubs.c:23:
 >     /usr/pkg/lib/ocaml/caml/mlvalues.h:404: note: this is the location of the previous definition
 >       404 | #define Some_val(v) Field(v, 0)
 >           | 
 >     cc1: all warnings being treated as errors
 > 
 > A tabular report showing all three failures is at
 > 
 >   https://www.gson.org/netbsd/bugs/xen/results/2022-06-09/index.html

 should be fixed with
 /cvsroot/pkgsrc/sysutils/xentools415/distinfo,v  <--  distinfo
 new revision: 1.10; previous revision: 1.9
 /cvsroot/pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xc_xenctrl_stubs.c,v  <--  patches/patch-tools_ocaml_libs_xc_xenctrl_stubs.c
 initial revision: 1.1
 /cvsroot/pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xentoollog_xentoollog_stubs.c,v  <--  patches/patch-tools_ocaml_libs_xentoollog_xentoollog_stubs.c
 initial revision: 1.1
 /cvsroot/pkgsrc/sysutils/xentools415/patches/patch-tools_ocaml_libs_xl_xenlight_stubs.c,v  <--  patches/patch-tools_ocaml_libs_xl_xenlight_stubs.c
 initial revision: 1.1

 will fix xentools413 later, there are security patches pending too.

 -- 
 Manuel Bouyer <bouyer@antioche.eu.org>
      NetBSD: 26 ans d'experience feront toujours la difference
 --

From: Andreas Gustafsson <gson@gson.org>
To: gnats-bugs@netbsd.org
Cc: bouyer@antioche.eu.org
Subject: Re: pkg/56873: xentools packages do not build on NetBSD-current
Date: Fri, 10 Jun 2022 13:49:21 +0300

 Manuel Bouyer wrote:
 >  should be fixed with
 [...]
 >  will fix xentools413 later, there are security patches pending too.

 Thanks, I can confirm that the xentools415 build is now fixed on
 -current.  I will leave the PR open pending the xentools413 fix.
 -- 
 Andreas Gustafsson, gson@gson.org

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.