NetBSD Problem Report #57012

From hf@nt.tu-darmstadt.de  Thu Sep 15 10:43:16 2022
Return-Path: <hf@nt.tu-darmstadt.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 27D831A923A
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 15 Sep 2022 10:43:16 +0000 (UTC)
Message-Id: <202209151043.28FAh7aK008724@Hochobir.nt.e-technik.tu-darmstadt.de>
Date: Thu, 15 Sep 2022 12:43:07 +0200 (CEST)
From: Hauke Fath <hf@spg.tu-darmstadt.de>
Reply-To: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: squirrelmail compatibility problem with php 8
X-Send-Pr-Version: 3.95

>Number:         57012
>Category:       pkg
>Synopsis:       squirrelmail compatibility problem with php 8
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    taca
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 15 10:45:00 +0000 2022
>Closed-Date:    Fri Sep 16 10:15:14 +0000 2022
>Last-Modified:  Fri Sep 16 10:15:14 +0000 2022
>Originator:     Hauke Fath
>Release:        NetBSD 9.3_STABLE
>Organization:
Technische Universitaet Darmstadt
>Environment:


System: NetBSD Hochobir 9.3_STABLE NetBSD 9.3_STABLE (DMZ_DOMU) #0: Thu Aug 18 16:51:33 CEST 2022 hf@Hochstuhl:/var/obj/netbsd-builds/9/amd64/sys/arch/amd64/compile/DMZ_DOMU amd64
Architecture: x86_64
Machine: amd64
>Description:

	When built with PHP 8.1, ending mail in squirrelmail will not
	file a copy in the Sent folder, even if configured to do so.

	Instead, the web server logs several warnings, and then an
	error:

[Wed Sep 14 18:35:39.016448 2022] [php:error] [pid 5847] [client x.x.x.x:52912] PHP Fatal error:  Declaration of Deliver_IMAP::send_mail($message, $header, $boundary, $stream, &$raw_length, $folder = null) must be compatible with Deliver::send_mail($message, $header, $boundary, $stream = false, &$raw_length = 0, $extra = null) in /usr/pkg/share/squirrelmail/class/deliver/Deliver_IMAP.class.php on line 54, referer: https://www2.nt.tu-darmstadt.de/squirrelmail/src/compose.php?mailbox=INBOX&startMessage=1



>How-To-Repeat:

	Install mail/squirrelmail with PHP 8.1, send a mail. Find
	there is no copy in Sent folder.


>Fix:


	I understand that the package distfile is a svn snapshot
	stored on netbsd.org:

1.141 (taca 21-Mar-21): DISTNAME=squirrelmail-webmail-1.4.23pre14904
1.122 (taca 28-Dec-12): MASTER_SITES=${MASTER_SITE_LOCAL}

	Upstream makes it sound like php 8 compatibility issues were
	fixed, so the snapshot should probably be updated.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->taca
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Thu, 15 Sep 2022 11:28:02 +0000
Responsible-Changed-Why:
Over to maintainer


From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@netbsd.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: Re: pkg/57012: squirrelmail compatibility problem with php 8
Date: Thu, 15 Sep 2022 20:12:13 +0200

 [re-sent to gnats]

 The diff <https://sourceforge.net/p/squirrelmail/code/14908/> fixes the=20
 problem, but it is probably still advisable to update to a current=20
 snapshot.

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

From: "Takahiro Kambe" <taca@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57012 CVS commit: pkgsrc/mail/squirrelmail
Date: Fri, 16 Sep 2022 05:49:08 +0000

 Module Name:	pkgsrc
 Committed By:	taca
 Date:		Fri Sep 16 05:49:08 UTC 2022

 Modified Files:
 	pkgsrc/mail/squirrelmail: Makefile distinfo

 Log Message:
 mail/squirrelmail: update to 1.4.23pre14977

 Update to latest svn snapshot.  It includes various improvements for PHP 8
 compatibility.  Address to PR pkg/57012.

 Here are quote from commit log:

 1.4.23pre14977 (2022-06-21)

 * Add cookie SameSite attribute; uses default if "Strict" but can be
   overridden by $same_site_cookies in config_local.php
 * Browser seems to respond better when deleting the cookie if you void its
   value also; helps actually get the cookie to be removed even though this
   feels more like a browser problem... maybe it does not like a date in
   1970?
 * Make sure drafts are sent with the current date and not that of its
   previous 'Save Draft' action
 * Add option to prefix new mail number to the front of the org title
   (browser title bar)
 * Fix certain messages with headers in unknown charsets encoded as quoted
   printable showing up as blank sender/subject in message list
 * Add ability for plugins to request additional header fields in the message
   list lookup
 * Separate DNT and DSN
 * Add proper RFC 3461 DSN functionality (previously we relied only on the
   Return-Receipt-To header)
 * Cause message subject to show in page title when message view is loaded in
   its own window/tab
 * Implement SQL identifier quoting in all cases
 * Add option to folder prefs for marking deleted messages as read
 * Fix: Login mechanisms other than "login" were broken if server returned
   untagged data before login response
 * Greatly fix the plaintext display of messages that do not have a text
   part.
 * Add ability to explicitly set prefs DB connection charset
 * Add ability to explicitly set address book DB connection charset


 To generate a diff of this commit:
 cvs rdiff -u -r1.143 -r1.144 pkgsrc/mail/squirrelmail/Makefile
 cvs rdiff -u -r1.74 -r1.75 pkgsrc/mail/squirrelmail/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: hauke@NetBSD.org
State-Changed-When: Fri, 16 Sep 2022 10:15:14 +0000
State-Changed-Why:
Problem is fixed. Thanks for the quick update!


>Unformatted:

Home	PR Database Search