NetBSD Problem Report #57132

From tsutsui@ceres.dti.ne.jp  Fri Dec 23 12:41:47 2022
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D0CEC1A921F
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 23 Dec 2022 12:41:47 +0000 (UTC)
Message-Id: <202212231241.2BNCfbo6002608@ceres.dti.ne.jp>
Date: Fri, 23 Dec 2022 21:41:37 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Subject: sysinst doesn't handle pm->pstart properly
X-Send-Pr-Version: 3.95

>Number:         57132
>Category:       install
>Synopsis:       sysinst doesn't handle pm->pstart properly
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          needs-pullups
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 23 12:45:00 +0000 2022
>Closed-Date:    
>Last-Modified:  Sat Dec 31 10:05:01 +0000 2022
>Originator:     Izumi Tsutsui
>Release:        NetBSD 10.0_BETA 202212180050Z
>Organization:
>Environment:
System: NetBSD 9.3 (INSTALL) x68k
Architecture: m68k
Machine: x68k
>Description:
sysinst on NetBSD/x68k 10.0_BETA still has the following problems:
 https://gist.github.com/tsutsui/d6c6ab07d5fc62d8381fbdad8b6a8633
 - swap partition (shoud be at b: ?) is not shown on disklabel editor (0:53)
 - if swap partition is added manually partition c: seems corrupted (1:15)
 - so I delete the c: then a: seems corrupted (1:40)
on ports that have pm->pstart>0 (to have reserved sectors before NetBSD partition)

>How-To-Repeat:
(build and install pkgsrc/emulators/nono)
echo 'vmtype = x68030' > nono.cfg
echo 'ram-size = 12' >> nono.cfg
echo 'sram-sync-ramsize = 1' >> nono.cfg
ftp http://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-10/latest/x68k/installation/floppy/sysinst1.fs
ftp http://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-10/latest/x68k/installation/floppy/sysinst2.fs
dd if=/dev/zero of=hdd.img bs=1m count=1024
nono
(^C or quit by [File]->[Exit] menu once after SRAM.DAT is created)
nono -f -c nono.cfg -V spc0-id0-image=hd,hdd.img -V fd0-image=sysinst1.fs -V fd1-image=sysinst2.fs

(sysinst will start on nono)

"a: Install NetBSD to hard disk"
"b: Yes"
"a: sd0 (1.0G, NONO SCSIHD)"
"a: Set sizes of NetBSD partitions"
"x: Go on.  Free space 1437632 sec."

Then you can see
- no swap partition on the disklabel editor.
- adding or deleting partitions makes partition table mangled.
- selecting "x: Partition sizes ok" then sysinst complains:
 "The order of partition 1 () is wrong.  Edit again?"

>Fix:
It would be great to have design descriptoin of data structure
in edit_and_check_label() etc. to investigate it.

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57132 CVS commit: src/usr.sbin/sysinst
Date: Tue, 27 Dec 2022 13:12:10 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Dec 27 13:12:10 UTC 2022

 Modified Files:
 	src/usr.sbin/sysinst: bsddisklabel.c

 Log Message:
 PR 57132: when calculation additional space available for the "expanded"
 partition (typically /) do not forget the reserved space (that might
 be required for the system/bootloader/other MD stuff).


 To generate a diff of this commit:
 cvs rdiff -u -r1.70 -r1.71 src/usr.sbin/sysinst/bsddisklabel.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->needs-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Thu, 29 Dec 2022 20:37:58 +0000
State-Changed-Why:
Confirmed installation of NetBSD-daily/HEAD/202212271910Z working.


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Fri, 30 Dec 2022 14:53:08 +0000
State-Changed-Why:
pullup-10 #30


From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57132 CVS commit: [netbsd-10] src/usr.sbin/sysinst
Date: Sat, 31 Dec 2022 04:55:13 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Sat Dec 31 04:55:13 UTC 2022

 Modified Files:
 	src/usr.sbin/sysinst [netbsd-10]: bsddisklabel.c

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #30):
 	usr.sbin/sysinst/bsddisklabel.c: revision 1.71
 PR 57132: when calculation additional space available for the "expanded"
 partition (typically /) do not forget the reserved space (that might
 be required for the system/bootloader/other MD stuff).


 To generate a diff of this commit:
 cvs rdiff -u -r1.69 -r1.69.2.1 src/usr.sbin/sysinst/bsddisklabel.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 31 Dec 2022 05:29:59 +0000
State-Changed-Why:
pulled up, thanks!


State-Changed-From-To: closed->needs-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 31 Dec 2022 06:34:08 +0000
State-Changed-Why:
netbsd-9 still affected, but there seems conflicts to not-pulled-up fixes:
 https://mail-index.netbsd.org/source-changes/2020/10/09/msg122765.html
  https://github.com/NetBSD/src/commit/dc7680dea5db08f5a1f37cde25528d2cfc02f98f
 https://mail-index.netbsd.org/source-changes/2021/02/13/msg126857.html
  https://github.com/NetBSD/src/commit/9c5821563f44802c0be1734cb2a945680d4bb374


From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/57132 (sysinst doesn't handle pm->pstart properly)
Date: Sat, 31 Dec 2022 11:04:07 +0100

 On Sat, Dec 31, 2022 at 06:34:09AM +0000, tsutsui@NetBSD.org wrote:
 > Synopsis: sysinst doesn't handle pm->pstart properly
 > 
 > State-Changed-From-To: closed->needs-pullups
 > State-Changed-By: tsutsui@NetBSD.org
 > State-Changed-When: Sat, 31 Dec 2022 06:34:08 +0000
 > State-Changed-Why:
 > netbsd-9 still affected, but there seems conflicts to not-pulled-up fixes:

 The code in -9 looked slightly different but ok-ish, but I haven't verified
 it works in nono - let's get back to this after other pullups have happened.

 Martin

>Unformatted:

Home	PR Database Search