NetBSD Problem Report #57164

From root@starwolf.com  Thu Jan  5 22:55:45 2023
Return-Path: <root@starwolf.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E0AED1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  5 Jan 2023 22:55:44 +0000 (UTC)
Message-Id: <20230105213648.B69C115683@valentina.serenity.starwolf.com>
Date: Thu,  5 Jan 2023 13:36:48 -0800 (PST)
From: greywolf@starwolf.com
Reply-To: greywolf@starwolf.com
To: gnats-bugs@NetBSD.org
Subject: Patch: Option for Cribbage to assume new game rather than exit
X-Send-Pr-Version: 3.95

>Number:         57164
>Category:       bin
>Synopsis:       Adding -y flag to cribbage to assume 'Y' at "Another game?"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 05 23:00:00 +0000 2023
>Closed-Date:    Fri Jan 06 17:14:14 +0000 2023
>Last-Modified:  Fri Jan 06 19:05:01 +0000 2023
>Originator:     greywolf@starwolf.com
>Release:        NetBSD 10.0_BETA
>Organization:
Star Wolf Innovations
>Environment:


System: NetBSD valentina.serenity.starwolf.com 10.0_BETA NetBSD 10.0_BETA (VALENTINA) #0: Tue Dec 27 14:17:36 PST 2022 greywolf@valentina.serenity.starwolf.com:/usr/src/sys/arch/amd64/compile/VALENTINA amd64
Architecture: x86_64
Machine: amd64
>Description:
	I have been frustrated by hitting a keystroke other than 'Y' --
	usually the space bar -- at the end of a game of cribbage, more
	often than not, and I have thought that it would be nice to have
	a flag by which to assume a positive response than a negative one.
>How-To-Repeat:
	cribbage
	[play a game]
	hit any other key besides 'y'.
>Fix:
### patches included below ###

--- crib.c.orig	2023-01-05 13:14:37.123861323 -0800
+++ crib.c	2023-01-05 13:21:55.528365976 -0800
@@ -97,7 +97,7 @@
 			err(1, "fcntl F_SETFD");
 	}

-	while ((ch = getopt(argc, argv, "eqr")) != -1)
+	while ((ch = getopt(argc, argv, "eqry")) != -1)
 		switch (ch) {
 		case 'e':
 			explain = TRUE;
@@ -108,9 +108,12 @@
 		case 'r':
 			rflag = TRUE;
 			break;
+		case 'y':
+			yes = TRUE;
+			break;
 		case '?':
 		default:
-			(void) fprintf(stderr, "usage: cribbage [-eqr]\n");
+			(void) fprintf(stderr, "usage: cribbage [-eqry]\n");
 			exit(1);
 		}

@@ -154,7 +157,10 @@
 			glimit = (getuchar() == 'S' ? SGAME : LGAME);
 		game();
 		msg("Another game? ");
-		playing = (getuchar() == 'Y');
+		if (!yes)
+		    playing = (getuchar() == 'Y');
+		else
+		    playing = (getuchar() != 'N');
 	} while (playing);

 	if (f != NULL) {

--- cribbage.6.orig	2023-01-05 13:20:53.629462956 -0800
+++ cribbage.6	2023-01-05 13:20:16.027514907 -0800
@@ -61,6 +61,9 @@
 .It Fl r
 Instead of asking the player to cut the deck, the program will randomly
 cut the deck.
+.It Fl y
+Assume 'Y' to the query for another game if 'Y' is not explicitly typed
+(default is to exit unless 'Y' is typed).
 .El
 .Pp
 .Nm

--- extern.c.orig	2023-01-05 13:18:27.221983865 -0800
+++ extern.c	2023-01-05 13:16:48.957338493 -0800
@@ -47,6 +47,7 @@
 BOOLEAN	iwon		= FALSE;	/* if comp won last game */
 BOOLEAN	quiet		= FALSE;	/* if suppress random mess */
 BOOLEAN	rflag		= FALSE;	/* if all cuts random */
+BOOLEAN yes		= FALSE;	/* default 'y' to "Another game?" */

 char	explan[128];			/* explanation */


>Release-Note:

>Audit-Trail:
From: Greywolf <greywolf@starwolf.com>
To: gnats-bugs@netbsd.org, gnats-admin@netbsd.org
Cc: 
Subject: Re: bin/57164: Patch: Option for Cribbage to assume new game rather
 than exit
Date: Thu, 5 Jan 2023 19:06:57 -0800

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --------------zA6asS5IbxrQbVmdS3FAN86X
 Content-Type: multipart/mixed; boundary="------------9YPLUlb1wOm6PpEOSaAjUvtg";
  protected-headers="v1"
 From: Greywolf <greywolf@starwolf.com>
 To: gnats-bugs@netbsd.org, gnats-admin@netbsd.org
 Message-ID: <f6644120-c5c8-7fc2-33e3-9b0e2ead2c83@starwolf.com>
 Subject: Re: bin/57164: Patch: Option for Cribbage to assume new game rather
  than exit

 --------------9YPLUlb1wOm6PpEOSaAjUvtg
 Content-Type: multipart/mixed; boundary="------------0R92ei28OhfjfKXXNPB509tk"

 --------------0R92ei28OhfjfKXXNPB509tk
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: base64

 QWRkaXRpb25hbCBwYXRjaDoNCg0KLS0tIGNyaWJiYWdlLmgub3JpZyAgICAgMjAyMy0wMS0w
 NSAxOTowNjoxOS4wODQ1ODY2NjkgLTA4MDANCisrKyBjcmliYmFnZS5oICAyMDIzLTAxLTA1
 IDE5OjAwOjEyLjY4NDk2NjQ2OCAtMDgwMA0KQEAgLTUzLDYgKzUzLDcgQEANCiAgZXh0ZXJu
 ICBCT09MRUFOICAgICAgICAgICAgICAgIGV4cGxhaW47ICAgICAgICAgICAgICAgIC8qIHBs
 YXllciBtaXN0YWtlcyBleHBsYWluZWQgKi8NCiAgZXh0ZXJuICBCT09MRUFOICAgICAgICAg
 ICAgICAgIHJmbGFnOyAgICAgICAgICAgICAgICAgIC8qIGlmIGFsbCBjdXRzIHJhbmRvbSAq
 Lw0KICBleHRlcm4gIEJPT0xFQU4gICAgICAgICAgICAgICAgcXVpZXQ7ICAgICAgICAgICAg
 ICAgICAgLyogaWYgc3VwcHJlc3MgcmFuZG9tIG1lc3MgKi8NCitleHRlcm4gQk9PTEVBTiAg
 ICAgICAgIHllczsgICAgICAgICAgICAgICAgICAgIC8qICJBbm90aGVyIGdhbWU/IiBkZWZh
 dWx0ICovDQogIA0KICBleHRlcm4gIGNoYXIgICAgICAgICAgIGV4cGxhbltdOyAgICAgICAg
 ICAgICAgIC8qIHN0cmluZyBmb3IgZXhwbGFuYXRpb24gKi8NCg0KLS0tLQ0KLS0qZ3JleXdv
 bGY7DQoNCg==
 --------------0R92ei28OhfjfKXXNPB509tk
 Content-Type: application/pgp-keys; name="OpenPGP_0x2C80F168914E2DF6.asc"
 Content-Disposition: attachment; filename="OpenPGP_0x2C80F168914E2DF6.asc"
 Content-Description: OpenPGP public key
 Content-Transfer-Encoding: quoted-printable

 -----BEGIN PGP PUBLIC KEY BLOCK-----

 xsFNBE98lBoBEACt14uBorQeAayNu4SKlsKiTYHub4ec4Qb9fCUm9vE+qGfjdJv3
 Lk7f69hJmtbtzF9VxsKfVfyirPYNdZzpzChThfl7rdUu5w1pmk9DKHczn0FylAJy
 y8ilgatdjntEA7Y83OokmL5pCAWhmVyIDTMzMlT85QHKUxQQQvtSm04azTwaWywB
 PlVQ9E0JkOIscjqyLX6tMnMByiN426HqnDfnDUfAuOUt/36x+S/4DAUZ6nCP7wpq
 wjbY5GL8m2MTULYl3/irAA4jBNOoBeddYGb3QlS9QjrXbShVEkkr45UWJTKnJKUX
 0ZSn+cY+1DPAkOB8Yr5kpb3+4Y1b4ZbXhcnVJRBrx4JxjKmA/EOqXTqQmKq8F0/A
 8ffncTNX0jHi4NVS8T0sU4lNstR69Ysm5rxJlT/9lo2h8sU2HrB+mHQTtDi8ZCsO
 BjCsRhLkvbyJ21PB9Uyolq93NobyUjHmcD6FpjFSWlTElxIYGN5nva9ZJpFNCRSz
 96L3xvRUYVwBjM3DmdXC1WMKQP7tGpvaIaXgxAFhik/bTOa5p91sQ2jEAsP55PxP
 dbbGMQYzkjjbT5FKi9mlls69zdSuG0uvzGukxcTbFWs1WIBRtfCTolvGNUDYJ4Cr
 igM6rL25u6CI0yqU1QUFjLBQp71HDvIbl5lxoSXdM4vGnT4bADiwJR+MmQARAQAB
 zS9KYW1lcyBHcmFoYW0gKEdyZXl3b2xmKSA8Z3JleXdvbGZAc3RhcndvbGYuY29t
 PsLBeAQTAQIAIgUCT3yUGgIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQ
 LIDxaJFOLfazvw//Z1GCSkxQ1Ogc7BKkRDsAsYHouMU0GerMpz/oUNnUWAQnn6EL
 WJyhxEmXyOBpyL4qZLfLYYlz29sq72w0/nsOktXNtpfjUu0yO/d3Ga0ZbsGIYbNZ
 eCwfDZ+D0dWpfXYN2WxMUlM7h4cRojnoslZqUYtonLLmFNkPx47KheywdTGXQF5d
 jYeren6HOUw5ogoQMp2mpw5p0vzdUDjZYRal73ZMMzs5gea/nwxwxJLtVoZKAkDG
 4Lm0d9Zyolccr9g9fsf4iBUvPImqJlBw1p2muWknkRlfLGsgckQ64X+zFYzZ7zGD
 PdBOxC0LG7K5q97QSS1plfrNDlINf3IBosOWFel6HNVpGvouXN1k8HlCWpPAhAom
 zbCNv/E69uYfa6pLhQa20MHxVHx1xPX/SBaxZ2YXxY7+iE1YZMwLii7FuDpX761p
 hPVsKrN0WB48kMKpszwH2/yxbD79/MEOV9oWNXvvrKt6cvy96UgytzB7TwkYUYek
 SUM0TzXe+W8lJNOlAo5m4CYPy+Kiw88gF3NV+1y7QX7ycc8WZft+2sU8zWmSM2gN
 dNzO15qifsZ6B2nile0gqs+ijQfbltaz4jWgHr0az2pNVoj6sHrOrAM+JLfEMGSy
 BZZ44ryfoqSpNTtyAxEm5djrBnVAT/ktNlwn1tUwDpQURqBMr/ZNc/OSGkTOwU0E
 T3yUGgEQALfEOQJZagHW9oEZBwuaBXLCcovEqVNA39d664d1rwK66dHfQXIUbZxd
 qhwfQktPMoya+9xc+RERM9Y9TWEfnbHMH35Ua3Uvy/w7IEmr+7h5Yb6OA2jxNKrO
 K4sDIECZDqUEBB3FLJgxCucuCN8RprZ2hgh13frEacskXUtheKeRF/12sbS4YQ/c
 r4esCvsd9WDyzAOjNssxMQ2HtdWh0YDPBOdQAje4rDeY7wF7kgDkSl2q/hjuN//T
 FLPQ67xS9ya2B7llJq5LjrQ1f5Fy05q/kMZh+rXRQLsJeqAtZ0Cya/PT8xryft3L
 tdQvvgQwwV0UqZBVQVpP7jyHmuN4PVLSL0zZo5Lrym3LRwUApe7jIm87h1Nb2l8s
 lGFjQIhqPKfgJDAkKBB24tyuPHirn8oH6NMn/Jq/rdqmmLik7Et0PRRnZYssR22S
 eTJ4y9dFccCU7POLqQs+hIVE1SIHH38742tVxqwixZLr8uZ4da0hBZ/GBeaYW4zb
 c4w5wKvsLE9lw4g45mpGuzIPjYvyYeeaIcTIFPMbOUquivJfFLIMOcyLvpNHtTH8
 F6vtqGFxsA753CDk6oEd6+PC3l0HbIpuVKVUOB/Us/JZxn3Pd3iMghwgzV0CLTmS
 OPVXXnVnZ8tZtyQNVDSs5quqEhBT0RkUfAJmo+WvlyJdZrnvq4aNABEBAAHCwV8E
 GAECAAkFAk98lBoCGwwACgkQLIDxaJFOLfY+nQ//Q9ktWlndxdNLFGUOyLsakI7k
 tqhvSMmgRcIjHl36EdwoxPcNHwdO42lGXY+/zv66Nm8z6imYCJcNsQqL3dkr62hb
 vj8s4q+EM780f/Cace3oDu3uZ0ufIWHg2aNRF1U6NgbMpW6XVgN9UrTdGhLdWADr
 H0Ju66ORcOe8Vzaf09Mlo1NZ3hQVFxeRkqJvDEx3aCn81cXO2bIhZuKXoudHxbar
 TiJ5zuKVMkjJja69fGnRvCnLETjEkdTsYh/yt48HmtBZsLAPAYBUg0qAZldpALLH
 ULjjM9F1h3iYyWTnLxh5wPysLPFAbfFE+ArYEYwPQcFQhrpHeaEb2xwKWhsxsmDP
 UBUe5mEqt3vZB9IIhVo65JAaO0kkZ7Tdy6v4cay1vFnmZCstdFVRl4FK6VIEQE+R
 wqLt7Q6nsA7hnof7bfIspQq6s+21afFcte+w1fF/MLDHcCG5J9J8taMOOzHrNNTm
 Tk218f0vEub6tT/wlsbSjAGsfZtj2Rknx0B29gjEKsEAyi0HKWyfxgHIJXANO+h8
 BBTUeSUqDcYxrLL++Ew0qWclVY2upX9notiS6n+6p2LuorRjGQy0g2dQkPDo1i5T
 xwEVfs/FsbDJYb1IWuJPQ/H9OLeCXjCTd/F8Dfb67OEUdLYLg+jjkyhVx8nmdSDG
 0kPuE1qAMj8Fczu7H4s=3D
 =3DUJZq
 -----END PGP PUBLIC KEY BLOCK-----

 --------------0R92ei28OhfjfKXXNPB509tk--

 --------------9YPLUlb1wOm6PpEOSaAjUvtg--

 --------------zA6asS5IbxrQbVmdS3FAN86X
 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="OpenPGP_signature"

 -----BEGIN PGP SIGNATURE-----

 wsF5BAABCAAjFiEEO/vQlkWoKPD1dunXLIDxaJFOLfYFAmO3kFEFAwAAAAAACgkQLIDxaJFOLfZf
 MA//Z2OC0TaDyShX0sUbBWN2xWMFb+uSgaZOsHOLsV3OAuBNCFLLLtrSMIiEmUXsHG668DPJrhfT
 id261+zphBhaFDtxXRGz8/1zI9KZ5kQO4RrXh4uJlidXSA/Oj7qkWbQPvBWmmcdSEpDWxX1jl26N
 zlj8iJa9wMUjgrFg6Y5xSTG+qyD2xBHmogntj8HTTh2k1BmTz+KEhqlwTUrbafLMT5lG0fy8S5Tf
 B5vPDqhQzf9UNDzvYlotmlpYkyN4EW72m7o5MWeMD8BbiLZF4sK3rMgGO4Wga+FdemE/cY6NH/w9
 i9RLbWj6kFIlIX2m2bmVX9Jl6fzhRjUAKyXqRDjpe6rd81fxVD3b8iT9pOQ44q48/gat6hfvXTLt
 NAIgdm0/FD6/QYFtIn3N1IWFBOX+ZYL3wGcfZHkvYuHzNTmD5G02VV1TDklHgkwhewivODSL8Gw6
 oLs9DRkOZZHYhsQ5eUaGokaVJa9OeVzDt8fCeMmGYf4a6nC0CjSiadeFrbTNfsfCPkhr19LJTHWc
 D2jFAh3WuTh+PHQNW8hpl1ukyiHvCYwTCHT9YVkCkTh+qazSSHqU+/JTTC/7ACzE7+/PR2FT9E2M
 1YzE0j3rIsbXTmWjXq8zMI/zAwoykcV3MuAvciqth3u231AIdHtFqHpfRe+1blhsSLE3QtrCP+Gf
 cxk=
 =3jpo
 -----END PGP SIGNATURE-----

 --------------zA6asS5IbxrQbVmdS3FAN86X--

State-Changed-From-To: open->closed
State-Changed-By: christos@NetBSD.org
State-Changed-When: Fri, 06 Jan 2023 12:14:14 -0500
State-Changed-Why:
committed, thanks!


From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57164 CVS commit: src/games/cribbage
Date: Fri, 6 Jan 2023 12:13:46 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan  6 17:13:46 UTC 2023

 Modified Files:
 	src/games/cribbage: crib.c cribbage.6 extern.c

 Log Message:
 PR/57164: Greywolf: Add -y to cribbage to keep playing without asking


 To generate a diff of this commit:
 cvs rdiff -u -r1.25 -r1.26 src/games/cribbage/crib.c
 cvs rdiff -u -r1.11 -r1.12 src/games/cribbage/cribbage.6
 cvs rdiff -u -r1.7 -r1.8 src/games/cribbage/extern.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57164 CVS commit: src/games/cribbage
Date: Fri, 6 Jan 2023 19:02:02 +0000

 Module Name:	src
 Committed By:	ryoon
 Date:		Fri Jan  6 19:02:02 UTC 2023

 Modified Files:
 	src/games/cribbage: cribbage.h

 Log Message:
 Define yes as extern veriable to fix build

 PR bin/57164 is insufficient.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 src/games/cribbage/cribbage.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search