NetBSD Problem Report #57323

From www@netbsd.org  Tue Apr  4 11:29:41 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3A3A91A9239
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  4 Apr 2023 11:29:41 +0000 (UTC)
Message-Id: <20230404112938.D83711A923A@mollari.NetBSD.org>
Date: Tue,  4 Apr 2023 11:29:38 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: powerpc ld.elf_so linker script override causes LOAD segment with WX permission
X-Send-Pr-Version: www-1.0

>Number:         57323
>Category:       lib
>Synopsis:       powerpc ld.elf_so linker script override causes LOAD segment with WX permission
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 04 11:30:00 +0000 2023
>Closed-Date:    Sat Aug 05 16:30:58 +0000 2023
>Last-Modified:  Sat Aug 05 16:30:58 +0000 2023
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetBSD Found linker script
>Environment:
strewn about by tornadoes
>Description:
The powerpc ld.elf_so is built with a linker script override.  It is the last architecture to have one -- all the others (mips, arm, alpha, hppa, maybe others) were deleted around 20 years ago.  The linker script was last changed in 2014, and last substantively updated in 2002, apparently according to local changes -- not documented in the commit log -- from the default GNU ld linker script.

With this archaic linker script, the powerpc ld.elf_so ends up with a single LOAD segment that has read, write, and execute (RWX) permissions, which modern GNU ld warns about, and we consider warnings fatal in the clang build, so this is breaking the clang build on powerpc platforms:

/home/builds/ab/HEAD-llvm/evbppc/202304011330Z-tools/bin/powerpc--netbsd-ld: warning: ld.elf_so has a LOAD segment with RWX permissions
powerpc--netbsd-clang: error: linker command failed with exit code 1 (use -v to see invocation)
--- ld.elf_so ---
*** Failed target: ld.elf_so
*** Failed commands:
	${_MKMSG_LINK} ${PROG}
	=> @# "   link " ld.elf_so
	${CC} ${LDFLAGS} -o ${PROG} ${OBJS} ${LDADD}
	=> /home/builds/ab/HEAD-llvm/evbppc/202304011330Z-tools/bin/powerpc--netbsd-clang  --sysroot=/home/builds/ab/HEAD-llvm/evbppc/202304011330Z-dest  -Wl,-Bsymbolic   -shared -nostartfiles -nodefaultlibs -Wl,-static -Wl,--warn-shared-textrel -Wl,--no-undefined -Wl,-Map=ld.elf_so.map -Wl,-e,_rtld_start -Wl,--script,/home/source/ab/HEAD-llvm/src/libexec/ld.elf_so/arch/powerpc/ld.so.script  -Wl,--fatal-warnings -Wl,--warn-shared-textrel -o ld.elf_so ppc_reloc.o rtld_start.o rtld.o reloc.o symbol.o xmalloc.o xprintf.o debug.o map_object.o load.o search.o headers.o paths.o expand.o tls.o symver.o diagassert.o compat.o stack_protector.o exit.o -Wl,--version-script=/home/source/ab/HEAD-llvm/src/libexec/ld.elf_so/symbols.map -L/home/builds/ab/HEAD-llvm/evbppc/202304011330Z-obj/home/source/ab/HEAD-llvm/src/lib/libc -L/home/builds/ab/HEAD-llvm/evbppc/202304011330Z-dest/usr/lib -lc_pic
	(  ${OBJCOPY} --only-keep-debug ${.TARGET} ${.TARGET}.debug  && ${OBJCOPY} --strip-debug -p -R .gnu_debuglink  --add-gnu-debuglink=${.TARGET}.debug ${.TARGET}  ) || (rm -f ${.TARGET}.debug; false)
	=> (  /home/builds/ab/HEAD-llvm/evbppc/202304011330Z-tools/bin/powerpc--netbsd-objcopy --only-keep-debug ld.elf_so ld.elf_so.debug  && /home/builds/ab/HEAD-llvm/evbppc/202304011330Z-tools/bin/powerpc--netbsd-objcopy --strip-debug -p -R .gnu_debuglink  --add-gnu-debuglink=ld.elf_so.debug ld.elf_so  ) || (rm -f ld.elf_so.debug; false)
*** [ld.elf_so] Error code 1
>How-To-Repeat:
build.sh -c clang
>Fix:
Not yet tested, but:

From 4b504eec8fdee3828e30b8d12669fe8c2cb3d329 Mon Sep 17 00:00:00 2001
From: Taylor R Campbell <riastradh@NetBSD.org>
Date: Tue, 4 Apr 2023 06:10:26 +0000
Subject: [PATCH] powerpc/ld.elf_so: Nix linker script.

No longer serves any purpose and leaves an RWX load segment, which
the linker objects to, breaking the clang build.
---
 libexec/ld.elf_so/arch/powerpc/ld.so.script | 271 --------------------
 1 file changed, 271 deletions(-)
 delete mode 100644 libexec/ld.elf_so/arch/powerpc/ld.so.script

diff --git a/libexec/ld.elf_so/arch/powerpc/ld.so.script b/libexec/ld.elf_so/arch/powerpc/ld.so.script
deleted file mode 100644
index 1132300b825d..000000000000
--- a/libexec/ld.elf_so/arch/powerpc/ld.so.script
+++ /dev/null
@@ -1,271 +0,0 @@
-OUTPUT_FORMAT("elf32-powerpc", "elf32-powerpc",
-	      "elf32-powerpc")
-OUTPUT_ARCH(powerpc:common)
-ENTRY(_start)
-/* Do we need any of these for elf?
-   __DYNAMIC = 0;    */
-PROVIDE (__stack = 0); PROVIDE (___stack = 0);
-SECTIONS
-{
-  /* Read-only sections, merged into text segment: */
-  . = 0 + SIZEOF_HEADERS;
-  .hash          : { *(.hash)		}
-  .dynsym        : { *(.dynsym)		}
-  .dynstr        : { *(.dynstr)		}
-  .gnu.version   : { *(.gnu.version)	}
-  .gnu.version_d   : { *(.gnu.version_d)	}
-  .gnu.version_r   : { *(.gnu.version_r)	}
-  .rel.init      : { *(.rel.init)	}
-  .rela.init     : { *(.rela.init)	}
-  .rel.text      :
-    {
-      *(.rel.text)
-      *(.rel.text.*)
-      *(.rel.gnu.linkonce.t.*)
-    }
-  .rela.text     :
-    {
-      *(.rela.text)
-      *(.rela.text.*)
-      *(.rela.gnu.linkonce.t.*)
-    }
-  .rel.fini      : { *(.rel.fini)	}
-  .rela.fini     : { *(.rela.fini)	}
-  .rel.rodata    :
-    {
-      *(.rel.rodata)
-      *(.rel.rodata.*)
-      *(.rel.gnu.linkonce.r.*)
-    }
-  .rela.rodata   :
-    {
-      *(.rela.rodata)
-      *(.rela.rodata.*)
-      *(.rela.gnu.linkonce.r.*)
-    }
-  .rel.data      :
-    {
-      *(.rel.data)
-      *(.rel.data.*)
-      *(.rel.gnu.linkonce.d.*)
-    }
-  .rela.data     :
-    {
-      *(.rela.data)
-      *(.rela.data.*)
-      *(.rela.gnu.linkonce.d.*)
-    }
-  .rel.ctors     : { *(.rel.ctors)	}
-  .rela.ctors    : { *(.rela.ctors)	}
-  .rel.dtors     : { *(.rel.dtors)	}
-  .rela.dtors    : { *(.rela.dtors)	}
-  .rel.got       : { *(.rel.got)		}
-  .rela.got      : { *(.rela.got)		}
-  .rel.sdata     :
-    {
-      *(.rel.sdata)
-      *(.rel.sdata.*)
-      *(.rel.gnu.linkonce.s.*)
-    }
-  .rela.sdata     :
-    {
-      *(.rela.sdata)
-      *(.rela.sdata.*)
-      *(.rela.gnu.linkonce.s.*)
-    }
-  .rel.sbss      :
-    { 
-      *(.rel.sbss)
-      *(.rel.sbss.*)
-      *(.rel.gnu.linkonce.sb.*)
-    }
-  .rela.sbss     :
-    {
-      *(.rela.sbss)
-      *(.rela.sbss.*)
-      *(.rel.gnu.linkonce.sb.*)
-    }
-  .rel.sdata2    : 
-    { 
-      *(.rel.sdata2)
-      *(.rel.sdata2.*)
-      *(.rel.gnu.linkonce.s2.*)
-    }
-  .rela.sdata2   : 
-    {
-      *(.rela.sdata2)
-      *(.rela.sdata2.*)
-      *(.rela.gnu.linkonce.s2.*)
-    }
-  .rel.sbss2     : 
-    { 
-      *(.rel.sbss2)	
-      *(.rel.sbss2.*)
-      *(.rel.gnu.linkonce.sb2.*)
-    }
-  .rela.sbss2    : 
-    { 
-      *(.rela.sbss2)	
-      *(.rela.sbss2.*)
-      *(.rela.gnu.linkonce.sb2.*)
-    }
-  .rel.bss       : 
-    { 
-      *(.rel.bss)
-      *(.rel.bss.*)
-      *(.rel.gnu.linkonce.b.*)
-    }
-  .rela.bss      : 
-    { 
-      *(.rela.bss)
-      *(.rela.bss.*)
-      *(.rela.gnu.linkonce.b.*)
-    }
-  .rel.plt       : { *(.rel.plt)		}
-  .rela.plt      : { *(.rela.plt)		}
-  .init          : 
-  { 
-    KEEP (*(.init))
-  } =0
-  .text      :
-  {
-    *(.text)
-    *(.text.*)
-    *(.stub)
-    /* .gnu.warning sections are handled specially by elf32.em.  */
-    *(.gnu.warning)
-    *(.gnu.linkonce.t.*)
-  } =0
-  .fini      :
-  {
-    KEEP (*(.fini))
-  } =0
-  PROVIDE (__etext = .);
-  PROVIDE (_etext = .);
-  PROVIDE (etext = .);
-  .rodata   : { *(.rodata) *(.rodata.*) *(.gnu.linkonce.r.*) }
-  .rodata1   : { *(.rodata1) }
-  /* Adjust the address for the data segment.  We want to adjust up to
-     the same address within the page on the next page up.  */
-  . = ALIGN(8);
-  .data    :
-  {
-    *(.data)
-    *(.data.*)
-    *(.gnu.linkonce.d.*)
-    SORT(CONSTRUCTORS)
-  }
-  .data1   : { *(.data1) }
-  .eh_frame : { KEEP (*(.eh_frame)) }
-  .gcc_except_table : { *(.gcc_except_table) }
-  .fixup	: { *(.fixup) }
-  .got1		: { *(.got1) }
-  .got2		: { *(.got2) }
-  .ctors   : 
-  {
-    /* gcc uses crtbegin.o to find the start of
-       the constructors, so we make sure it is
-       first.  Because this is a wildcard, it
-       doesn't matter if the user does not
-       actually link against crtbegin.o; the
-       linker won't look for a file to match a
-       wildcard.  The wildcard also means that it
-       doesn't matter which directory crtbegin.o
-       is in.  */
-    KEEP (*crtbegin.o(.ctors))
-    /* We don't want to include the .ctor section from
-       from the crtend.o file until after the sorted ctors.
-       The .ctor section from the crtend file contains the
-       end of ctors marker and it must be last */
-    KEEP (*(EXCLUDE_FILE (*crtend.o ) .ctors))
-    KEEP (*(SORT(.ctors.*)))
-    KEEP (*(.ctors))
-  }
-   .dtors         :
-  {
-    KEEP (*crtbegin.o(.dtors))
-    KEEP (*(EXCLUDE_FILE (*crtend.o ) .dtors))
-    KEEP (*(SORT(.dtors.*)))
-    KEEP (*(.dtors))
-  }
-  .got		  : { *(.got.plt) *(.got) }
-  PROVIDE (_GOT_END_ = .);
-  .sdata2   : { *(.sdata2) *(.sdata2.*) *(.gnu.linkonce.s2.*) }
-  .sbss2   : { *(.sbss2) *(.sbss2.*) *(.gnu.linkonce.sb2.*) }
-  .dynamic       : { *(.dynamic) }
-  /* We want the small data sections together, so single-instruction offsets
-     can access them all, and initialized data all before uninitialized, so
-     we can shorten the on-disk segment size.  */
-  .sdata     : 
-  {
-    *(.sdata) 
-    *(.sdata.*)
-    *(.gnu.linkonce.s.*)
-  }
-  _edata = .;
-  PROVIDE (edata = .);
-  __bss_start = .;
-  .sbss      :
-  {
-    PROVIDE (__sbss_start = .);
-    PROVIDE (___sbss_start = .);
-    *(.dynsbss)
-    *(.sbss)
-    *(.sbss.*)
-    *(.gnu.linkonce.sb.*)
-    *(.scommon)
-    PROVIDE (__sbss_end = .);
-    PROVIDE (___sbss_end = .);
-  }
-  .plt      : { *(.plt)	}
-  .bss       :
-  {
-   *(.dynbss)
-   *(.bss)
-   *(.bss.*)
-   *(.gnu.linkonce.b.*)
-   *(COMMON)
-   /* Align here to ensure that the .bss section occupies space up to
-      _end.  Align after .bss to ensure correct alignment even if the
-      .bss section disappears because there are no input sections.  */
-   . = ALIGN(8);
-  }
-  . = ALIGN(8);
-  _end = .;
-  __end = .;
-  PROVIDE (end = .);
-  /* Stabs debugging sections.  */
-  .stab 0 : { *(.stab) }
-  .stabstr 0 : { *(.stabstr) }
-  .stab.excl 0 : { *(.stab.excl) }
-  .stab.exclstr 0 : { *(.stab.exclstr) }
-  .stab.index 0 : { *(.stab.index) }
-  .stab.indexstr 0 : { *(.stab.indexstr) }
-  .comment 0 : { *(.comment) }
-  /* DWARF debug sections.
-     Symbols in the DWARF debugging sections are relative to the beginning
-     of the section so we begin them at 0.  */
-  /* DWARF 1 */
-  .debug          0 : { *(.debug) }
-  .line           0 : { *(.line) }
-  /* GNU DWARF 1 extensions */
-  .debug_srcinfo  0 : { *(.debug_srcinfo) }
-  .debug_sfnames  0 : { *(.debug_sfnames) }
-  /* DWARF 1.1 and DWARF 2 */
-  .debug_aranges  0 : { *(.debug_aranges) }
-  .debug_pubnames 0 : { *(.debug_pubnames) }
-  /* DWARF 2 */
-  .debug_info     0 : { *(.debug_info) *(.gnu.linkonce.wi.*) }
-  .debug_abbrev   0 : { *(.debug_abbrev) }
-  .debug_line     0 : { *(.debug_line) }
-  .debug_frame    0 : { *(.debug_frame) }
-  .debug_str      0 : { *(.debug_str) }
-  .debug_loc      0 : { *(.debug_loc) }
-  .debug_macinfo  0 : { *(.debug_macinfo) }
-  /* SGI/MIPS DWARF 2 extensions */
-  .debug_weaknames 0 : { *(.debug_weaknames) }
-  .debug_funcnames 0 : { *(.debug_funcnames) }
-  .debug_typenames 0 : { *(.debug_typenames) }
-  .debug_varnames  0 : { *(.debug_varnames) }
-  /* These must appear regardless of  .  */
-}

>Release-Note:

>Audit-Trail:
From: "Chuck Silvers" <chs@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57323 CVS commit: src/libexec/ld.elf_so/arch/powerpc
Date: Sun, 9 Apr 2023 17:24:48 +0000

 Module Name:	src
 Committed By:	chs
 Date:		Sun Apr  9 17:24:48 UTC 2023

 Modified Files:
 	src/libexec/ld.elf_so/arch/powerpc: Makefile.inc
 Removed Files:
 	src/libexec/ld.elf_so/arch/powerpc: ld.so.script

 Log Message:
 ld.elf_so powerpc: remove bogus ldscript

 This ldscript is not needed and actually makes things worse by putting
 everything in one LOAD section, which then needs to have rwx permission.
 Remove it so that we get two LOAD sections with better permissions.
 Fixes PR 57323.


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 src/libexec/ld.elf_so/arch/powerpc/Makefile.inc
 cvs rdiff -u -r1.4 -r0 src/libexec/ld.elf_so/arch/powerpc/ld.so.script

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 14 May 2023 01:34:25 +0000
State-Changed-Why:
fixed? or does this need to go into -10?


State-Changed-From-To: feedback->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 14 May 2023 01:43:16 +0000
State-Changed-Why:
needs pullups to 10 at least, if not also 9 and perhaps 8


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Wed, 02 Aug 2023 14:24:49 +0000
State-Changed-Why:
pullup-10 #306
(should maybe pull up to 9 and maybe 8 too)


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57323 CVS commit: [netbsd-10] src/libexec/ld.elf_so/arch/powerpc
Date: Fri, 4 Aug 2023 13:17:38 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Aug  4 13:17:38 UTC 2023

 Modified Files:
 	src/libexec/ld.elf_so/arch/powerpc [netbsd-10]: Makefile.inc
 Removed Files:
 	src/libexec/ld.elf_so/arch/powerpc [netbsd-10]: ld.so.script

 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #306):

 	libexec/ld.elf_so/arch/powerpc/Makefile.inc: revision 1.17
 	libexec/ld.elf_so/arch/powerpc/ld.so.script: file removal

 ld.elf_so powerpc: remove bogus ldscript

 This ldscript is not needed and actually makes things worse by putting
 everything in one LOAD section, which then needs to have rwx permission.

 Remove it so that we get two LOAD sections with better permissions.
 Fixes PR 57323.


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.16.12.1 \
     src/libexec/ld.elf_so/arch/powerpc/Makefile.inc
 cvs rdiff -u -r1.4 -r0 src/libexec/ld.elf_so/arch/powerpc/ld.so.script

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sat, 05 Aug 2023 16:30:58 +0000
State-Changed-Why:
fixed in HEAD, pulled up to 10
(not sure if worthwhile in 9 or 8, can reopen if so)


>Unformatted:

Home	PR Database Search