NetBSD Problem Report #57343

From www@netbsd.org  Tue Apr 11 18:05:54 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1F9E51A9239
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 11 Apr 2023 18:05:54 +0000 (UTC)
Message-Id: <20230411180552.BE0591A923A@mollari.NetBSD.org>
Date: Tue, 11 Apr 2023 18:05:52 +0000 (UTC)
From: jspath55@gmail.com
Reply-To: jspath55@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Typo in automated test rumpkern/t_vm.c  ('this' should say 'thus')
X-Send-Pr-Version: www-1.0

>Number:         57343
>Category:       misc
>Synopsis:       Typo in automated test rumpkern/t_vm.c  ('this' should say 'thus')
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 11 18:10:01 +0000 2023
>Closed-Date:    Tue Apr 11 18:24:16 +0000 2023
>Last-Modified:  Tue Apr 11 18:25:01 +0000 2023
>Originator:     Jim Spath
>Release:        10.0_BETA
>Organization:
>Environment:
NetBSD nb 10.0_BETA NetBSD 10.0_BETA (GENERIC64) #0: Fri Jan 13 19:15:32 UTC 2023  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/evbarm/compile/GENERIC64 evbarm

>Description:
The test is skipped, and displays this message:

busypage, skipped, this test is buggy and hits an assertion, but atf doesn't provide any way to expect that a test program crashes, this all we can do is skip

>How-To-Repeat:
Read the source.
>Fix:
Patch suggestion (which doesn't address the revealed test inadequacy):

$ diff -u rumpkern/t_vm.c  /tmp/t_vm.c
--- rumpkern/t_vm.c     2021-01-22 22:03:01.000000000 +0000
+++ /tmp/t_vm.c 2023-04-11 17:59:27.469299365 +0000
@@ -53,7 +53,7 @@
 #if 0
        atf_tc_expect_fail("test bug: unbusies an uninitialized page");
 #endif
-       atf_tc_skip("this test is buggy and hits an assertion, but atf doesn't provide any way to expect that a test program crashes, this all we can do is skip");
+       atf_tc_skip("this test is buggy and hits an assertion, but atf doesn't provide any way to expect that a test program crashes, thus all we can do is skip");
        rump_init();

        rump_schedule();

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: kre@NetBSD.org
State-Changed-When: Tue, 11 Apr 2023 18:24:16 +0000
State-Changed-Why:
Corrected as suggested, thanks for the PR.


From: "Robert Elz" <kre@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57343 CVS commit: src/tests/rump/rumpkern
Date: Tue, 11 Apr 2023 18:23:42 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Tue Apr 11 18:23:42 UTC 2023

 Modified Files:
 	src/tests/rump/rumpkern: t_vm.c

 Log Message:
 PR misc/57343 (Jim Spath) - fixed a typo in atf_tc_skip message.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/rump/rumpkern/t_vm.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search