NetBSD Problem Report #57412

From www@netbsd.org  Wed May 17 14:37:30 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E9FF21A923B
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 17 May 2023 14:37:29 +0000 (UTC)
Message-Id: <20230517143728.4A5D11A923C@mollari.NetBSD.org>
Date: Wed, 17 May 2023 14:37:28 +0000 (UTC)
From: jonthn+pkgsrc@pinacea.com
Reply-To: jonthn+pkgsrc@pinacea.com
To: gnats-bugs@NetBSD.org
Subject: lua-luv change for macOS and neovim usage
X-Send-Pr-Version: www-1.0

>Number:         57412
>Category:       pkg
>Synopsis:       lua-luv change for macOS and neovim usage
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 17 14:40:00 +0000 2023
>Closed-Date:    Sat Sep 16 09:59:19 +0000 2023
>Last-Modified:  Sat Sep 16 09:59:19 +0000 2023
>Originator:     jonathan buschmann
>Release:        pkgsrc branch since the import of neovim (as far as I can remember)
>Organization:
>Environment:
>Description:
devel/lua-luv for macOS (Darwin) requires _NO_MAGIC_
>How-To-Repeat:

>Fix:
diff --git i/devel/lua-luv/Makefile w/devel/lua-luv/Makefile
index 228daa34b01..bb18dd0b779 100644
--- i/devel/lua-luv/Makefile
+++ w/devel/lua-luv/Makefile
@@ -13,7 +13,12 @@ HOMEPAGE=    https://github.com/luvit/luv
 COMMENT=       Bare libuv bindings for Lua
 LICENSE=       apache-2.0

+.include "../../mk/bsd.prefs.mk"
+
 LUA_SELF_CONFLICT=     yes
+.if ${OPSYS} == "Darwin"
+LUA_LINKER_MAGIC=      no
+.endif

 .include "../../lang/lua/luaversion.mk"


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sun, 28 May 2023 10:03:53 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sun, 28 May 2023 10:03:53 +0000
State-Changed-Why:
I asked a question


From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57412: lua-luv change for macOS and neovim usage
Date: Sun, 28 May 2023 12:03:26 +0200

 On Wed, May 17, 2023 at 4:40=E2=80=AFPM <jonthn+pkgsrc@pinacea.com> wrote:

 > +.if ${OPSYS} =3D=3D "Darwin"
 > +LUA_LINKER_MAGIC=3D      no
 > +.endif

 I saw some other module that had the same issue. Do you know if this
 is something that should just be set for all Lua modules? (Probably
 not?)

 How can we fix this problem systematically?

 --=20
 Benny

From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57412 CVS commit: pkgsrc/devel/lua-luv
Date: Sun, 28 May 2023 10:05:36 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sun May 28 10:05:36 UTC 2023

 Modified Files:
 	pkgsrc/devel/lua-luv: Makefile

 Log Message:
 lua-luv: unset LUA_LINKER_MAGIC

 Reported by Jonathan Buschmann in PR pkg/57412.
 No conditional around the setting, since it has only an effect on Darwin
 and Cygwin.


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/devel/lua-luv/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: jonathan buschmann <jonthn@pinacea.com>
To: gnats-bugs@netbsd.org
Cc: bsiegert@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
 jonthn+pkgsrc@pinacea.com
Subject: Re: pkg/57412: lua-luv change for macOS and neovim usage
Date: Tue, 30 May 2023 11:36:33 +0800

 --=_MailMate_B384F189-FB38-452A-940D-F372C07737CF_=
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit

 Hello,

 On 28 May 2023, at 18:05, Benny Siegert wrote:

 > The following reply was made to PR pkg/57412; it has been noted by 
 > GNATS.
 >
 > From: Benny Siegert <bsiegert@gmail.com>
 > To: gnats-bugs@netbsd.org
 > Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, 
 > pkgsrc-bugs@netbsd.org
 > Subject: Re: pkg/57412: lua-luv change for macOS and neovim usage
 > Date: Sun, 28 May 2023 12:03:26 +0200
 >
 >  On Wed, May 17, 2023 at 4:40=E2=80=AFPM <jonthn+pkgsrc@pinacea.com> 
 > wrote:
 >
 >> +.if ${OPSYS} =3D=3D "Darwin"
 >> +LUA_LINKER_MAGIC=3D      no
 >> +.endif
 >
 >  I saw some other module that had the same issue. Do you know if this
 >  is something that should just be set for all Lua modules? (Probably
 >  not?)
 >

 As far I saw it’s not required for all modules but I’m not familiar 
 enough with Lua modules in general.

 >  How can we fix this problem systematically?
 >

 I don’t know if there a process that leads to proper/correct 
 generation maybe looking at the Makefile if provided to compile/link.
 And maybe going the other way and not using `bundle` will work better.

 Sorry for not helping enough on this matter.

 >  --=20
 >  Benny
 --=_MailMate_B384F189-FB38-452A-940D-F372C07737CF_=
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable

 <!DOCTYPE html>
 <html>
 <head>
 <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"=
 >
 </head>
 <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty=
 le=3D"white-space: normal;">
 <p dir=3D"auto">Hello,</p>
 <p dir=3D"auto">On 28 May 2023, at 18:05, Benny Siegert wrote:</p>
 </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote=
  style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #777=
 777; color: #777777;"><p dir=3D"auto">The following reply was made to PR =
 pkg/57412; it has been noted by GNATS.</p>
 <p dir=3D"auto">From: Benny Siegert &lt;bsiegert@gmail.com&gt;
 <br>
 To: gnats-bugs@netbsd.org
 <br>
 Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.or=
 g
 <br>
 Subject: Re: pkg/57412: lua-luv change for macOS and neovim usage
 <br>
 Date: Sun, 28 May 2023 12:03:26 +0200</p>
 <p dir=3D"auto"> On Wed, May 17, 2023 at 4:40=3DE2=3D80=3DAFPM &lt;jonthn=
 +pkgsrc@pinacea.com&gt; wrote:</p>
 <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px=
  solid #777777; border-left-color: #999999; color: #999999;"><p dir=3D"au=
 to">+.if ${OPSYS} =3D3D=3D3D "Darwin"
 <br>
 +LUA_LINKER_MAGIC=3D3D      no
 <br>
 +.endif</p>
 </blockquote><p dir=3D"auto"> I saw some other module that had the same i=
 ssue. Do you know if this
 <br>
  is something that should just be set for all Lua modules? (Probably
 <br>
  not?)</p>
 <br></blockquote></div>
 <div class=3D"markdown" style=3D"white-space: normal;">
 <p dir=3D"auto">As far I saw it=E2=80=99s not required for all modules bu=
 t I=E2=80=99m not familiar enough with Lua modules in general.</p>
 </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote=
  style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #777=
 777; color: #777777;"><p dir=3D"auto"> How can we fix this problem system=
 atically?</p>
 <br></blockquote></div>
 <div class=3D"markdown" style=3D"white-space: normal;">
 <p dir=3D"auto">I don=E2=80=99t know if there a process that leads to pro=
 per/correct generation maybe looking at the Makefile if provided to compi=
 le/link.<br>
 And maybe going the other way and not using <code style=3D"margin: 0; pad=
 ding: 0 0.4em; border-radius: 3px; background-color: #F7F7F7;">bundle</co=
 de> will work better.</p>
 <p dir=3D"auto">Sorry for not helping enough on this matter.</p>
 </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote=
  style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #777=
 777; color: #777777;"><p dir=3D"auto"> --=3D20</p>
 </blockquote></div>
 <div class=3D"markdown" style=3D"white-space: normal;">
 <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px=
  solid #777777; color: #777777;">
 <p dir=3D"auto">Benny</p>
 </blockquote>

 </div></div></body>

 </html>

 --=_MailMate_B384F189-FB38-452A-940D-F372C07737CF_=--

State-Changed-From-To: feedback->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sat, 16 Sep 2023 09:59:19 +0000
State-Changed-Why:
I committed the patch for lua-luv a while ago.
We did not reach a conclusion for a more general solution
to this problem.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.