NetBSD Problem Report #57462

From www@netbsd.org  Sat Jun 10 11:13:11 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 81DCB1A9241
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 10 Jun 2023 11:13:11 +0000 (UTC)
Message-Id: <20230610111240.15FB11A9242@mollari.NetBSD.org>
Date: Sat, 10 Jun 2023 11:12:40 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: tests/libexec/ld.elf_so should never install _g.a files
X-Send-Pr-Version: www-1.0

>Number:         57462
>Category:       misc
>Synopsis:       tests/libexec/ld.elf_so should never install _g.a files
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 10 11:15:00 +0000 2023
>Closed-Date:    Wed Aug 02 13:12:04 +0000 2023
>Last-Modified:  Wed Aug 02 13:12:04 +0000 2023
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetDebuglib Foundation
>Environment:
>Description:
https://gnats.netbsd.org/57455 created unnecessary set list entries for _g.a files that shouldn't exist in the first place, need NOSTATICLIB=yes or something for probably everything under tests/libexec/ld.elf_so/helper_*
>How-To-Repeat:

>Fix:
Yes, please!

>Release-Note:

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57462 CVS commit: src
Date: Wed, 5 Jul 2023 22:42:48 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Wed Jul  5 22:42:48 UTC 2023

 Modified Files:
 	src/distrib/sets/lists/debug: mi shl.mi
 	src/tests/libexec/ld.elf_so/helper_abuse_dynamic: Makefile
 	src/tests/libexec/ld.elf_so/helper_abuse_static: Makefile
 	src/tests/libexec/ld.elf_so/helper_def_dynamic: Makefile
 	src/tests/libexec/ld.elf_so/helper_def_static: Makefile
 	src/tests/libexec/ld.elf_so/helper_dso1: Makefile
 	src/tests/libexec/ld.elf_so/helper_dso2: Makefile
 	src/tests/libexec/ld.elf_so/helper_dso3: Makefile
 	src/tests/libexec/ld.elf_so/helper_ifunc_dso: Makefile
 	src/tests/libexec/ld.elf_so/helper_onlyctor_dynamic: Makefile
 	src/tests/libexec/ld.elf_so/helper_onlydef: Makefile
 	src/tests/libexec/ld.elf_so/helper_onlydef_static: Makefile
 	src/tests/libexec/ld.elf_so/helper_onlyuse_dynamic: Makefile
 	src/tests/libexec/ld.elf_so/helper_onlyuse_static: Makefile
 	src/tests/libexec/ld.elf_so/helper_symver_dso0: Makefile
 	src/tests/libexec/ld.elf_so/helper_symver_dso1: Makefile
 	src/tests/libexec/ld.elf_so/helper_symver_dso2: Makefile
 	src/tests/libexec/ld.elf_so/helper_use_dynamic: Makefile
 	src/tests/libexec/ld.elf_so/helper_use_static: Makefile
 Added Files:
 	src/tests/libexec/ld.elf_so: helper.mk

 Log Message:
 tests/libexec/ld.elf_so: Fix helper library makefiles.

 1. Consolidate logic into a single helper.mk to reduce duplication.
 2. Set NO* variables, not MK* variables which are reserved for user.
 3. Avoid eager X!= in favour of lazy ${X:sh}.
 4. Mark _g.a set list entries obsolete.  Never should've been built!

 PR misc/57462


 To generate a diff of this commit:
 cvs rdiff -u -r1.405 -r1.406 src/distrib/sets/lists/debug/mi
 cvs rdiff -u -r1.313 -r1.314 src/distrib/sets/lists/debug/shl.mi
 cvs rdiff -u -r0 -r1.1 src/tests/libexec/ld.elf_so/helper.mk
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_abuse_dynamic/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_abuse_static/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_def_dynamic/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_def_static/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/tests/libexec/ld.elf_so/helper_dso1/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/tests/libexec/ld.elf_so/helper_dso2/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/tests/libexec/ld.elf_so/helper_dso3/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_ifunc_dso/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_onlyctor_dynamic/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/tests/libexec/ld.elf_so/helper_onlydef/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_onlydef_static/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_onlyuse_dynamic/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_onlyuse_static/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_symver_dso0/Makefile
 cvs rdiff -u -r1.3 -r1.4 \
     src/tests/libexec/ld.elf_so/helper_symver_dso1/Makefile
 cvs rdiff -u -r1.3 -r1.4 \
     src/tests/libexec/ld.elf_so/helper_symver_dso2/Makefile
 cvs rdiff -u -r1.1 -r1.2 \
     src/tests/libexec/ld.elf_so/helper_use_dynamic/Makefile
 cvs rdiff -u -r1.2 -r1.3 \
     src/tests/libexec/ld.elf_so/helper_use_static/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Wed, 05 Jul 2023 23:36:39 +0000
State-Changed-Why:
needs pullup, once the ld.elf_so static tls fixes have gone in


State-Changed-From-To: needs-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Wed, 02 Aug 2023 13:12:04 +0000
State-Changed-Why:
fixed in HEAD, pulled up to 10


>Unformatted:

Home	PR Database Search