NetBSD Problem Report #57557

From jdwhite@pkgbuild-x86.home.menelos.com  Tue Aug  1 22:04:28 2023
Return-Path: <jdwhite@pkgbuild-x86.home.menelos.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 836061A9238
	for <gnats-bugs@gnats.netbsd.org>; Tue,  1 Aug 2023 22:04:28 +0000 (UTC)
Message-Id: <20230801220422.AB8383043B4D92@pkgbuild-x86.home.menelos.com>
Date: Tue,  1 Aug 2023 17:04:22 -0500 (CDT)
From: jdwhite@menelos.com
Reply-To:
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: audio/cdparanoia broken in macOS Ventura
X-Send-Pr-Version: 3.113.1
X-GNATS-Notify:

>Number:         57557
>Category:       pkg
>Synopsis:       Always throws assertion unless displaying usage/help.
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    gutteridge
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 01 22:05:00 +0000 2023
>Closed-Date:    Wed Aug 16 01:08:30 +0000 2023
>Last-Modified:  Wed Aug 16 01:08:30 +0000 2023
>Originator:     Jason White
>Release:        Darwin 22.6.0
>Organization:
>Environment:
System: Darwin pkgbuild-x86.home.menelos.com 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64

pkgsrc-current

>Description:
cdparanoia always throws this assertion:

  cdparanoia III release 10.2 (September 11, 2008)

  Using cdda library version: 10.2
  Using paranoia library version: 10.2
  Assertion failed: (range.location + range.length <= dataLength), function __CFDataValidateRange, file CFData.c, line 235.
  Abort trap: 6

>How-To-Repeat:
Compile, run with valid args such as '-Q --verbose'

>Fix:
https://trac.macports.org/ticket/66153

Patch the patch:

--- audio/cdparanoia/patches/patch-cn.old       2023-08-01 16:48:07
+++ audio/cdparanoia/patches/patch-cn   2023-08-01 16:35:23
@@ -153,7 +153,7 @@
 +    return -1;
 +  }
 +
-+  buf_len = CFDataGetLength(data) + 1;
++  buf_len = CFDataGetLength(data);
 +  range = CFRangeMake(0, buf_len);
 +
 +  d->raw_toc = (CDTOC *)malloc(buf_len);

Macports ticket claims to have tested on OSX Lion. Backward compatability
doesn't appear to be an issue.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->gutteridge
Responsible-Changed-By: gutteridge@NetBSD.org
Responsible-Changed-When: Wed, 16 Aug 2023 00:56:21 +0000
Responsible-Changed-Why:
I'll handle this.

From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57557 CVS commit: pkgsrc/audio/cdparanoia
Date: Wed, 16 Aug 2023 01:01:36 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Wed Aug 16 01:01:35 UTC 2023

 Modified Files:
 	pkgsrc/audio/cdparanoia: Makefile distinfo
 	pkgsrc/audio/cdparanoia/patches: patch-cn

 Log Message:
 cdparanoia: fix normal execution on recent macOS releases

 Addresses PR pkg/57557 from Jason White, who sourced the patch.


 To generate a diff of this commit:
 cvs rdiff -u -r1.40 -r1.41 pkgsrc/audio/cdparanoia/Makefile \
     pkgsrc/audio/cdparanoia/distinfo
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/audio/cdparanoia/patches/patch-cn

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Wed, 16 Aug 2023 01:08:30 +0000
State-Changed-Why:
Fix applied, thanks for the PR!

>Unformatted:

Home	PR Database Search