NetBSD Problem Report #57663

From martin@duskware.de  Mon Oct 16 08:07:02 2023
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 813471A9238
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 16 Oct 2023 08:07:02 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: wgconfig(8) does not accept --preshared-key-file option
X-Send-Pr-Version: 3.95

>Number:         57663
>Category:       bin
>Synopsis:       wgconfig(8) does not accept --preshared-key-file option
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 16 08:10:01 +0000 2023
>Closed-Date:    Mon Mar 11 22:16:53 +0000 2024
>Last-Modified:  Mon Mar 11 22:16:53 +0000 2024
>Originator:     Martin Husemann
>Release:        NetBSD 10.0_BETA
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD plug.duskware.de 10.0_BETA NetBSD 10.0_BETA (GENERIC64) #24: Sun Oct 15 16:44:36 CEST 2023 martin@seven-days-to-the-wolves.aprisoft.de:/work/src-10/sys/arch/evbarm/compile/GENERIC64 evbarm
Architecture: aarch64
Machine: evbarm
>Description:

The wgconfig man page still describes a --preshared-key-file=filename option
to the "add peer" operation. This probably has been deprecated/removed
after the windows client stopped supporting it, but documentation has
not been updated.

>How-To-Repeat:

wgconfig wg0 add peer ... .... --preshared-key-file=/etc/wg/....psk --allowed-ips=....
wgconfig: invalid option: --preshared-key-file=/etc/wg/carolina.psk


>Fix:
If this really is a documentation bug, remove the coresponding bits from the
man page.

>Release-Note:

>Audit-Trail:
From: rudolf <netbsd@eq.cz>
To: martin@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: bin/57663: wgconfig(8) does not accept --preshared-key-file
 option
Date: Sun, 14 Jan 2024 22:42:03 +0100

 This is a multi-part message in MIME format.
 --------------51A712004FE28BEE849F86D6
 Content-Type: text/plain; charset=ISO-8859-2; format=flowed
 Content-Transfer-Encoding: 7bit

 Hi Martin,

 the option is still present and works, the manual page needs a 
 correction: use "--preshared-key" instead of "--preshared-key-file".

 Kind regards,

 r.

 --------------51A712004FE28BEE849F86D6
 Content-Type: text/x-patch;
  name="wgconfig.8.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="wgconfig.8.diff"

 --- usr.sbin/wgconfig/wgconfig.8	2024-01-14 22:17:27.499579385 +0100
 +++ usr.sbin/wgconfig/wgconfig.8	2024-01-14 22:17:59.986334197 +0100
 @@ -138,7 +138,7 @@
  .Pp
  The following options may be specified:
  .Bl -tag -width abcd
 -.It Fl Fl preshared-key-file Ns Li \&= Ns Ar filename
 +.It Fl Fl preshared-key Ns Li \&= Ns Ar filename
  Set a secret preshared key generated by
  .Nm wg-keygen
  .Fl Fl psk .

 --------------51A712004FE28BEE849F86D6--

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 15 Jan 2024 08:29:52 +0000
State-Changed-Why:
Fixed, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57663 CVS commit: src/usr.sbin/wgconfig
Date: Mon, 15 Jan 2024 08:29:14 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Mon Jan 15 08:29:14 UTC 2024

 Modified Files:
 	src/usr.sbin/wgconfig: wgconfig.8

 Log Message:
 Fix typo in wgconfig(8)

 From rudolf in PR 57663


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 src/usr.sbin/wgconfig/wgconfig.8

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: closed->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sat, 09 Mar 2024 12:39:10 +0000
State-Changed-Why:
needs pullup-10


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 10 Mar 2024 15:30:43 +0000
State-Changed-Why:
pullup-10 #624
inapplicable <10, no wg


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57663 CVS commit: [netbsd-10] src/usr.sbin/wgconfig
Date: Mon, 11 Mar 2024 17:44:14 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Mar 11 17:44:14 UTC 2024

 Modified Files:
 	src/usr.sbin/wgconfig [netbsd-10]: wgconfig.8

 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #624):

 	usr.sbin/wgconfig/wgconfig.8: revision 1.11

 Fix typo in wgconfig(8)
 From rudolf in PR 57663


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.10.6.1 src/usr.sbin/wgconfig/wgconfig.8

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Mon, 11 Mar 2024 22:16:53 +0000
State-Changed-Why:
fixed and pulled up


>Unformatted:

Home	PR Database Search