NetBSD Problem Report #57706

From www@netbsd.org  Sun Nov 19 01:06:28 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2DF541A9238
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 19 Nov 2023 01:06:28 +0000 (UTC)
Message-Id: <20231119010626.46C5D1A9239@mollari.NetBSD.org>
Date: Sun, 19 Nov 2023 01:06:26 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: atf_tc_expect_fail is confused by rump panic
X-Send-Pr-Version: www-1.0

>Number:         57706
>Category:       misc
>Synopsis:       atf_tc_expect_fail is confused by rump panic
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 19 01:10:00 +0000 2023
>Closed-Date:    Sat Nov 25 18:10:37 +0000 2023
>Last-Modified:  Sun Nov 26 12:35:04 +0000 2023
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The RumpBSD Atffoundation
>Environment:
>Description:
I put atf_tc_expect_fail("...") in a test that uses rump and panics on KASSERT failure, but atf still considers the test to be a(n unexpected) failure, not an expected failure.
>How-To-Repeat:
atf_tc_expect_fail("panic");
call panic() in rump;
>Fix:
Yes, please!

>Release-Note:

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57706 CVS commit: src/sys/kern
Date: Sun, 19 Nov 2023 04:13:38 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Nov 19 04:13:38 UTC 2023

 Modified Files:
 	src/sys/kern: sys_eventfd.c

 Log Message:
 eventfd(2): Omit needless micro-optimization causing PR kern/57703.

 Unfortunately, owing to PR kern/57705 and PR misc/57706, it isn't
 convenient to flip the xfail switch on a test for this bug.  So we'll
 do that separately.  (But I did verify that a rumpified version of
 the test postd to PR kern/57703 failed without this change, and
 passed with this change.)

 PR kern/57703

 XXX pullup-10


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/sys/kern/sys_eventfd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sat, 25 Nov 2023 18:10:37 +0000
State-Changed-Why:
Solution: atf_tc_expect_signal(SIGABRT, ...)


From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57706 CVS commit: [netbsd-10] src/sys/kern
Date: Sun, 26 Nov 2023 12:33:19 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sun Nov 26 12:33:19 UTC 2023

 Modified Files:
 	src/sys/kern [netbsd-10]: sys_eventfd.c

 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #468):
 	sys/kern/sys_eventfd.c: revision 1.10
 eventfd(2): Omit needless micro-optimization causing PR kern/57703.
 Unfortunately, owing to PR kern/57705 and PR misc/57706, it isn't
 convenient to flip the xfail switch on a test for this bug.  So we'll
 do that separately.  (But I did verify that a rumpified version of
 the test postd to PR kern/57703 failed without this change, and
 passed with this change.)
 PR kern/57703
 XXX pullup-10


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.9.4.1 src/sys/kern/sys_eventfd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search