NetBSD Problem Report #57907

From h.fath@spg.tu-darmstadt.de  Wed Feb  7 13:21:54 2024
Return-Path: <h.fath@spg.tu-darmstadt.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 047C61A9238
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  7 Feb 2024 13:21:53 +0000 (UTC)
Message-Id: <202402071321.417DLg9B021477@Gstoder.nt.e-technik.tu-darmstadt.de>
Date: Wed, 7 Feb 2024 14:21:42 +0100 (CET)
From: Hauke Fath <hf@spg.tu-darmstadt.de>
Reply-To: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: x11/qt5-qtwebengine build fails
X-Send-Pr-Version: 3.95

>Number:         57907
>Category:       pkg
>Synopsis:       x11/qt5-qtwebengine build fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    markd
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 07 13:25:00 +0000 2024
>Closed-Date:    Fri Feb 16 22:52:38 +0000 2024
>Last-Modified:  Fri Feb 16 22:52:38 +0000 2024
>Originator:     Hauke Fath
>Release:        NetBSD 10.0_RC3
>Organization:
Technische Universitaet Darmstadt
>Environment:


System: NetBSD Gstoder 10.0_RC3 NetBSD 10.0_RC3 (THRIP-$Revision$) #0: Tue Jan 23 20:35:15 CET 2024 hf4kh@Hochstuhl:/var/obj/netbsd-builds/10/amd64/sys/arch/amd64/compile/THRIP amd64
Architecture: x86_64
Machine: amd64
>Description:

The build of x11/qt5-qtwebengine fails with

[...]

In file included from gen/third_party/blink/renderer/core/xml/xml_jumbo_3.cc:12:
./../../3rdparty/chromium/third_party/blink/renderer/core/xml/xsl_style_sheet_libxslt.cc: In member function 'bool blink::XSLStyleSheet::ParseString(const WTF::String&)':
./../../3rdparty/chromium/third_party/blink/renderer/core/xml/xsl_style_sheet_libxslt.cc:132:47: error: invalid conversion from 'void (*)(void*, const xmlError*)' {aka 'void (*)(void*, const _xmlError*)'} to 'xmlStructuredErrorFunc' {aka 'void (*)(void*, _xmlError*)'} [-fpermissive]
  132 |                                XSLTProcessor::ParseErrorFunc, console);
      |                                ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
      |                                               |
      |                                               void (*)(void*, const xmlError*) {aka void (*)(void*, const _xmlError*)}

[...]

In file included from gen/third_party/blink/renderer/core/xml/xml_jumbo_4.cc:7:
./../../3rdparty/chromium/third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc: In function 'xmlDoc* blink::DocLoaderFunc(const xmlChar*, xmlDictPtr, int, void*, xsltLoadType)':
./../../3rdparty/chromium/third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc:127:57: error: invalid conversion from 'void (*)(void*, const xmlError*)' {aka 'void (*)(void*, const _xmlError*)'} to 'xmlStructuredErrorFunc' {aka 'void (*)(void*, _xmlError*)'} [-fpermissive]
  127 |       xmlSetStructuredErrorFunc(console, XSLTProcessor::ParseErrorFunc);
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
      |                                                         |
      |                                                         void (*)(void*, const xmlError*) {aka void (*)(void*, const _xmlError*)}

[...]


>How-To-Repeat:

	Build the package.


>Fix:

	No Idea.



>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Wed, 07 Feb 2024 13:27:37 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Wed, 07 Feb 2024 08:56:49 -0500

 This should have already been fixed by a commit from the 3rd.
 Does it not work for you?

 Module Name:    pkgsrc
 Committed By:   markd
 Date:           Sat Feb  3 05:30:56 UTC 2024

 Modified Files:
          pkgsrc/x11/qt5-qtwebengine: distinfo
 Added Files:
          pkgsrc/x11/qt5-qtwebengine/patches:

 patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor.h

 patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor__libxslt.cc

 Log Message:
 qt5-qtwebengine: build with libxml-2.12


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/x11/qt5-qtwebengine/distinfo
 cvs rdiff -u -r0 -r1.1 \

 pkgsrc/x11/qt5-qtwebengine/patches/patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor.h 
 \

 pkgsrc/x11/qt5-qtwebengine/patches/patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor__libxslt.cc

From: "Hauke Fath (SPG)" <hf@spg.tu-darmstadt.de>
To: gnats-bugs@netbsd.org, ryoon@netbsd.org, gnats-admin@netbsd.org,
        david@gutteridge.ca
Cc: 
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Wed, 7 Feb 2024 16:45:14 +0100

 On 2024-02-07 15:00, David H. Gutteridge wrote:
 >   This should have already been fixed by a commit from the 3rd.
 >   Does it not work for you?

 As of half an hour ago it doesn't, no.

 Cheerio,
 Hauke

 -- 
       The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email	        Institut für Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
       Respect for open standards              Ruf +49-6151-16-21344

Responsible-Changed-From-To: ryoon->markd
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Wed, 07 Feb 2024 18:15:23 +0000
Responsible-Changed-Why:
Removing the patches that markd added fixed the build on NetBSD.


State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 07 Feb 2024 18:15:23 +0000
State-Changed-Why:
I'm not sure why the patches break the build - they look correct,
but perhaps an included version of libxml2 is used instead?


From: Mark Davies <mark@ecs.vuw.ac.nz>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Thu, 8 Feb 2024 09:59:11 +1300

 On 08/02/2024 07:15, wiz@NetBSD.org wrote:
 > I'm not sure why the patches break the build - they look correct,
 > but perhaps an included version of libxml2 is used instead?

 I'll take a look when I get home tonight.  I definitely needed those 
 patches to get it to build here on 10.0_RC3 a few days ago.

 cheers
 mark

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@netbsd.org
Cc: markd@netbsd.org, ryoon@netbsd.org, gnats-admin@netbsd.org, wiz@NetBSD.org
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Thu, 8 Feb 2024 11:22:28 +0100

 On Wed,  7 Feb 2024 18:15:24 +0000 (UTC), wiz@NetBSD.org wrote:
 > I'm not sure why the patches break the build - they look correct,
 > but perhaps an included version of libxml2 is used instead?

 After the rollback, the package is building again for me.

 Cheerio,
 Hauke

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

From: Mark Davies <mark@ecs.vuw.ac.nz>
To: Hauke Fath <hf@spg.tu-darmstadt.de>, gnats-bugs@netbsd.org
Cc: ryoon@netbsd.org, wiz@NetBSD.org
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Thu, 8 Feb 2024 23:43:01 +1300

 On 08/02/2024 23:22, Hauke Fath wrote:
 > On Wed,  7 Feb 2024 18:15:24 +0000 (UTC), wiz@NetBSD.org wrote:
 >> I'm not sure why the patches break the build - they look correct,
 >> but perhaps an included version of libxml2 is used instead?
 > 
 > After the rollback, the package is building again for me.

 So qt5-qtwebengine uses its own included version of libxml2, unless
 the pkgsrc version is built with the icu option in which case it uses
 that.

 I'm testing a version of the patches with code conditional on 
 LIBXML_VERSION to deal with both cases.

 cheers
 mark

From: "Mark Davies" <markd@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57907 CVS commit: pkgsrc/x11/qt5-qtwebengine
Date: Mon, 12 Feb 2024 00:52:49 +0000

 Module Name:	pkgsrc
 Committed By:	markd
 Date:		Mon Feb 12 00:52:49 UTC 2024

 Modified Files:
 	pkgsrc/x11/qt5-qtwebengine: distinfo
 Added Files:
 	pkgsrc/x11/qt5-qtwebengine/patches:
 	    patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor.h
 	    patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor__libxslt.cc

 Log Message:
 qt5-qtwebengine: re-add patches for libxml2

 this version of patches allows for both pre and post 2.12 as qtwebengine
 will use its own (older) version of libxml2 unless pkgsrc version has
 been built with icu option.  PR pkg/57907


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 pkgsrc/x11/qt5-qtwebengine/distinfo
 cvs rdiff -u -r0 -r1.3 \
     pkgsrc/x11/qt5-qtwebengine/patches/patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor.h \
     pkgsrc/x11/qt5-qtwebengine/patches/patch-src_3rdparty_chromium_third__party_blink_renderer_core_xml_xslt__processor__libxslt.cc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@netbsd.org
Cc: markd@netbsd.org, gnats-admin@netbsd.org
Subject: Re: pkg/57907 (x11/qt5-qtwebengine build fails)
Date: Thu, 15 Feb 2024 21:10:30 +0100

 On Thu,  8 Feb 2024 10:45:01 +0000 (UTC), Mark Davies wrote:
 >  I'm testing a version of the patches with code conditional on=20
 >  LIBXML_VERSION to deal with both cases.

 The updated package builds fine for me. Thanks!

 Cheerio,
 Hauke

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

State-Changed-From-To: feedback->closed
State-Changed-By: markd@NetBSD.org
State-Changed-When: Fri, 16 Feb 2024 22:52:38 +0000
State-Changed-Why:
confirmed now building.


>Unformatted:

Home	PR Database Search