NetBSD Problem Report #57941

From www@netbsd.org  Sat Feb 17 12:43:51 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4BC651A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 17 Feb 2024 12:43:51 +0000 (UTC)
Message-Id: <20240217124319.E2E051A923A@mollari.NetBSD.org>
Date: Sat, 17 Feb 2024 12:43:19 +0000 (UTC)
From: nakayamakenjiro@gmail.com
Reply-To: nakayamakenjiro@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Remove duplicated sppp_pap_scr function definition
X-Send-Pr-Version: www-1.0

>Number:         57941
>Category:       kern
>Synopsis:       Remove duplicated sppp_pap_scr function definition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 17 12:45:00 +0000 2024
>Closed-Date:    Sat Feb 17 15:48:12 +0000 2024
>Last-Modified:  Sat Feb 17 15:50:01 +0000 2024
>Originator:     Kenjiro Nakayama
>Release:        
>Organization:
>Environment:
>Description:
sys/net/if_spppsubr.c contains duplicated function definition:

static void sppp_pap_scr(struct sppp *);
static void sppp_pap_scr(struct sppp *);

One of them should be removed.

>How-To-Repeat:

>Fix:
Simply remove the duplicated function definition.

diff --git a/sys/net/if_spppsubr.c b/sys/net/if_spppsubr.c
index 2e81b001d511..0b3bec7d8fac 100644
--- a/sys/net/if_spppsubr.c
+++ b/sys/net/if_spppsubr.c
@@ -445,7 +445,6 @@ static void sppp_pap_input(struct sppp *, struct mbuf *);
 static void sppp_pap_init(struct sppp *);
 static void sppp_pap_tlu(struct sppp *);
 static void sppp_pap_scr(struct sppp *);
-static void sppp_pap_scr(struct sppp *);

 static void sppp_chap_input(struct sppp *, struct mbuf *);
 static void sppp_chap_init(struct sppp *);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sat, 17 Feb 2024 15:48:12 +0000
State-Changed-Why:
fixed, thanks for the report!


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57941 CVS commit: src/sys/net
Date: Sat, 17 Feb 2024 15:47:39 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sat Feb 17 15:47:39 UTC 2024

 Modified Files:
 	src/sys/net: if_spppsubr.c

 Log Message:
 PR 57941: remove duplciate declaration (copy+pasto)


 To generate a diff of this commit:
 cvs rdiff -u -r1.267 -r1.268 src/sys/net/if_spppsubr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search