NetBSD Problem Report #58035
From www@netbsd.org Thu Mar 14 09:00:39 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id A8EC71A9249
for <gnats-bugs@gnats.NetBSD.org>; Thu, 14 Mar 2024 09:00:39 +0000 (UTC)
Message-Id: <20240314090038.904B91A924B@mollari.NetBSD.org>
Date: Thu, 14 Mar 2024 09:00:38 +0000 (UTC)
From: jbglaw@lug-owl.de
Reply-To: jbglaw@lug-owl.de
To: gnats-bugs@NetBSD.org
Subject: [RB] evbarm/earmv6: sshramdisk probably has firmware files in a wrong place
X-Send-Pr-Version: www-1.0
>Number: 58035
>Category: port-evbarm
>Synopsis: [RB] evbarm/earmv6: sshramdisk probably has firmware files in a wrong place
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: port-evbarm-maintainer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Mar 14 09:05:00 +0000 2024
>Closed-Date: Fri Apr 19 02:32:07 +0000 2024
>Last-Modified: Fri Apr 19 02:32:07 +0000 2024
>Originator: Jan-Benedict Glaw
>Release: current
>Organization:
>Environment:
Linux lili 5.16.0-4-amd64 #1 SMP PREEMPT Debian 5.16.12-1 (2022-03-08) x86_64 GNU/Linux
NetBSD "src" trees (GIT) in /tmp/netbsd-earmv6-test1/NetBSD-src and /tmp/netbsd-earmv6-test2/NetBSD-src.
>Description:
The evbarm sshramdisk gets firmware files included (to be able to use el-cheapo USB network adapters):
distrib/evbarm/instkernel/sshramdisk/Makefile contains:
IMAGEPREBUILD= ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata/firmware ${WORKDIR}
The problem here is that all the ${DESTDIR} path is kept while copying to ${WORKDIR}, so with my setup (CI builds with randomized directories, manual builds in /tmp/netbsd-earmv6-test1/*), this ends in something like
${WORKDIR}/tmp/netbsd-earmv6-test1/_dest_/.... which is certainly not the expected destination.
So I guess that firmware loading didn't ever work as the firmware files probably ended up in the wrong place.
>How-To-Repeat:
Just build a release for eg. evbarm / earmv6 and have a look at [...]/src/distrib/evbarm/instkernel/sshramdisk/obj/work (probably with the sources not in NetBSD's standard location.) For me, I'm having temporary source trees in /tmp/netbsd-earmv6-test1 + test2 (to compare builds) running:
```
declare -a args
nb_mach=evbarm
nb_arch=earmv6
nb_srcdir="$(pwd)/NetBSD-src"
nb_reldir="$(pwd)/_rel_"
nb_destdir="$(pwd)/_dest_"
nb_tooldir="$(pwd)/_tools_"
logdir=$(pwd)
args+=(-N 4) # Be noisy.
args+=(-P) # Reproducible build.
args+=(-U) # Unprivileged build.
args+=(-u) # Don't run `make cleandir`.
args+=(-m "${nb_mach}") # Port name.
args+=(-a "${nb_arch}") # CPU architecture.
args+=(-E) # Expert mode.
args+=(-D "${nb_destdir}") # Destination directory.
args+=(-R "${nb_reldir}") # Release directory.
args+=(-T "${nb_tooldir}") # Tools directory.
#args+=(-j 4) # Build in parallel.
pushd "${nb_srcdir}"
./build.sh "${args[@]}" tools 2>&1 | tee "${logdir}/1-tools.log"
./build.sh "${args[@]}" libs 2>&1 | tee "${logdir}/2-libs.log"
./build.sh "${args[@]}" release 2>&1 | tee "${logdir}/3-release.log"
./build.sh "${args[@]}" iso-image 2>&1 | tee "${logdir}/4-iso-image.log"
./build.sh "${args[@]}" install-image 2>&1 | tee "${logdir}/5-install-image.log"
./build.sh "${args[@]}" live-image 2>&1 | tee "${logdir}/6-live-image.log"
popd
```
So destdir is "/tmp/netbsd-earmv6-test1/_dest_". With the above `nbpax`, that initial part is kept instead of only firmware files being copied into the right place.
>Fix:
I tried this patch:
diff --git a/distrib/evbarm/instkernel/sshramdisk/Makefile b/distrib/evbarm/instkernel/sshramdisk/Makefile
index 95aec3490f5c..5c964b16a267 100644
--- a/distrib/evbarm/instkernel/sshramdisk/Makefile
+++ b/distrib/evbarm/instkernel/sshramdisk/Makefile
@@ -29,7 +29,7 @@ IMAGEDEPENDS= ${CRUNCHBIN} \
${NETBSDSRCDIR}/etc/group \
${NETBSDSRCDIR}/etc/netconfig ${DISTRIBDIR}/common/protocols \
${DISTRIBDIR}/common/services
-IMAGEPREBUILD= ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata/firmware ${WORKDIR}
+IMAGEPREBUILD= (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp libdata/firmware ${WORKDIR})
# Use stubs to eliminate some large stuff from libc
HACKSRC= ${DISTRIBDIR}/utils/libhack
However, that results in
# execute checkflist
[...]
======= 259 extra files in DESTDIR =========
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
------------------------------------------
./work
./work/libdata
./work/libdata/firmware
./work/libdata/firmware/amdgpu
./work/libdata/firmware/if_athn
./work/libdata/firmware/if_athn/athn-ar7010
./work/libdata/firmware/if_athn/athn-ar7010-11
./work/libdata/firmware/if_athn/athn-ar9271
./work/libdata/firmware/if_athn/athn-license
./work/libdata/firmware/if_bwfm
./work/libdata/firmware/if_bwfm/LICENCE.broadcom_bcm43xx
./work/libdata/firmware/if_bwfm/brcmfmac43143-sdio.bin
./work/libdata/firmware/if_bwfm/brcmfmac43143.bin
./work/libdata/firmware/if_bwfm/brcmfmac43236b.bin
./work/libdata/firmware/if_bwfm/brcmfmac43241b0-sdio.bin
./work/libdata/firmware/if_bwfm/brcmfmac43241b4-sdio.bin
./work/libdata/firmware/if_bwfm/brcmfmac43241b5-sdio.bin
[...]
So I guess while trying to fix one, I broke another. Maybe you instantly recognize the issue.
>Release-Note:
>Audit-Trail:
From: Taylor R Campbell <riastradh@NetBSD.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: gnats-bugs@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has firmware files in a wrong place
Date: Thu, 14 Mar 2024 15:04:44 +0000
> Date: Thu, 14 Mar 2024 09:00:38 +0000
> From: jbglaw@lug-owl.de
>=20
> -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata=
/firmware ${WORKDIR}
> +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp =
libdata/firmware ${WORKDIR})
${WORKDIR} is probably a relative path `work', in which case this will
copy ${DESTDIR}/libdata/firmware to ${DESTDIR}/work/libdata/firmware,
which explains the checkflist errors you saw.
Can you try this change instead?
-IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata/f=
irmware ${WORKDIR}
+IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w libdata=
/firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
(I don't know if there's a way to convince a single pax -rw instance
to chdir into a source directory before taking relative paths to be
copied into the target.)
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: gnats-bugs@NetBSD.org, Taylor R Campbell <riastradh@NetBSD.org>,
netbsd-bugs@NetBSD.org
Cc:
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has
firmware files in a wrong place
Date: Thu, 14 Mar 2024 16:45:05 +0100
--oyqLL/JqMvClXZi1
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, 2024-03-14 15:04:44 +0000, Taylor R Campbell <riastradh@NetBSD.org>=
wrote:
> > Date: Thu, 14 Mar 2024 09:00:38 +0000
> > From: jbglaw@lug-owl.de
> >=20
> > -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libda=
ta/firmware ${WORKDIR}
> > +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -p=
p libdata/firmware ${WORKDIR})
>=20
> ${WORKDIR} is probably a relative path `work', in which case this will
> copy ${DESTDIR}/libdata/firmware to ${DESTDIR}/work/libdata/firmware,
> which explains the checkflist errors you saw.
>=20
> Can you try this change instead?
>=20
> -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata=
/firmware ${WORKDIR}
> +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w libda=
ta/firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
>=20
> (I don't know if there's a way to convince a single pax -rw instance
> to chdir into a source directory before taking relative paths to be
> copied into the target.)
Started two builds, will take a bit. Thanks for the suggestion!
MfG, JBG
--=20
--oyqLL/JqMvClXZi1
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZfMbgAAKCRAdvV51g5nh
u67eAJ9se4pJN53srApz7EcBajQMVkF6PwCgjt/1SgB6mz/gPoc6y7qyL9w8hIg=
=dR4Z
-----END PGP SIGNATURE-----
--oyqLL/JqMvClXZi1--
From: Christos Zoulas <christos@zoulas.com>
To: gnats-bugs@netbsd.org
Cc: port-evbarm-maintainer@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org, jbglaw@lug-owl.de
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has
firmware files in a wrong place
Date: Thu, 14 Mar 2024 11:47:13 -0400
On 2024-03-14 11:05 am, Taylor R Campbell wrote:
> The following reply was made to PR port-evbarm/58035; it has been
> noted by GNATS.
>
> From: Taylor R Campbell <riastradh@NetBSD.org>
> To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
> Cc: gnats-bugs@NetBSD.org, netbsd-bugs@NetBSD.org
> Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk
> probably has firmware files in a wrong place
> Date: Thu, 14 Mar 2024 15:04:44 +0000
>
> > Date: Thu, 14 Mar 2024 09:00:38 +0000
> > From: jbglaw@lug-owl.de
> >=20
> > -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp
> ${DESTDIR}/libdata=
> /firmware ${WORKDIR}
> > +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -rw
> -pp =
> libdata/firmware ${WORKDIR})
>
> ${WORKDIR} is probably a relative path `work', in which case this will
> copy ${DESTDIR}/libdata/firmware to ${DESTDIR}/work/libdata/firmware,
> which explains the checkflist errors you saw.
>
> Can you try this change instead?
>
> -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp
> ${DESTDIR}/libdata/f=
> irmware ${WORKDIR}
> +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w
> libdata=
> /firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
>
> (I don't know if there's a way to convince a single pax -rw instance
> to chdir into a source directory before taking relative paths to be
> copied into the target.)
Do we have to use pax? why not use tar -C?
--
christos
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Christos Zoulas <christos@zoulas.com>
Cc: gnats-bugs@netbsd.org, port-evbarm-maintainer@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has
firmware files in a wrong place
Date: Thu, 14 Mar 2024 16:54:42 +0100
--tAmVnWIZ6lqEAvSf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, 2024-03-14 11:47:13 -0400, Christos Zoulas <christos@zoulas.com> wr=
ote:
> > ${WORKDIR} is probably a relative path `work', in which case this will
> > copy ${DESTDIR}/libdata/firmware to ${DESTDIR}/work/libdata/firmware,
> > which explains the checkflist errors you saw.
> >=20
> > Can you try this change instead?
> >=20
> > -IMAGEPREBUILD=3D3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/li=
bdata/firmware ${WORKDIR}
> > +IMAGEPREBUILD=3D3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w =
libdata/firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
> >=20
> > (I don't know if there's a way to convince a single pax -rw instance
> > to chdir into a source directory before taking relative paths to be
> > copied into the target.)
>=20
> Do we have to use pax? why not use tar -C?
I'm actually quite used to use GNU tar, but TBH `pax` is way better
specified. Despite being used to a different archiver, I quite think
that `pax` is the way to go. We'll see where we end with. The hard
part was to track down there that (kernel-embedded) filesystem came
=66rom and why it contained my local build pathes. We'll see where we
end with. The hard part was to track down there that (kernel-embedded)
filesystem came from and why it contained my local build pathes.
MfG, JBG
--=20
--tAmVnWIZ6lqEAvSf
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZfMdwgAKCRAdvV51g5nh
u5L9AJ0XymSrNGGNvdtAS7zXF9OlqUyKGACfXEVTXVDIu+jF27AGad1+RY7rEiM=
=QLxR
-----END PGP SIGNATURE-----
--tAmVnWIZ6lqEAvSf--
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Taylor R Campbell <riastradh@NetBSD.org>
Cc: gnats-bugs@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has
firmware files in a wrong place
Date: Thu, 14 Mar 2024 19:35:06 +0100
--p7S+EREVcBHk3zUG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, 2024-03-14 15:04:44 +0000, Taylor R Campbell <riastradh@NetBSD.org>=
wrote:
> > Date: Thu, 14 Mar 2024 09:00:38 +0000
> > From: jbglaw@lug-owl.de
> >=20
> > -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libda=
ta/firmware ${WORKDIR}
> > +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -p=
p libdata/firmware ${WORKDIR})
>=20
> ${WORKDIR} is probably a relative path `work', in which case this will
> copy ${DESTDIR}/libdata/firmware to ${DESTDIR}/work/libdata/firmware,
> which explains the checkflist errors you saw.
>=20
> Can you try this change instead?
>=20
> -IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata=
/firmware ${WORKDIR}
> +IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w libda=
ta/firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
I tried this exact patch:
diff --git a/distrib/evbarm/instkernel/sshramdisk/Makefile b/distrib/evbarm=
/instkernel/sshramdisk/Makefile
index 95aec3490f5c..d35d1f99ffab 100644
--- a/distrib/evbarm/instkernel/sshramdisk/Makefile
+++ b/distrib/evbarm/instkernel/sshramdisk/Makefile
@@ -29,7 +29,7 @@ IMAGEDEPENDS=3D ${CRUNCHBIN} \
${NETBSDSRCDIR}/etc/group \
${NETBSDSRCDIR}/etc/netconfig ${DISTRIBDIR}/common/protocols \
${DISTRIBDIR}/common/services
-IMAGEPREBUILD=3D ${TOOL_PAX} ${PAX_TIMESTAMP} -rw -pp ${DESTDIR}/libdata/f=
irmware ${WORKDIR}
+IMAGEPREBUILD=3D (cd ${DESTDIR} && ${TOOL_PAX} ${PAX_TIMESTAMP} -w libdata=
/firmware) | (cd ${WORKDIR} && ${TOOL_PAX} -r -pp)
=20
# Use stubs to eliminate some large stuff from libc
HACKSRC=3D ${DISTRIBDIR}/utils/libhack
=2E..this builds successfully and the firmware files seem to end up in a
reasonable place:
root@lili:/tmp/netbsd-earmv6-test1/NetBSD-src/distrib/evbarm/instkernel/ssh=
ramdisk/obj/work [trunk] # find|grep firmwa|grep uco|head -10
=2E/libdata/firmware/if_iwm/LICENSE.iwlwifi-3168-ucode
=2E/libdata/firmware/if_iwm/README.iwlwifi-3168-ucode
=2E/libdata/firmware/if_iwm/iwlwifi-3160-17.ucode
=2E/libdata/firmware/if_iwm/iwlwifi-7265D-22.ucode
=2E/libdata/firmware/if_iwm/README.iwlwifi-3160-ucode
=2E/libdata/firmware/if_iwm/README.iwlwifi-7265-ucode
=2E/libdata/firmware/if_iwm/README.iwlwifi-8000-ucode
=2E/libdata/firmware/if_iwm/README.iwlwifi-7260-ucode
=2E/libdata/firmware/if_iwm/LICENSE.iwlwifi-8000-ucode
=2E/libdata/firmware/if_iwm/LICENSE.iwlwifi-7260-ucode
I obviously didn't try to _use_ the resulting installer, but it seems
to be more correct than before and this also fixes the RB issue I
noticed. Would somebody apply the patch?
Thanks,
Jan-Benedict
--=20
--p7S+EREVcBHk3zUG
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZfNDWAAKCRAdvV51g5nh
u5zaAJ4svCitml+pYDXqm333O40eAoibDgCeNAMhJc9ZiBqsDT6mUVsm1JLfAps=
=DV3l
-----END PGP SIGNATURE-----
--p7S+EREVcBHk3zUG--
State-Changed-From-To: open->analyzed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 15 Mar 2024 02:06:48 +0000
State-Changed-Why:
problem analyzed, patch proposed, feedback received
just need to apply patch now
State-Changed-From-To: analyzed->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 15 Mar 2024 02:22:27 +0000
State-Changed-Why:
needs pullup to 10, 9, 8
(although one wonders whether it matters since as far as I can tell,
this logic has been broken since it was added and it never properly
went out in a release anyway)
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58035 CVS commit: src/distrib/evbarm/instkernel/sshramdisk
Date: Fri, 15 Mar 2024 02:20:59 +0000
Module Name: src
Committed By: riastradh
Date: Fri Mar 15 02:20:59 UTC 2024
Modified Files:
src/distrib/evbarm/instkernel/sshramdisk: Makefile
Log Message:
evbarm/instkernel/sshramdisk: Put firmware in the right paths.
Maybe this should also be wired up to `release' to put the ramdisk in
the releasedir so we detect destdir path leakage like this had.
PR port-evbarm/58035
To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/distrib/evbarm/instkernel/sshramdisk/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: PR/58035 CVS commit: src/distrib/evbarm/instkernel/sshramdisk
Date: Fri, 15 Mar 2024 08:36:42 +0100
On Fri, Mar 15, 2024 at 02:25:01AM +0000, Taylor R Campbell wrote:
> Maybe this should also be wired up to `release' to put the ramdisk in
> the releasedir so we detect destdir path leakage like this had.
Images in general are a separate step from release builds, but if this
image makes sense in that configuration it should be part of the arch
specific build.sh command run on the build cluster.
If the portmaster (or whoever knows about the specifics) tells releng
this is trivial to adjust.
Martin
From: Taylor R Campbell <riastradh@NetBSD.org>
To: Martin Husemann <martin@duskware.de>
Cc: gnats-bugs@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: port-evbarm/58035: [RB] evbarm/earmv6: sshramdisk probably has firmware files in a wrong place
Date: Fri, 15 Mar 2024 18:15:29 +0000
> Date: Fri, 15 Mar 2024 08:36:42 +0100
> From: Martin Husemann <martin@duskware.de>
>=20
> Images in general are a separate step from release builds, but if this
> image makes sense in that configuration it should be part of the arch
> specific build.sh command run on the build cluster.
>=20
> If the portmaster (or whoever knows about the specifics) tells releng
> this is trivial to adjust.
This isn't a separate step. The release build produces ramdisk.fs but
not sshramdisk.fs because of the different recipes for the release
target in their respective Makefiles:
https://nxr.netbsd.org/xref/src/distrib/evbarm/instkernel/ramdisk/Makefile?=
r=3D1.21#53
https://nxr.netbsd.org/xref/src/distrib/evbarm/instkernel/sshramdisk/Makefi=
le?r=3D1.26#57
State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Thu, 04 Apr 2024 19:22:04 +0000
State-Changed-Why:
pullup-10 #657
pullup-9 #1829
pullup-8 #1955
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58035 CVS commit: [netbsd-10] src/distrib/evbarm/instkernel/sshramdisk
Date: Thu, 18 Apr 2024 15:40:17 +0000
Module Name: src
Committed By: martin
Date: Thu Apr 18 15:40:17 UTC 2024
Modified Files:
src/distrib/evbarm/instkernel/sshramdisk [netbsd-10]: Makefile
Log Message:
Pull up following revision(s) (requested by riastradh in ticket #657):
distrib/evbarm/instkernel/sshramdisk/Makefile: revision 1.26
evbarm/instkernel/sshramdisk: Put firmware in the right paths.
Maybe this should also be wired up to `release' to put the ramdisk in
the releasedir so we detect destdir path leakage like this had.
PR port-evbarm/58035
To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.25.6.1 \
src/distrib/evbarm/instkernel/sshramdisk/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58035 CVS commit: [netbsd-9] src/distrib/evbarm/instkernel/sshramdisk
Date: Thu, 18 Apr 2024 15:41:13 +0000
Module Name: src
Committed By: martin
Date: Thu Apr 18 15:41:13 UTC 2024
Modified Files:
src/distrib/evbarm/instkernel/sshramdisk [netbsd-9]: Makefile
Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1829):
distrib/evbarm/instkernel/sshramdisk/Makefile: revision 1.26
evbarm/instkernel/sshramdisk: Put firmware in the right paths.
Maybe this should also be wired up to `release' to put the ramdisk in
the releasedir so we detect destdir path leakage like this had.
PR port-evbarm/58035
To generate a diff of this commit:
cvs rdiff -u -r1.17.4.1 -r1.17.4.2 \
src/distrib/evbarm/instkernel/sshramdisk/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58035 CVS commit: [netbsd-8] src/distrib/evbarm/instkernel/sshramdisk
Date: Thu, 18 Apr 2024 15:42:45 +0000
Module Name: src
Committed By: martin
Date: Thu Apr 18 15:42:45 UTC 2024
Modified Files:
src/distrib/evbarm/instkernel/sshramdisk [netbsd-8]: Makefile
Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1955):
distrib/evbarm/instkernel/sshramdisk/Makefile: revision 1.26
evbarm/instkernel/sshramdisk: Put firmware in the right paths.
Maybe this should also be wired up to `release' to put the ramdisk in
the releasedir so we detect destdir path leakage like this had.
PR port-evbarm/58035
To generate a diff of this commit:
cvs rdiff -u -r1.15.4.1 -r1.15.4.2 \
src/distrib/evbarm/instkernel/sshramdisk/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 19 Apr 2024 02:32:07 +0000
State-Changed-Why:
fixed and pulled up
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.47 2022/09/11 19:34:41 kim Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2024
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home