NetBSD Problem Report #58220
From www@netbsd.org Wed May 1 14:16:57 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 237701A9238
for <gnats-bugs@gnats.NetBSD.org>; Wed, 1 May 2024 14:16:57 +0000 (UTC)
Message-Id: <20240501141653.B89D41A923A@mollari.NetBSD.org>
Date: Wed, 1 May 2024 14:16:53 +0000 (UTC)
From: hashikaw@mail.ru
Reply-To: hashikaw@mail.ru
To: gnats-bugs@NetBSD.org
Subject: ./newvers.sh uses platform's awk
X-Send-Pr-Version: www-1.0
>Number: 58220
>Category: toolchain
>Synopsis: ./newvers.sh uses platform's awk
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: toolchain-manager
>State: needs-pullups
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed May 01 14:20:00 +0000 2024
>Closed-Date:
>Last-Modified: Tue Jul 23 21:19:52 +0000 2024
>Originator: Kouichi Hashikawa
>Release: NetBSD-current, 10
>Organization:
>Environment:
>Description:
When building kernels, src/sys/conf/newvers.sh uses platform's awk.
>How-To-Repeat:
always.
>Fix:
I think,
(like patch for ./makeobsolete)
--- src/sys/conf/newvers.sh-162 2017-04-09 03:24:09.000000000 +0900
+++ src/sys/conf/newvers.sh 2024-05-01 10:57:34.728825591 +0900
@@ -111,6 +111,8 @@
# The result is stored in the osrelease variable.
#
+: ${AWK:=awk}
+
# FUNCTIONS
# source_lines [input] --
@@ -134,7 +136,7 @@
else
cat
fi \
- | awk '{
+ | ${AWK} '{
# awk does not care about whether or not the last line
# of input ends with a newline.
# Convert <backslash> to <backslash><backslash>.
--- src/sys/conf/newvers.mk-12 2017-04-09 03:24:09.000000000 +0900
+++ src/sys/conf/newvers.mk 2024-05-01 10:59:09.739098278 +0900
@@ -17,7 +17,7 @@
vers.o: ${SYSTEM_OBJ:O} Makefile $S/conf/newvers.sh \
$S/conf/osrelease.sh ${_NETBSD_VERSION_DEPENDS}
${_MKMSG_CREATE} vers.c
- ${HOST_SH} $S/conf/newvers.sh ${_NVFLAGS}
+ AWK=${TOOL_AWK:Q} ${HOST_SH} $S/conf/newvers.sh ${_NVFLAGS}
${_MKTARGET_COMPILE}
${CC} ${CFLAGS} ${CPPFLAGS} ${PROF} -c vers.c
${COMPILE_CTFCONVERT}
>Release-Note:
>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58220 CVS commit: src/sys/conf
Date: Wed, 1 May 2024 10:52:01 -0400
Module Name: src
Committed By: christos
Date: Wed May 1 14:52:01 UTC 2024
Modified Files:
src/sys/conf: newvers.mk newvers.sh
Log Message:
PR/58220: Kouichi Hashikawa: use ${TOOL_AWK}
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/conf/newvers.mk
cvs rdiff -u -r1.63 -r1.64 src/sys/conf/newvers.sh
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Kouichi Hashikawa <hashikaw@mail.ru>
To: gnats-bugs@netbsd.org
Cc: toolchain-manager@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org
Subject: Re: PR/58220 CVS commit: src/sys/conf
Date: Thu, 2 May 2024 00:35:58 +0900
--Apple-Mail-19CB66A6-FE60-41F5-AD72-D57BB67E6E2B
Content-Type: text/plain;
charset=us-ascii
Content-Transfer-Encoding: 7bit
>
> Module Name: src
> Committed By: christos
> Date: Wed May 1 14:52:01 UTC 2024
>
> Modified Files:
> src/sys/conf: newvers.mk newvers.sh
Thank you for applying patches.
Please pull-up to release branch.
--
Kouichi Hashikawa
--Apple-Mail-19CB66A6-FE60-41F5-AD72-D57BB67E6E2B
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><br><div dir=3D"ltr"><blockquote type=3D"ci=
te"><br></blockquote></div><blockquote type=3D"cite"><div dir=3D"ltr"><span>=
Module Name: src</span><br><span> Committed By: ch=
ristos</span><br><span> Date: Wed May 1 14:=
52:01 UTC 2024</span><br><span></span><br><span> Modified Files:</span><br><=
span> src/sys/conf: newvers.mk newvers.sh</span></div></blockq=
uote><br><div><font color=3D"#000000"><span style=3D"caret-color: rgb(0, 0, 0=
); -webkit-text-size-adjust: auto;">Thank you for applying patches.</span></=
font></div><div><font color=3D"#000000"><span style=3D"caret-color: rgb(0, 0=
, 0); -webkit-text-size-adjust: auto;">Please pull-up to release branch.</sp=
an></font></div><div><font color=3D"#000000"><span style=3D"caret-color: rgb=
(0, 0, 0); -webkit-text-size-adjust: auto;"><br></span></font></div><div><sp=
an style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); background-color=
: rgba(255, 255, 255, 0);">-- </span><div style=3D"caret-color: rgb(0, 0=
, 0); color: rgb(0, 0, 0);"><span style=3D"background-color: rgba(255, 255, 2=
55, 0);">Kouichi Hashikawa</span></div></div></body></html>=
--Apple-Mail-19CB66A6-FE60-41F5-AD72-D57BB67E6E2B--
State-Changed-From-To: open->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Tue, 23 Jul 2024 21:19:52 +0000
State-Changed-Why:
fixed in HEAD, needs pullup-10, pullup-9
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.47 2022/09/11 19:34:41 kim Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2024
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home