NetBSD Problem Report #58272

From www@netbsd.org  Wed May 22 01:28:44 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 07E5C1A9269
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 22 May 2024 01:28:44 +0000 (UTC)
Message-Id: <20240522012812.E15101A926A@mollari.NetBSD.org>
Date: Wed, 22 May 2024 01:28:12 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: libxkbcommon is wrongly built without symbol versions
X-Send-Pr-Version: www-1.0

>Number:         58272
>Category:       pkg
>Synopsis:       libxkbcommon is wrongly built without symbol versions
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 22 01:30:00 +0000 2024
>Last-Modified:  Sun Jun 02 03:05:01 +0000 2024
>Originator:     Taylor R Campbell
>Release:        netbsd-9, netbsd-10, netbsd-current; pkgsrc-current from 2024-04-06 to date
>Organization:
The NetXKB Version
>Environment:
>Description:
libxkbcommon's meson.build script broke detection of --version-script support in GNU ld, as NetBSD uses, by tacking on --undefined-version in the test, which GNU ld lacks:

diff --git a/meson.build b/meson.build
index 1ea2bf3..b2bbeac 100644
--- a/meson.build
+++ b/meson.build
@@ -145,7 +145,7 @@ configh_data.set('WIN32_LEAN_AND_MEAN', 1)
 # Supports -Wl,--version-script?
 have_version_script = cc.links(
     'int main(){}',
-    args: '-Wl,--version-script=' + meson.current_source_dir()/'xkbcommon.map',
+    args: '-Wl,--undefined-version,--version-script=' + meson.current_source_dir()/'xkbcommon.map',
     name: '-Wl,--version-script',
 )

https://github.com/xkbcommon/libxkbcommon/pull/459

This was an attempt to fix things with lld but it broke things with GNU ld.
>How-To-Repeat:
nm -gD --defined-only --with-symbol-versions $LOCALBASE/lib/libxkbcommon.so.0

and observe the lack of symbol versions
>Fix:
1. patch x11/libxkbcommon to revert this meson.build change (or tailor it to lld vs GNU ld, or pass MESON_ARGS to override the buggy test)
2. revbump and redo x11/libxkbcommon/buildlink3.mk rev. 1.5 (https://mail-index.netbsd.org/pkgsrc-changes/2024/04/06/msg296541.html) to allow >=1.5.0nb2<1.7.0 or >=1.7.0nb1
3. file an upstream issue

>Audit-Trail:
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/58272: libxkbcommon is wrongly built without symbol
 versions
Date: Sat, 1 Jun 2024 20:02:27 -0700

 Upgrading to binutils 2.40 would also fix it. 

 -- 
 Germain

Home	PR Database Search