NetBSD Problem Report #58299

From www@netbsd.org  Wed May 29 04:09:14 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id F22DB1A923A
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 29 May 2024 04:09:13 +0000 (UTC)
Message-Id: <20240529040913.10CD81A923C@mollari.NetBSD.org>
Date: Wed, 29 May 2024 04:09:13 +0000 (UTC)
From: John.P.Darrow@gmail.com
Reply-To: John.P.Darrow@gmail.com
To: gnats-bugs@NetBSD.org
Subject: icmp(8) uses unusual/inconsistent terminology
X-Send-Pr-Version: www-1.0

>Number:         58299
>Category:       bin
>Synopsis:       icmp(8) uses unusual/inconsistent terminology
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 29 04:10:00 +0000 2024
>Last-Modified:  Wed May 29 04:45:01 +0000 2024
>Originator:     John Darrow
>Release:        all branches through post-10 current
>Organization:
mostly piles
>Environment:
pick a version, any version
>Description:
icmp(8) mixes use of the terms 'ECHO_REPLY' and 'ECHO_RESPONSE' for referring to an ICMP Echo Reply packet.  This is inconsistent with both the code, and RFC 792, which consistently uses the term "Reply".
>How-To-Repeat:
man 8 ping
>Fix:
simplest: s/ECHO_RESPONSE/ECHO_REPLY/g in icmp.8 for basic consistency.

arguably, then s/ECHO_REQUEST/ICMP_ECHO/g and s/ECHO_REPLY/ICMP_ECHOREPLY/g to match the actual code in ping.c and /usr/include/netinet/ip_icmp.h .

(Also note as a point of reference that our IPv6 uses ICMP6_ECHO_REQUEST and ICMP6_ECHO_REPLY, with the additional internal underscore; but it also has its own separate ping6 utility.)

>Audit-Trail:
From: John Darrow <john.p.darrow@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/58299: icmp(8) uses unusual/inconsistent terminology
Date: Wed, 29 May 2024 04:40:14 +0000

 --000000000000609b27061990595e
 Content-Type: text/plain; charset="UTF-8"

 Of course I meant ping(8) and ping.8, not icmp(8) and icmp.8, in this pr.

 --000000000000609b27061990595e
 Content-Type: text/html; charset="UTF-8"

 <div dir="ltr"><div dir="ltr">Of course I meant ping(8) and ping.8, not icmp(8) and icmp.8, in this pr.<br></div><br></div>

 --000000000000609b27061990595e--

Home	PR Database Search