NetBSD Problem Report #58384
From www@netbsd.org Mon Jul 1 12:01:40 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 439AF1A923A
for <gnats-bugs@gnats.NetBSD.org>; Mon, 1 Jul 2024 12:01:40 +0000 (UTC)
Message-Id: <20240701120139.471D81A923C@mollari.NetBSD.org>
Date: Mon, 1 Jul 2024 12:01:39 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: amdgpu maps wrong bar for pre-bonaire chips
X-Send-Pr-Version: www-1.0
>Number: 58384
>Category: kern
>Synopsis: amdgpu maps wrong bar for pre-bonaire chips
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jul 01 12:05:00 +0000 2024
>Closed-Date: Tue Jul 23 20:52:50 +0000 2024
>Last-Modified: Tue Jul 23 20:52:50 +0000 2024
>Originator: Taylor R Campbell
>Release: current, 10
>Organization:
The NetBAR 5, no, 2, Foundation
>Environment:
>Description:
Looks like I botched a merge:
/* Registers mapping */
/* TODO: block userspace mapping of io register */
if (adev->asic_type >= CHIP_BONAIRE) {
adev->rmmio_base = pci_resource_start(adev->pdev, 5);
adev->rmmio_size = pci_resource_len(adev->pdev, 5);
} else {
adev->rmmio_base = pci_resource_start(adev->pdev, 2);
adev->rmmio_size = pci_resource_len(adev->pdev, 2);
}
#ifdef __NetBSD__
if (pci_mapreg_map(&adev->pdev->pd_pa, PCI_BAR(5),
pci_mapreg_type(adev->pdev->pd_pa.pa_pc,
adev->pdev->pd_pa.pa_tag, PCI_BAR(5)),
0,
&adev->rmmiot, &adev->rmmioh,
&adev->rmmio_base, &adev->rmmio_size))
return -EIO;
>How-To-Repeat:
use a pre-bonaire amdgpu chip
>Fix:
use BAR 2 for pre-bonaire chips
>Release-Note:
>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/58384 CVS commit: src/sys/external/bsd/drm2/dist/drm/amd/amdgpu
Date: Mon, 1 Jul 2024 12:09:52 +0000
Module Name: src
Committed By: riastradh
Date: Mon Jul 1 12:09:52 UTC 2024
Modified Files:
src/sys/external/bsd/drm2/dist/drm/amd/amdgpu: amdgpu_device.c
Log Message:
amdgpu: Map BAR 2, not BAR 5, on pre-bonaire chips.
PR kern/58384
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 \
src/sys/external/bsd/drm2/dist/drm/amd/amdgpu/amdgpu_device.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: matthew green <mrg@eterna23.net>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org
Subject: re: kern/58384: amdgpu maps wrong bar for pre-bonaire chips
Date: Tue, 02 Jul 2024 03:53:16 +1000
ah, this is probably why when trying to enable amdgpu for the gcn1
chipset fails.
note that these devices are currently handled by radeon driver, you
need to enable CONFIG_DRM_AMDGPU_SI to test this change.
.mrg.
State-Changed-From-To: open->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Tue, 23 Jul 2024 20:52:50 +0000
State-Changed-Why:
fixed in HEAD, probably not useful to pull up because this is only
for chipsets that are handled by radeon driver normally anyway
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.