NetBSD Problem Report #58391

From soda@netbsd.org  Tue Jul  2 04:25:31 2024
Return-Path: <soda@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C46901A923A
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  2 Jul 2024 04:25:31 +0000 (UTC)
Message-Id: <20240702042531.0F7C985015@mail.netbsd.org>
Date: Tue,  2 Jul 2024 04:25:31 +0000 (UTC)
From: soda@NetBSD.org
Reply-To: soda@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: re-adding syslog_ss() to syslog.h and syslog.3
X-Send-Pr-Version: 3.95

>Number:         58391
>Category:       lib
>Synopsis:       re-adding syslog_ss() to syslog.h and syslog.3
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          needs-pullups
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 02 04:30:00 +0000 2024
>Closed-Date:    
>Last-Modified:  Tue Oct 08 11:20:01 +0000 2024
>Originator:     Noriyuki Soda
>Release:        NetBSD 9.2
>Organization:
	the NetBSD project
>Environment:
System: NetBSD bruce 9.2 NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:

There is syslog_ss() function -- async-signal-safe variant of syslog() --
in our libc, but it's not defined in syslog.h and syslog.3 man page.
I believe that the reason it hasn't been defined there was
compatibility concern:
http://mail-index.netbsd.org/tech-userlevel/2006/10/27/0004.html

But because it's more than 16 years since it was implemented,
I think it's time to define them now.

>How-To-Repeat:

see syslog.h and syslog.3 man page.

>Fix:

backout the following changes:
syslog.h revision 1.30
syslog.3 revision 1.24

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58391 CVS commit: src
Date: Mon, 8 Jul 2024 18:14:31 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Mon Jul  8 22:14:31 UTC 2024

 Modified Files:
 	src/distrib/sets/lists/comp: mi
 	src/lib/libc/gen: Makefile.inc syslog.3 syslog_ss.c
 	src/lib/libc/include: extern.h
 	src/sys/sys: syslog.h

 Log Message:
 PR/58391: Noriyuki Soda: re-adding syslog_ss() to syslog.h and syslog.3


 To generate a diff of this commit:
 cvs rdiff -u -r1.2461 -r1.2462 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.217 -r1.218 src/lib/libc/gen/Makefile.inc
 cvs rdiff -u -r1.33 -r1.34 src/lib/libc/gen/syslog.3
 cvs rdiff -u -r1.3 -r1.4 src/lib/libc/gen/syslog_ss.c
 cvs rdiff -u -r1.29 -r1.30 src/lib/libc/include/extern.h
 cvs rdiff -u -r1.41 -r1.42 src/sys/sys/syslog.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58391 CVS commit: src/sys/sys
Date: Thu, 11 Jul 2024 06:05:59 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Thu Jul 11 06:05:59 UTC 2024

 Modified Files:
 	src/sys/sys: syslog.h

 Log Message:
 sys/syslog.h: Nix trailing whitespace.

 No functional change intended.

 PR 58391


 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.43 src/sys/sys/syslog.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Tue, 23 Jul 2024 20:49:35 +0000
State-Changed-Why:
Should we pull this up to netbsd-9 and netbsd-10?  The symbols are
already there, so it's not actually a compatibility break in any
direction, I think.


From: Christos Zoulas <christos@zoulas.com>
To: gnats-bugs@netbsd.org
Cc: lib-bug-people@netbsd.org,
 netbsd-bugs@netbsd.org,
 gnats-admin@netbsd.org,
 "riastradh@netbsd.org" <riastradh@NetBSD.org>,
 "soda@netbsd.org" <soda@NetBSD.org>
Subject: Re: lib/58391 (re-adding syslog_ss() to syslog.h and syslog.3)
Date: Tue, 23 Jul 2024 16:50:32 -0400

 Yes, but we have to pull up all of it (including sets)

 christos

 > On Jul 23, 2024, at 4:49=E2=80=AFPM, riastradh@netbsd.org =
 <riastradh@NetBSD.org> wrote:
 >=20
 > Synopsis: re-adding syslog_ss() to syslog.h and syslog.3
 >=20
 > State-Changed-From-To: open->needs-pullups
 > State-Changed-By: riastradh@NetBSD.org
 > State-Changed-When: Tue, 23 Jul 2024 20:49:35 +0000
 > State-Changed-Why:
 > Should we pull this up to netbsd-9 and netbsd-10?  The symbols are
 > already there, so it's not actually a compatibility break in any
 > direction, I think.
 >=20
 >=20

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58391 CVS commit: [netbsd-10] src
Date: Tue, 8 Oct 2024 11:16:19 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Oct  8 11:16:19 UTC 2024

 Modified Files:
 	src/crypto/external/bsd/openssh/dist [netbsd-10]: pfilter.c
 	src/distrib/sets/lists/base [netbsd-10]: shl.mi
 	src/distrib/sets/lists/comp [netbsd-10]: mi
 	src/distrib/sets/lists/debug [netbsd-10]: shl.mi
 	src/external/bsd/blocklist [netbsd-10]: README
 	src/external/bsd/blocklist/bin [netbsd-10]: blocklistd.8 blocklistd.c
 	    support.c support.h
 	src/external/bsd/blocklist/include [netbsd-10]: bl.h blocklist.h
 	src/external/bsd/blocklist/lib [netbsd-10]: bl.c blocklist.c
 	    libblocklist.3 shlib_version
 	src/external/bsd/blocklist/libexec [netbsd-10]: blocklistd-helper
 	src/lib/libc/gen [netbsd-10]: Makefile.inc syslog.3 syslog_ss.c
 	src/lib/libc/include [netbsd-10]: extern.h
 	src/sys/sys [netbsd-10]: syslog.h

 Log Message:
 Pull up following revision(s) (requested by rin in ticket #930):

 	lib/libc/include/extern.h: revision 1.30
 	distrib/sets/lists/base/shl.mi: revision 1.987 (patch)
 	external/bsd/blocklist/bin/support.c: revision 1.2
 	external/bsd/blocklist/bin/blocklistd.c: revision 1.5
 	external/bsd/blocklist/bin/blocklistd.8: revision 1.3
 	sys/sys/syslog.h: revision 1.42
 	external/bsd/blocklist/bin/support.h: revision 1.2
 	external/bsd/blocklist/include/blocklist.h: revision 1.3
 	crypto/external/bsd/openssh/dist/pfilter.c: revision 1.9
 	external/bsd/blocklist/lib/shlib_version: revision 1.2
 	lib/libc/gen/syslog_ss.c: revision 1.4
 	lib/libc/gen/Makefile.inc: revision 1.218
 	external/bsd/blocklist/lib/bl.c: revision 1.3
 	external/bsd/blocklist/README: revision 1.3
 	external/bsd/blocklist/include/bl.h: revision 1.2
 	distrib/sets/lists/debug/shl.mi: revision 1.347 (patch)
 	distrib/sets/lists/comp/mi: revision 1.2462
 	lib/libc/gen/syslog.3: revision 1.34
 	lib/libc/gen/syslog.3: revision 1.35
 	external/bsd/blocklist/libexec/blocklistd-helper: revision 1.8
 	external/bsd/blocklist/lib/libblocklist.3: revision 1.4
 	external/bsd/blocklist/lib/libblocklist.3: revision 1.5
 	external/bsd/blocklist/lib/libblocklist.3: revision 1.6
 	external/bsd/blocklist/lib/blocklist.c: revision 1.3

 Spelling fixes

 PR/58391: Noriyuki Soda: re-adding syslog_ss() to syslog.h and syslog.3

 syslog(3): Nix trailing whitespace in man page.
 No functional change intended.

 reference sockpath instead of sockspath

 Add blocklist_open2() that can pass a custom logger or NULL for no logging.
 Switch internally to use syslog_r. Add compatibility for systems that don't
 have syslog_r.

 Switch blocklist to use syslog_ss since we are being called from a
 signal handler.

 bump libblocklist
 remove trailing space

 Silence a bogus warning when starting up:
 NetBSD pf:
     No ALTQ support in kernel
     ALTQ related functions disabled
 FreeBSD pf:
     Anchor 'blacklistd' not found.
 The anchor is indeed found and working correctly.  This patch just
 discards stderr's output, like in other places.
 (jlduran@github)

 update markup (Ed Maste)


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.8.6.1 src/crypto/external/bsd/openssh/dist/pfilter.c
 cvs rdiff -u -r1.942.2.15 -r1.942.2.16 src/distrib/sets/lists/base/shl.mi
 cvs rdiff -u -r1.2425.2.8 -r1.2425.2.9 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.298.2.17 -r1.298.2.18 src/distrib/sets/lists/debug/shl.mi
 cvs rdiff -u -r1.2 -r1.2.6.1 src/external/bsd/blocklist/README
 cvs rdiff -u -r1.2 -r1.2.6.1 src/external/bsd/blocklist/bin/blocklistd.8
 cvs rdiff -u -r1.3.2.1 -r1.3.2.2 src/external/bsd/blocklist/bin/blocklistd.c
 cvs rdiff -u -r1.1.1.1 -r1.1.1.1.6.1 src/external/bsd/blocklist/bin/support.c \
     src/external/bsd/blocklist/bin/support.h
 cvs rdiff -u -r1.1.1.1 -r1.1.1.1.6.1 src/external/bsd/blocklist/include/bl.h
 cvs rdiff -u -r1.2 -r1.2.6.1 src/external/bsd/blocklist/include/blocklist.h
 cvs rdiff -u -r1.2 -r1.2.2.1 src/external/bsd/blocklist/lib/bl.c
 cvs rdiff -u -r1.2 -r1.2.6.1 src/external/bsd/blocklist/lib/blocklist.c
 cvs rdiff -u -r1.3 -r1.3.6.1 src/external/bsd/blocklist/lib/libblocklist.3
 cvs rdiff -u -r1.1.1.1 -r1.1.1.1.6.1 \
     src/external/bsd/blocklist/lib/shlib_version
 cvs rdiff -u -r1.7 -r1.7.2.1 \
     src/external/bsd/blocklist/libexec/blocklistd-helper
 cvs rdiff -u -r1.216 -r1.216.2.1 src/lib/libc/gen/Makefile.inc
 cvs rdiff -u -r1.33 -r1.33.16.1 src/lib/libc/gen/syslog.3
 cvs rdiff -u -r1.3 -r1.3.26.1 src/lib/libc/gen/syslog_ss.c
 cvs rdiff -u -r1.26.6.1 -r1.26.6.2 src/lib/libc/include/extern.h
 cvs rdiff -u -r1.41 -r1.41.44.1 src/sys/sys/syslog.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search