NetBSD Problem Report #58399

From www@netbsd.org  Fri Jul  5 00:26:13 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A17411A923A
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  5 Jul 2024 00:26:13 +0000 (UTC)
Message-Id: <20240705002612.AB2011A923C@mollari.NetBSD.org>
Date: Fri,  5 Jul 2024 00:26:12 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: build.sh fails in confusing way if MKX11=yes and xsrc/ exists but isn't mounted
X-Send-Pr-Version: www-1.0

>Number:         58399
>Category:       toolchain
>Synopsis:       build.sh fails in confusing way if MKX11=yes and xsrc/ exists but isn't mounted
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 05 00:30:00 +0000 2024
>Closed-Date:    Sun Oct 13 20:27:29 +0000 2024
>Last-Modified:  Sun Oct 13 20:27:29 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The NetBSD.sh -x Foundation
>Environment:
>Description:
If you have an xsrc directory, like /usr/xsrc, but it's a mount point for a file system and the file system isn't mounted, build.sh with MKX11=yes gets halfway through tools before failing in a very confusing way:

nbmake: don't know how to make makestrs.c. Stop
>How-To-Repeat:
1. create a /usr/xsrc mount point but forget to mount it
2. build.sh with MKX11=yes (or -x)
>Fix:
Teach build.sh to test for a file in xsrc, not just for an xsrc directory, early on.

>Release-Note:

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58399 CVS commit: src
Date: Fri, 5 Jul 2024 00:34:11 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Fri Jul  5 00:34:11 UTC 2024

 Modified Files:
 	src: build.sh

 Log Message:
 build.sh: Check for xsrc/Makefile, not just xsrc/.

 Should make the failure mode a little more obvious when you forget to
 mount xsrc.

 PR toolchain/58399


 To generate a diff of this commit:
 cvs rdiff -u -r1.377 -r1.378 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: matthew green <mrg@eterna23.net>
To: gnats-bugs@netbsd.org
Cc: toolchain-manager@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org
Subject: re: toolchain/58399: build.sh fails in confusing way if MKX11=yes and xsrc/ exists but isn't mounted
Date: Fri, 05 Jul 2024 13:06:43 +1000

 > >Fix:
 > Teach build.sh to test for a file in xsrc, not just for an xsrc director=
 y, early on.

 at this point i'd just confirm that xsrc/external exists as a
 directory, it's the most unlikely one to go away.


 .mrg.

State-Changed-From-To: open->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Tue, 23 Jul 2024 20:47:17 +0000
State-Changed-Why:
fix committed in HEAD, needs pullup-10 and pullup-9


From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58399 CVS commit: src
Date: Tue, 23 Jul 2024 20:46:41 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Tue Jul 23 20:46:41 UTC 2024

 Modified Files:
 	src: build.sh

 Log Message:
 build.sh: Adjust xsrc existence test as requested.

 PR toolchain/58399


 To generate a diff of this commit:
 cvs rdiff -u -r1.378 -r1.379 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 13 Oct 2024 01:13:57 +0000
State-Changed-Why:
pullup-10 #964 https://releng.netbsd.org/cgi-bin/req-10.cgi?show=964
pullup-9 #1907 https://releng.netbsd.org/cgi-bin/req-9.cgi?show=1907


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58399 CVS commit: [netbsd-10] src
Date: Sun, 13 Oct 2024 15:12:59 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Oct 13 15:12:59 UTC 2024

 Modified Files:
 	src [netbsd-10]: build.sh

 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #964):

 	build.sh: revision 1.378
 	build.sh: revision 1.379

 build.sh: Check for xsrc/Makefile, not just xsrc/.
 Should make the failure mode a little more obvious when you forget to
 mount xsrc.
 PR toolchain/58399

 build.sh: Adjust xsrc existence test as requested.
 PR toolchain/58399


 To generate a diff of this commit:
 cvs rdiff -u -r1.365.2.2 -r1.365.2.3 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58399 CVS commit: [netbsd-9] src
Date: Sun, 13 Oct 2024 15:14:32 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Oct 13 15:14:31 UTC 2024

 Modified Files:
 	src [netbsd-9]: build.sh

 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #1907):

 	build.sh: revision 1.378
 	build.sh: revision 1.379

 build.sh: Check for xsrc/Makefile, not just xsrc/.
 Should make the failure mode a little more obvious when you forget to
 mount xsrc.
 PR toolchain/58399

 build.sh: Adjust xsrc existence test as requested.
 PR toolchain/58399


 To generate a diff of this commit:
 cvs rdiff -u -r1.333.2.4 -r1.333.2.5 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 13 Oct 2024 20:27:29 +0000
State-Changed-Why:
fixed in HEAD, pulled up to 9 and 10


>Unformatted:

Home	PR Database Search