NetBSD Problem Report #58540

From www@netbsd.org  Fri Aug  2 18:18:18 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D0CD71A923E
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  2 Aug 2024 18:18:18 +0000 (UTC)
Message-Id: <20240802181817.602681A923F@mollari.NetBSD.org>
Date: Fri,  2 Aug 2024 18:18:17 +0000 (UTC)
From: phil+netbsd@krylov.eu
Reply-To: phil+netbsd@krylov.eu
To: gnats-bugs@NetBSD.org
Subject: multimedia/gst-plugins1-bad needs -std=gnu++11 with GCC 4.8
X-Send-Pr-Version: www-1.0

>Number:         58540
>Category:       pkg
>Synopsis:       multimedia/gst-plugins1-bad needs -std=gnu++11 with GCC 4.8
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 02 18:20:00 +0000 2024
>Closed-Date:    Fri Sep 27 14:27:18 +0000 2024
>Last-Modified:  Fri Sep 27 14:27:18 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
On a CentOS 7 machine, with GCC 4.8.5, the build fails:

https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240730.2238/gst-plugins1-bad-1.24.5/build.log
>How-To-Repeat:
bmake -C multimedia/gst-plugins1-bad bin-install
>Fix:
Index: multimedia/gst-plugins1-bad/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/gst-plugins1-bad/Makefile.common,v
retrieving revision 1.47
diff -p -u -r1.47 Makefile.common
--- multimedia/gst-plugins1-bad/Makefile.common	5 Mar 2024 14:45:47 -0000	1.47
+++ multimedia/gst-plugins1-bad/Makefile.common	2 Aug 2024 18:12:40 -0000
@@ -26,8 +26,9 @@ DISTNAME=	gst-plugins-bad-${GST_VERSION}
 MASTER_SITES=	https://gstreamer.freedesktop.org/src/gst-plugins-bad/
 EXTRACT_SUFX=	.tar.xz

-USE_LANGUAGES=	c c++
-USE_TOOLS+=	pkg-config
+USE_LANGUAGES=		c c++
+USE_CXX_FEATURES=	gnu++11
+USE_TOOLS+=		pkg-config

 DISTINFO_FILE=	${.CURDIR}/../../multimedia/gst-plugins1-bad/distinfo
 PATCHDIR=	${.CURDIR}/../../multimedia/gst-plugins1-bad/patches
@@ -35,6 +36,7 @@ PATCHDIR=	${.CURDIR}/../../multimedia/gs
 # "error: 'for' loop initial declarations are only allowed in C99 mode"
 # needs default visibility for fdopen (etc.) on some platforms
 FORCE_C_STD=	gnu99
+FORCE_CXX_STD=	gnu++11

 PKGCONFIG_OVERRIDE=		output/pkgconfig/*.pc
 PKGCONFIG_OVERRIDE_STAGE=	pre-install

>Release-Note:

>Audit-Trail:
From: "Nia Alarie" <nia@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58540 CVS commit: pkgsrc/multimedia/gst-plugins1-bad
Date: Sat, 3 Aug 2024 12:28:44 +0000

 Module Name:	pkgsrc
 Committed By:	nia
 Date:		Sat Aug  3 12:28:44 UTC 2024

 Modified Files:
 	pkgsrc/multimedia/gst-plugins1-bad: Makefile.common

 Log Message:
 gst-plugins1-bad: Fix building with compilers that do not default to C++11.

 via Phil Krylov, PR pkg/58540


 To generate a diff of this commit:
 cvs rdiff -u -r1.47 -r1.48 pkgsrc/multimedia/gst-plugins1-bad/Makefile.common

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 27 Sep 2024 14:27:18 +0000
State-Changed-Why:
Applied by nia


>Unformatted:

Home	PR Database Search