NetBSD Problem Report #58762

From www@netbsd.org  Sat Oct 19 22:23:47 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7FD031A923D
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 19 Oct 2024 22:23:47 +0000 (UTC)
Message-Id: <20241019222346.122071A923E@mollari.NetBSD.org>
Date: Sat, 19 Oct 2024 22:23:46 +0000 (UTC)
From: uwe@stderr.spb.ru
Reply-To: uwe@stderr.spb.ru
To: gnats-bugs@NetBSD.org
Subject: arm binary/sets/base32.tgz is bogus
X-Send-Pr-Version: www-1.0

>Number:         58762
>Notify-List:    riastradh@netbsd.org
>Category:       misc
>Synopsis:       arm binary/sets/base32.tgz is bogus
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    martin
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 19 22:25:00 +0000 2024
>Last-Modified:  Wed May 07 18:30:01 +0000 2025
>Originator:     Valery Ushakov
>Release:        NetBSD current
>Organization:
>Environment:
NetBSD xino 10.99.12 NetBSD 10.99.12 (GENERIC) #0: Sat Oct 19 06:14:24 MSK 2024  uwe@majava:/home/uwe/work/netbsd/cvs/src/sys/arch/evbarm/compile/GENERIC evbarm

>Description:
On arm base32 set is apparently for oabi compat, but it seems to have
been broken by the dynamically generated flist changes.

evbarm-earmv7hf/binary/sets/base32.tgz contains a lot of files from
base.tgz, all of mi base set or so, at first glance

  $ tar ztf base.tgz | wc -l
  6088
  $ tar ztf base32.tgz | wc -l
  2143

makeflist is clearly buggy.

On sparc64 I can see most files in print_set_lists output marked as
takecompat=sparc, but on evbarm they are all unmarked, which means
"unconditional", I guess.

>How-To-Repeat:
Build sets for evbearmv7hf-el, inspect base32.tgz
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: misc-bug-people->martin
Responsible-Changed-By: uwe@NetBSD.org
Responsible-Changed-When: Tue, 06 May 2025 14:56:58 +0000
Responsible-Changed-Why:
Martin, please review and re-route.  Requested by riastradh.
bsd.own.mk revision 1.852
date: 2015-05-29 17:15:14 +0300;  author: martin;  state: Exp;  lines: +2 -2;  commitid: LkxiqQJKu4O0Flny;
Enable MKCOMPAT for earm*, now that it works. Ok: matt@


From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: misc/58762 (arm binary/sets/base32.tgz is bogus)
Date: Wed, 7 May 2025 20:27:09 +0200

 I think this is due to a discrepancy between the compat building code
 (which e.g. on arm is only enabled when compiling with clang) and the
 set name code that only trigers on MKCOMPAT != no.

 But:

 > cd src/compat && /work/tools/bin/nbmake-evbarm -v ARCHDIR_SUBDIR -v MKCOMPAT

 yes


 so we have MKCOMPAT enabled but no subdirs for the lib builds (so we don't
 build anything).

 Untested patch below. Note that this is still inconsistent (ACTIVE_CC vs
 HAVE_GCC), but I didn't want to touch the existing aarch64 conditional.

 A better option would be to make src/distrib/sets/sets.subr invoke
 src/compat/archdirs.mk directly and extract the compat names from
 there, then build different sets for different compats.

 Martin

 Index: bsd.own.mk
 ===================================================================
 RCS file: /cvsroot/src/share/mk/bsd.own.mk,v
 retrieving revision 1.1416
 diff -u -r1.1416 bsd.own.mk
 --- bsd.own.mk	27 Apr 2025 03:48:34 -0000	1.1416
 +++ bsd.own.mk	7 May 2025 18:23:19 -0000
 @@ -1115,7 +1115,7 @@
      ${MACHINE_ARCH} == "powerpc64" || \
      (${MACHINE_ARCH} == "aarch64" && ${HAVE_GCC:U0} == 0) || \
      ${MACHINE_ARCH} == "riscv64" || \
 -    ${MACHINE_ARCH:Mearm*}
 +    (${MACHINE_ARCH:Mearm*} && ${HAVE_GCC:U0} == 0)
  MKCOMPAT?=	yes
  .else
  # Don't let this build where it really isn't supported.

>Unformatted:

Home	PR Database Search