NetBSD Problem Report #58795

From www@netbsd.org  Thu Oct 31 13:22:45 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3FEF41A9238
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 31 Oct 2024 13:22:45 +0000 (UTC)
Message-Id: <20241031132244.1DF111A923B@mollari.NetBSD.org>
Date: Thu, 31 Oct 2024 13:22:44 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: libkadm5clnt.so is built without symbol version map
X-Send-Pr-Version: www-1.0

>Number:         58795
>Category:       lib
>Synopsis:       libkadm5clnt.so is built without symbol version map
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 31 13:25:00 +0000 2024
>Last-Modified:  Fri Nov 22 02:45:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The KadmBSD Clientation
>Environment:
>Description:
Heimdal 7.1 added a symbol version map for libkadm5clnt.so (called version-script-client.map instead of version-script.map), but we still have NO_VERSION_SCRIPT wired up for it instead of using it.
>How-To-Repeat:
code inspection
>Fix:
Yes, please!

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58795 CVS commit: src/crypto/external/bsd/heimdal/lib
Date: Thu, 31 Oct 2024 15:05:53 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Thu Oct 31 15:05:53 UTC 2024

 Added Files:
 	src/crypto/external/bsd/heimdal/lib/libcom_err: com_err.expsym
 	src/crypto/external/bsd/heimdal/lib/libgssapi: gssapi.expsym
 	src/crypto/external/bsd/heimdal/lib/libhdb: hdb.expsym
 	src/crypto/external/bsd/heimdal/lib/libheimbase: heimbase.expsym
 	src/crypto/external/bsd/heimdal/lib/libheimntlm: heimntlm.expsym
 	src/crypto/external/bsd/heimdal/lib/libhx509: hx509.expsym
 	src/crypto/external/bsd/heimdal/lib/libkadm5srv: kadm5srv.expsym
 	src/crypto/external/bsd/heimdal/lib/libkdc: kdc.expsym
 	src/crypto/external/bsd/heimdal/lib/libkrb5: krb5.expsym
 	src/crypto/external/bsd/heimdal/lib/libroken: roken.expsym
 	src/crypto/external/bsd/heimdal/lib/libwind: wind.expsym

 Log Message:
 heimdal: Add expected symbols lists.

 Excluded:

 - libasn1 -- exported symbol list is currently machine-dependent
   (vax, m68k, amd64 have _end/_init/_fini; earmv7 only has _end;
   aarch64 adds _bss_end__, __end__, __bss_end__, __bss_start__; ...)
   because it just does `global: *'
 - libkafs, libsl -- no symbol version map, so exported list is
   currently machine-dependent
 - libkadm5clnt -- has a symbol version map, but we're not using it
   (PR lib/58795: libkadm5clnt.so is built without symbol version map)
   so exported symbol list is currently machine-dependent

 Preparing for adopting VERSION_MAP to fix:

 PR lib/58376: Missing DPADD for library version scripts


 To generate a diff of this commit:
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libcom_err/com_err.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libgssapi/gssapi.expsym
 cvs rdiff -u -r0 -r1.1 src/crypto/external/bsd/heimdal/lib/libhdb/hdb.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libheimbase/heimbase.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libheimntlm/heimntlm.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libhx509/hx509.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libkadm5srv/kadm5srv.expsym
 cvs rdiff -u -r0 -r1.1 src/crypto/external/bsd/heimdal/lib/libkdc/kdc.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libkrb5/krb5.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libroken/roken.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libwind/wind.expsym

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58795 CVS commit: src/crypto/external/bsd/heimdal/lib
Date: Fri, 22 Nov 2024 02:40:22 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Fri Nov 22 02:40:21 UTC 2024

 Added Files:
 	src/crypto/external/bsd/heimdal/lib/libasn1: asn1.expsym
 	src/crypto/external/bsd/heimdal/lib/libkadm5clnt: kadm5clnt.expsym
 	src/crypto/external/bsd/heimdal/lib/libkafs: kafs.expsym
 	src/crypto/external/bsd/heimdal/lib/libsl: sl.expsym

 Log Message:
 crypto/external/bsd/heimdal: Add remaining expected symbols lists.

 NOTE: libkadm5clnt.so has a symbol version map, but we're not using
 it (PR lib/58795: libkadm5clnt.so is built without symbol version
 map).

 PR lib/58838: shared libraries in base should all have expsym lists


 To generate a diff of this commit:
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libasn1/asn1.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libkadm5clnt/kadm5clnt.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/crypto/external/bsd/heimdal/lib/libkafs/kafs.expsym
 cvs rdiff -u -r0 -r1.1 src/crypto/external/bsd/heimdal/lib/libsl/sl.expsym

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search