NetBSD Problem Report #58842

From www@netbsd.org  Thu Nov 21 23:49:44 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BD3731A9238
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 21 Nov 2024 23:49:44 +0000 (UTC)
Message-Id: <20241121234943.913AA1A923E@mollari.NetBSD.org>
Date: Thu, 21 Nov 2024 23:49:43 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: libmagic leaks private and zstd symbols
X-Send-Pr-Version: www-1.0

>Number:         58842
>Category:       lib
>Synopsis:       libmagic leaks private and zstd symbols
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 21 23:50:00 +0000 2024
>Last-Modified:  Fri Nov 22 15:15:02 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The NetBSD Foundmagic.so
>Environment:
>Description:
Upstream builds libmagic with -fvisibility=hidden and exported symbols explicitly marked, but we don't, so various private symbols are exported that shouldn't be.  libmagic in HEAD also now re-exports zstd symbols.
>How-To-Repeat:
nm, code inspetion
>Fix:
use -fvisibility=hidden, update expected symbols list, bump major

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58842 CVS commit: src/external/bsd/file/lib
Date: Fri, 22 Nov 2024 15:12:38 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Fri Nov 22 15:12:38 UTC 2024

 Modified Files:
 	src/external/bsd/file/lib: Makefile

 Log Message:
 libmagic: Don't export libzstd symbols.

 Fixes part of:

 PR lib/58842: libmagic leaks private and zstd symbols

 Prompted by work on:

 PR lib/58838: shared libraries in base should all have expsym lists


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 src/external/bsd/file/lib/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search