NetBSD Problem Report #58843

From www@netbsd.org  Fri Nov 22 00:07:09 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id AFE411A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 22 Nov 2024 00:07:09 +0000 (UTC)
Message-Id: <20241122000708.5F5171A923E@mollari.NetBSD.org>
Date: Fri, 22 Nov 2024 00:07:08 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: libevent leaks private symbols
X-Send-Pr-Version: www-1.0

>Number:         58843
>Category:       lib
>Synopsis:       libevent leaks private symbols
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          suspended
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 22 00:10:00 +0000 2024
>Closed-Date:    
>Last-Modified:  Sun Nov 24 04:25:08 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The NetBSD Eventually.so
>Environment:
>Description:
Upstream builds libevent with -fvisibility=hidden and exported symbols explicitly marked, but we don't, so various private symbols are exported that shouldn't be, like `kqops'.
>How-To-Repeat:
nm, code inspection
>Fix:
use -fvisibility=hidden, update expected symbols list, bump major

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->suspended
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 22 Nov 2024 18:28:12 +0000
State-Changed-Why:
upstream only limits visibility for cmake build and it's not clearly
fully baked, so I guess we'll just live with this for now


From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58843 CVS commit: src/external/bsd/libevent/lib
Date: Sun, 24 Nov 2024 04:24:52 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Nov 24 04:24:52 UTC 2024

 Added Files:
 	src/external/bsd/libevent/lib/libevent: event.expsym
 	src/external/bsd/libevent/lib/libevent_openssl: event_openssl.expsym
 	src/external/bsd/libevent/lib/libevent_pthreads: event_pthreads.expsym

 Log Message:
 external/bsd/libevent: Add expected symbols list.

 NOTE: This contains a lot of crud that shouldn't be there because
 we're not building with -fvisibility=hidden (PR lib/58843: libevent
 leaks private).  To be fixed in a separate commit, once we figure out
 how upstream is really supposed to be built.

 PR lib/58838: shared libraries in base should all have expsym lists


 To generate a diff of this commit:
 cvs rdiff -u -r0 -r1.1 src/external/bsd/libevent/lib/libevent/event.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/external/bsd/libevent/lib/libevent_openssl/event_openssl.expsym
 cvs rdiff -u -r0 -r1.1 \
     src/external/bsd/libevent/lib/libevent_pthreads/event_pthreads.expsym

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search