NetBSD Problem Report #58851

From www@netbsd.org  Sun Nov 24 15:08:22 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D8A521A9238
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 24 Nov 2024 15:08:21 +0000 (UTC)
Message-Id: <20241124150820.D8E0F1A923E@mollari.NetBSD.org>
Date: Sun, 24 Nov 2024 15:08:20 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: wg-keygen(8) needs tests, abuses libssh
X-Send-Pr-Version: www-1.0

>Number:         58851
>Category:       bin
>Synopsis:       wg-keygen(8) needs tests, abuses libssh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 24 15:10:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The libNetWG-keygen Foundation
>Environment:
>Description:
1. wg-keygen (no arguments) should have a randomized property test of the fixed bits.
2. wg-keygen --pub is a deterministic function which needs known-answer tests.  (Plain wg-keygen and wg-keygen --psk should maybe also have seed-determinized tests.)
3. wg-keygen grabs its X25519 scalarmult routine (crypto_scalarmult_curve25519) from libssh, which it really shouldn't; libssh is an unstable private library of openssh.  We should either get it from OpenSSL, or maybe reachover into the kernel libsodium code.
>How-To-Repeat:
code inspection
>Fix:
Yes, please!

Home	PR Database Search