NetBSD Problem Report #58989

From www@netbsd.org  Sun Jan 12 15:22:44 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2F2E31A923A
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Jan 2025 15:22:44 +0000 (UTC)
Message-Id: <20250112152242.BA16D1A923B@mollari.NetBSD.org>
Date: Sun, 12 Jan 2025 15:22:42 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: audio/qmmp: missing PLIST conditionals for dbus
X-Send-Pr-Version: www-1.0

>Number:         58989
>Category:       pkg
>Synopsis:       audio/qmmp: missing PLIST conditionals for dbus
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 12 15:25:00 +0000 2025
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetQMMP Dbustitution
>Environment:
>Description:
Various components of audio/qmmp are conditional on whether qt was built with dbus.  Excerpt of qmmp-1.6.5/src/plugins/General/CMakeLists.txt:

IF(USE_MPRIS AND Qt5DBus_FOUND)
add_subdirectory(mpris)
ENDIF(USE_MPRIS AND Qt5DBus_FOUND)
...
IF(USE_KDENOTIFY AND Qt5DBus_FOUND)
add_subdirectory(kdenotify)
ENDIF(USE_KDENOTIFY AND Qt5DBus_FOUND)

Building qt with -dbus leads to the following build failure:

  => Checking file-check results for qmmp-1.6.5nb12
  ERROR: ************************************************************
  ERROR: The following files are in the PLIST but not in /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4:
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libgnomehotkey.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libkdenotify.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libmpris.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libsleepinhibitor.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libudisks.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/app_icon.png
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/empty_cover.png

>How-To-Repeat:
1. set PKG_DEFAULT_OPTIONS+=-dbus
2. build audio/qmmp
>Fix:
Yes, please!

(May want to add some of this to PRINT_PLIST_AWK to help future maintainers too.)

Home	PR Database Search