NetBSD Problem Report #59100

From o.vd.linden@quicknet.nl  Mon Feb 24 19:33:06 2025
Return-Path: <o.vd.linden@quicknet.nl>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E772C1A923A
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 24 Feb 2025 19:33:05 +0000 (UTC)
Message-Id: <Z7zJbcmP1-WgJ9e3@sheep>
Date: Mon, 24 Feb 2025 20:33:01 +0100
From: Onno van der Linden <o.vd.linden@quicknet.nl>
Reply-To:
To: gnats-bugs@netbsd.org
Subject: compat fixes from Nov 22 2024 break cvsup 1.6ZC static binary

>Number:         59100
>Notify-List:    riastradh@NetBSD.org
>Category:       kern
>Synopsis:       compat patch from Nov 22 2024 breaks cvsup for monolithic kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          needs-pullups
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 24 19:35:00 +0000 2025
>Closed-Date:    
>Last-Modified:  Mon Mar 03 15:38:04 +0000 2025
>Originator:     Onno van der Linden <o.vd.linden@quicknet.nl>
>Release:        NetBSD 10.99.12
>Organization:
>Environment:
System: NetBSD sheep 10.99.12 NetBSD 10.99.12 (SHEEP) #2: Mon Feb 24 19:59:44 CET 2025 root@sheep:/usr/src/sys/arch/amd64/compile/SHEEP amd64
Architecture: x86_64
Machine: amd64
>Description:
Trying to run cvsup (/usr/pkg/bin/cvsup: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, for NetBSD 1.6ZC, stripped)
on my monolithic kernel (everything is compiled in) fails miserably.

ktrace shows

  3574   3574 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSYS,0xffffe838,0xffffe818,0x80e9a00,2)
  3574   3574 cvsup    RET   netbsd32___sigaction_sigtramp 0
  3574   3574 cvsup    CALL  compat_16_netbsd32___sigreturn14(0)
  3574   3574 cvsup    RET   compat_16_netbsd32___sigreturn14 -1 errno 14 Bad address
followed by netbsd32__sigaction_sigtramp returning -1 with errno 22 (EINVAL) for all the other signals not named SIGSYS.

All this is caused by the Nov 22 2024 commit

"Crude patch to allow building and loading of compat_16 and compat_netbsd32_16 code on aarch64." from Nov 22 2024. because this patch 


>How-To-Repeat:
Run the 1.6ZC cvsup binary (with fully configured configuration files of course) on a monolithic x86 kernel.
>Fix:
After some debugging printf's I came up with this patch after which my cvsup test ran flawlessly and imported the new acpica and sbin/efi. No idea if it's correct though .........

--- /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig	2025-02-24 20:10:38.789270837 +0100
+++ /usr/src/sys/compat/netbsd32/netbsd32_signal.c	2025-02-24 20:12:37.675593950 +0100
@@ -209,7 +209,7 @@
 			/*
 			 * Module is already loaded and locked in memory
 			 */
-			sigcontext_valid = netbsd32_sendsig_sigcontext_16_hook.hooked;
+			sigcontext_valid = 1;
 		}
 		if (!sigcontext_valid) {
 			return EINVAL;

>Release-Note:

>Audit-Trail:
From: Onno van der Linden <o.vd.linden@quicknet.nl>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Mon, 24 Feb 2025 22:35:17 +0100

 Additional data which shows that my "fix" (setting sigcontext_valid to 1)
 might work for cvsup but isn't correct if I look at 2 ktrace's.
 First ktrace is cvsup running on 10.99.10 from June 14 2024:

    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSYS,0xffffe8f8,0xffffe8d8,0x80e9a00,2)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  compat_16_netbsd32___sigreturn14(0)
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_16/compat_netbsd32_16.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_16/compat_netbsd32_16.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_20/compat_netbsd32_20.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_20/compat_netbsd32_20.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_30/compat_netbsd32_30.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_30/compat_netbsd32_30.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_40/compat_netbsd32_40.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_netbsd32_40/compat_netbsd32_40.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_40/compat_40.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_40/compat_40.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_30/compat_30.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_30/compat_30.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_20/compat_20.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_20/compat_20.plist"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_16/compat_16.kmod"
    661    661 cvsup    NAMI  "/stand/amd64/10.99.10/modules/compat_16/compat_16.plist"
    661    661 cvsup    RET   compat_16_netbsd32___sigreturn14 RESTART
    661    661 cvsup    CALL  compat_16_netbsd32___sigreturn14(0)
    661    661 cvsup    RET   compat_16_netbsd32___sigreturn14 -1 errno 14 Bad address
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSYS,0xffffe8d8,0,0x80e9a00,2)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGHUP,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGINT,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGQUIT,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSEGV,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGPIPE,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0
    661    661 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGTERM,0xffffe978,0xffffe958,0x80e9a1c,1)
    661    661 cvsup    RET   netbsd32___sigaction_sigtramp 0

 Second ktrace from a 10.99.12 kernel from Feb 23rd 2025:

  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSYS,0xffffe758,0xffffe738,0x80e9a00,2)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  compat_16_netbsd32___sigreturn14(0)
  22873  22873 cvsup    RET   compat_16_netbsd32___sigreturn14 -1 errno 14 Bad address
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSYS,0xffffe738,0,0x80e9a00,2)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGHUP,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp -1 errno 22 Invalid argument
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGHUP,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGINT,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGQUIT,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGSEGV,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGPIPE,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0
  22873  22873 cvsup    CALL  netbsd32___sigaction_sigtramp(SIGTERM,0xffffe7d8,0xffffe7b8,0x80e9a1c,1)
  22873  22873 cvsup    RET   netbsd32___sigaction_sigtramp 0

 ls -l /stand/amd64/10.99.1[02]/modules/compat_16/* gives me:

 -r--r--r--  1 root  wheel  15056 Jun 17  2024 /stand/amd64/10.99.10/modules/compat_16/compat_16.kmod
 -r--r--r--  1 root  wheel  15056 Feb 16 23:28 /stand/amd64/10.99.12/modules/compat_16/compat_16.kmod

 So why isn't the 10.99.12 kernel ktrace not showing any NAMI lines for the kmod files ?

From: Onno van der Linden <o.vd.linden@quicknet.nl>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Wed, 26 Feb 2025 21:23:46 +0100

 compat_netbsd32_16_init() in compat/netbsd32/netbsd32_compat_16.c 
 places netbsd32_machdep_md_16_init() inside an #ifdef construction
 that's skipped on amd64. Due to the skipping of netbsd32_machdep_md_16_init()
 netbsd32_sendsig_sigcontext_16_hook.hooked isn't set to a non-zero value
 and sigcontext_valid in netbsd32___sigaction_sigtramp() thus remains 0.

 Instead of the quick and dirty hack of setting  sigcontext_valid to 1 in
 netbsd32___sigaction_sigtramp() netbsd32_machdep_md_16_init() should be called
 for architectures (like amd64) that need it.

 >  So why isn't the 10.99.12 kernel ktrace not showing any NAMI lines for the kmod files ?

 That's also caused by the current version of netbsd32_compat_16.c
 The exec_sigcode_alloc() inside of #ifdef __HAVE_MD_NETBSD32_SIGCODE
 probably triggers some internal kmod loading which might or might not
 be necessary.

From: Onno van der Linden <o.vd.linden@quicknet.nl>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Thu, 27 Feb 2025 22:17:25 +0100

 The current code in netbsd32_compat_16 defines __HAVE_MD_NETBSD32_SIGRETURN14
 for __amd64__ in /sys/compat/netbsd32/netbsd32_compat_16.c.

 /sys/arch/amd64/amd64/netbd32_sigcode.S contains both netbsd32_sigcode
 and netbsd32_esigcode. It looks to me like __HAVE_MD_NETBSD32_SIGCODE
 should be defined for __amd64__ too in
 /sys/compat/netbsd32_/netbsd32_compat_16.c.

 And with


 --- /sys/compat/netbsd32/netbsd32_compat_16.c.orig	2025-02-26 10:49:56.871640011 +0100
 +++ /sys/compat/netbsd32/netbsd32_compat_16.c	2025-02-27 22:10:57.245055044 +0100
 @@ -52,7 +52,7 @@
  #define __HAVE_MD_NETBSD32_SIGRETURN14
  #endif

 -#if defined(__arm__) || defined(__mips__) || defined(__powerpc__) || defined(__riscv__)
 +#if defined(__amd64__) || defined(__arm__) || defined(__mips__) || defined(__powerpc__) || defined(__riscv__)
  #define __HAVE_MD_NETBSD32_SIGCODE
  #endif

 cvsup runs fine.

From: Christos Zoulas <christos@zoulas.com>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org,
 gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Fri, 28 Feb 2025 11:07:16 -0500

 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27
 Content-Type: multipart/alternative;
 	boundary="Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185"


 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii

 Is the below still needed?


 --- /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig	2025-02-24 =
 20:10:38.789270837 +0100
 +++ /usr/src/sys/compat/netbsd32/netbsd32_signal.c	2025-02-24 =
 20:12:37.675593950 +0100
 @@ -209,7 +209,7 @@
 			/*
 			 * Module is already loaded and locked in memory
 			 */
 -			sigcontext_valid =3D =
 netbsd32_sendsig_sigcontext_16_hook.hooked;
 +			sigcontext_valid =3D 1;
 		}
 		if (!sigcontext_valid) {
 			return EINVAL;

 Or is the following enough?


 --- /sys/compat/netbsd32/netbsd32_compat_16.c.orig	2025-02-26 =
 10:49:56.871640011 +0100
 +++ /sys/compat/netbsd32/netbsd32_compat_16.c	2025-02-27 =
 22:10:57.245055044 +0100
 @@ -52,7 +52,7 @@
  #define __HAVE_MD_NETBSD32_SIGRETURN14
  #endif

 -#if defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)
 +#if defined(__amd64__) || defined(__arm__) || defined(__mips__) || =
 defined(__powerpc__) || defined(__riscv__)
  #define __HAVE_MD_NETBSD32_SIGCODE
  #endif

 christos=

 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=us-ascii

 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
 charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
 -webkit-nbsp-mode: space; line-break: after-white-space;">Is the below =
 still needed?<br id=3D"lineBreakAtBeginningOfMessage"><div><br><font =
 color=3D"#5856d6"><span style=3D"caret-color: rgb(88, 86, =
 214);"><br></span></font>--- =
 /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-24 20:10:38.789270837 +0100<br>+++ =
 /usr/src/sys/compat/netbsd32/netbsd32_signal.c<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-24 20:12:37.675593950 +0100<br>@@ -209,7 +209,7 =
 @@<br><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>/*<br><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span> * Module is already loaded and locked in memory<br><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span> =
 */<br>-<span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>sigcontext_valid =3D =
 netbsd32_sendsig_sigcontext_16_hook.hooked;<br>+<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>sigcontext_valid =3D 1;<br><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>}<br><span class=3D"Apple-tab-span"=
  style=3D"white-space: pre;">	</span><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>if (!sigcontext_valid) =
 {<br><div><div> <span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span>return EINVAL;<br></div></div></div><br><div>Or is the following =
 enough?</div><div><br></div><div><br>--- =
 /sys/compat/netbsd32/netbsd32_compat_16.c.orig<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-26 10:49:56.871640011 +0100<br>+++ =
 /sys/compat/netbsd32/netbsd32_compat_16.c<span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>2025-02-27 22:10:57.245055044 =
 +0100<br>@@ -52,7 +52,7 @@<br>&nbsp;#define =
 __HAVE_MD_NETBSD32_SIGRETURN14<br>&nbsp;#endif<br><br>-#if =
 defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)<br>+#if defined(__amd64__) || defined(__arm__) || =
 defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)<br>&nbsp;#define =
 __HAVE_MD_NETBSD32_SIGCODE<br>&nbsp;#endif<br></div><div><br></div><div>ch=
 ristos</div></body></html>=

 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185--

 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP

 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org

 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCZ8HfNAAKCRBxESqxbLM7
 OvUwAKCktH5I6ElTv+OBWDIpkG69UoOI4ACbB1w1ha5FxP6ymjUzzdR3mq+IGKw=
 =2cl3
 -----END PGP SIGNATURE-----

 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27--

From: Onno van der Linden <o.vd.linden@quicknet.nl>
To: gnats-bugs@netbsd.org
Cc: christos@netbsd.org
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Fri, 28 Feb 2025 17:53:44 +0100

 On Fri, Feb 28, 2025 at 04:10:04PM +0000, Christos Zoulas via gnats wrote:
 >  Is the below still needed?

 No, absolutely not. sigcontext_valid = 1 was just a workaround,
 not a correct fix.

 >  
 >  
 >  --- /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig	2025-02-24 =
 >  20:10:38.789270837 +0100
 >  +++ /usr/src/sys/compat/netbsd32/netbsd32_signal.c	2025-02-24 =
 >  20:12:37.675593950 +0100
 >  @@ -209,7 +209,7 @@
 >  			/*
 >  			 * Module is already loaded and locked in memory
 >  			 */
 >  -			sigcontext_valid =3D =
 >  netbsd32_sendsig_sigcontext_16_hook.hooked;
 >  +			sigcontext_valid =3D 1;
 >  		}
 >  		if (!sigcontext_valid) {
 >  			return EINVAL;
 >  
 >  Or is the following enough?

 Yes, this is the correct fix. I'm running with it on my system
 and cvsup works correct.

 >  
 >  
 >  --- /sys/compat/netbsd32/netbsd32_compat_16.c.orig	2025-02-26 =
 >  10:49:56.871640011 +0100
 >  +++ /sys/compat/netbsd32/netbsd32_compat_16.c	2025-02-27 =
 >  22:10:57.245055044 +0100
 >  @@ -52,7 +52,7 @@
 >   #define __HAVE_MD_NETBSD32_SIGRETURN14
 >   #endif
 >  
 >  -#if defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 >  defined(__riscv__)
 >  +#if defined(__amd64__) || defined(__arm__) || defined(__mips__) || =
 >  defined(__powerpc__) || defined(__riscv__)
 >   #define __HAVE_MD_NETBSD32_SIGCODE
 >   #endif

 Onno

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59100 CVS commit: src/sys/compat/netbsd32
Date: Fri, 28 Feb 2025 12:58:06 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Feb 28 17:58:06 UTC 2025

 Modified Files:
 	src/sys/compat/netbsd32: netbsd32_compat_16.c

 Log Message:
 PR/59100: Onno van der Linden: i386 compat32 broken on amd64


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/sys/compat/netbsd32/netbsd32_compat_16.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Onno van der Linden <o.vd.linden@quicknet.nl>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Sat, 1 Mar 2025 11:54:26 +0100

 This one can be closed.

 Thanks very much,

 Onno

State-Changed-From-To: open->closed
State-Changed-By: christos@NetBSD.org
State-Changed-When: Sat, 01 Mar 2025 10:07:59 -0500
State-Changed-Why:
confirmed fixed


State-Changed-From-To: closed->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 02 Mar 2025 14:27:37 +0000
State-Changed-Why:
Is this fixed in netbsd-10 too or do we need pullups?

Do we have any automatic tests that exercise this?  It has been an
absolute nightmare and extremely embarrassing; we really need some
more automatic testing if this kind of bug isn't getting caught by
any of our releng test beds.


>Unformatted:

Home	PR Database Search