NetBSD Problem Report #59102

From igor@lenovo.home  Tue Feb 25 08:35:11 2025
Return-Path: <igor@lenovo.home>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 58FBD1A923A
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 25 Feb 2025 08:35:11 +0000 (UTC)
Message-Id: <20250225082729.5F9A6BF125B@lenovo.home>
Date: Tue, 25 Feb 2025 09:27:29 +0100 (CET)
From: igor@kolesnik.es
Reply-To: igor@kolesnik.es
To: gnats-bugs@NetBSD.org
Subject: updated xxx_modcmd() signature in module(9) manpage
X-Send-Pr-Version: 3.95

>Number:         59102
>Category:       misc
>Synopsis:       updated xxx_modcmd() signature in module(9) manpage
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          needs-pullups
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 25 08:40:01 +0000 2025
>Closed-Date:    
>Last-Modified:  Sun Mar 02 13:37:40 +0000 2025
>Originator:     Igor Kolesnik
>Release:        NetBSD 10.99.12
>Organization:

>Environment:


System: NetBSD lenovo.home 10.99.12 NetBSD 10.99.12 (LENOVO) #9: Tue Feb 25 08:20:10 CET 2025 igor@lenovo.home:/usr/obj/sys/arch/amd64/compile/LENOVO amd64
Architecture: x86_64
Machine: amd64
>Description:
	The module(9) manpage states that the return value of the xxx_modcmd() function
	is of type 'modcmd_t'.

	The actual return type of the function is 'int'.
>How-To-Repeat:

>Fix:
	There is a patch.

Index: share/man/man9/module.9
===================================================================
RCS file: /cvsroot/src/share/man/man9/module.9,v
retrieving revision 1.54
diff -u -r1.54 module.9
--- share/man/man9/module.9	12 Aug 2022 15:43:38 -0000	1.54
+++ share/man/man9/module.9	25 Feb 2025 08:13:46 -0000
@@ -182,7 +182,7 @@
 function.
 This function is defined as:
 .Bl -tag -width modcmd -offset indent
-.It Ft modcmd_t
+.It Ft int
 .Fn xxx_modcmd "modcmd_t cmd" "void *data"
 .El
 .Pp

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 25 Feb 2025 08:52:19 +0000
State-Changed-Why:
Patch applied, thanks!


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59102 CVS commit: src/share/man/man9
Date: Tue, 25 Feb 2025 08:51:28 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Feb 25 08:51:28 UTC 2025

 Modified Files:
 	src/share/man/man9: module.9

 Log Message:
 PR 59102: fix signature of module callback function.


 To generate a diff of this commit:
 cvs rdiff -u -r1.54 -r1.55 src/share/man/man9/module.9

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: closed->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 02 Mar 2025 13:37:40 +0000
State-Changed-Why:
man page is broken in netbsd-9 and netbsd-10 too


>Unformatted:

Home	PR Database Search