NetBSD Problem Report #59368

From www@netbsd.org  Sun Apr 27 20:59:25 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4DA8B1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 27 Apr 2025 20:59:25 +0000 (UTC)
Message-Id: <20250427205924.281DD1A923C@mollari.NetBSD.org>
Date: Sun, 27 Apr 2025 20:59:24 +0000 (UTC)
From: nia@pkgsrc.org
Reply-To: nia@pkgsrc.org
To: gnats-bugs@NetBSD.org
Subject: SSP disabled on MIPS, works on at least mips64eb
X-Send-Pr-Version: www-1.0

>Number:         59368
>Category:       port-mips
>Synopsis:       SSP disabled on MIPS, works on at least mips64eb
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-mips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 27 21:00:00 +0000 2025
>Last-Modified:  Mon Apr 28 19:55:01 +0000 2025
>Originator:     nia
>Release:        current
>Organization:
The NetB[1]   Abort trap (core dumped)
>Environment:
>Description:
We do not use -fstack-protector by default on any of our mips
port. We probably should, since it works on at least mips64eb.
>How-To-Repeat:

>Fix:
it's a one-line change to share/mk but needs testing
on all mips variants

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: port-mips/59368: SSP disabled on MIPS, works on at least mips64eb
Date: Mon, 28 Apr 2025 15:31:55 +0200

 Works on evbmipsn64-eb, boots multiuser and tests seem to pass:

 [/usr/tests/lib/libc/ssp] martin@supremacy > atf-run | atf-report
 Tests root: /usr/tests/lib/libc/ssp

 t_ssp (1/1): 20 test cases
     fgets: [0.580011s] Passed.
     getcwd: [0.390007s] Passed.
     getcwd2: [0.290005s] Passed.
     gets: [0.500009s] Passed.
     memcpy: [0.380007s] Passed.
     memmove: [0.380007s] Passed.
     memset: [0.430007s] Passed.
     raw: [0.380007s] Passed.
     read: [0.450008s] Passed.
     readlink: [0.390007s] Passed.
     snprintf: [0.370007s] Passed.
     sprintf: [0.430008s] Passed.
     stpcpy: [0.380007s] Passed.
     stpncpy: [0.380007s] Passed.
     strcat: [0.470008s] Passed.
     strcpy: [0.380007s] Passed.
     strncat: [0.380007s] Passed.
     strncpy: [0.460008s] Passed.
     vsnprintf: [0.370007s] Passed.
     vsprintf: [0.470009s] Passed.
 [8.330153s]

 Summary for 1 test programs:
     20 passed test cases.
     0 failed test cases.
     0 expected failed test cases.
     0 skipped test cases.

 No (new) issues noticed during light testing.


 Martin

From: "Nia Alarie" <nia@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59368 CVS commit: src/share/mk
Date: Mon, 28 Apr 2025 19:54:49 +0000

 Module Name:	src
 Committed By:	nia
 Date:		Mon Apr 28 19:54:49 UTC 2025

 Modified Files:
 	src/share/mk: bsd.own.mk

 Log Message:
 mk: Enable SSP on MIPS, since it works and defends properly.

 Also carry over RELRO enablement to n64 variants.

 PR pkg/59368


 To generate a diff of this commit:
 cvs rdiff -u -r1.1416 -r1.1417 src/share/mk/bsd.own.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search