NetBSD Problem Report #59385

From www@netbsd.org  Fri May  2 17:36:50 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3314E1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  2 May 2025 17:36:50 +0000 (UTC)
Message-Id: <20250502173648.B44B41A923C@mollari.NetBSD.org>
Date: Fri,  2 May 2025 17:36:48 +0000 (UTC)
From: jiaxun.yang@flygoat.com
Reply-To: jiaxun.yang@flygoat.com
To: gnats-bugs@NetBSD.org
Subject: PGSHIFT is inconsistently defined on MIPS
X-Send-Pr-Version: www-1.0

>Number:         59385
>Category:       port-evbmips
>Synopsis:       PGSHIFT is inconsistently defined on MIPS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-evbmips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 02 17:40:00 +0000 2025
>Last-Modified:  Sat May 03 02:05:03 +0000 2025
>Originator:     Jiaxun Yang
>Release:        current
>Organization:
>Environment:
N/A
>Description:
Include of opt_cputype.h is missing from mips_param.h, where PGSHIFT is defined based on ENABLE_MIPS_*KB_PAGE macros. This is causing PGSHIFT to be defined inconsistently between kernel sources.
>How-To-Repeat:
Build and run kernel with ENABLE_MIPS_16KB_PAGE enabled.
>Fix:
Patch: https://github.com/FlyGoat/netbsd-src/commit/8daa4bcbe6357b6c1779d784a8b60a1d652c747c.patch

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59385 CVS commit: src/sys/arch/mips
Date: Sat, 3 May 2025 02:00:46 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sat May  3 02:00:46 UTC 2025

 Modified Files:
 	src/sys/arch/mips/include: cache.h mips_param.h
 	src/sys/arch/mips/mips: fp.S mips_emul.c mips_fixup.c mips_fputrap.c
 	    process_machdep.c
 	src/sys/arch/mips/rmi: rmixlreg.h

 Log Message:
 mips: Include opt_cputype.h before any of the flags it defines.

 PR port-evbmips/59385: PGSHIFT is inconsistently defined on MIPS


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 src/sys/arch/mips/include/cache.h
 cvs rdiff -u -r1.54 -r1.55 src/sys/arch/mips/include/mips_param.h
 cvs rdiff -u -r1.59 -r1.60 src/sys/arch/mips/mips/fp.S
 cvs rdiff -u -r1.31 -r1.32 src/sys/arch/mips/mips/mips_emul.c
 cvs rdiff -u -r1.23 -r1.24 src/sys/arch/mips/mips/mips_fixup.c
 cvs rdiff -u -r1.12 -r1.13 src/sys/arch/mips/mips/mips_fputrap.c
 cvs rdiff -u -r1.39 -r1.40 src/sys/arch/mips/mips/process_machdep.c
 cvs rdiff -u -r1.5 -r1.6 src/sys/arch/mips/rmi/rmixlreg.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59385 CVS commit: src/sys/arch/mips/include
Date: Sat, 3 May 2025 02:00:57 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sat May  3 02:00:57 UTC 2025

 Modified Files:
 	src/sys/arch/mips/include: mips_param.h

 Log Message:
 mips_param.h: Add include guard.

 Prompted by nearby fix for:

 PR port-evbmips/59385: PGSHIFT is inconsistently defined on MIPS


 To generate a diff of this commit:
 cvs rdiff -u -r1.55 -r1.56 src/sys/arch/mips/include/mips_param.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search