NetBSD Problem Report #59438

From www@netbsd.org  Thu May 22 01:54:36 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 541621A923C
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 22 May 2025 01:54:36 +0000 (UTC)
Message-Id: <20250522015435.1ADEE1A923E@mollari.NetBSD.org>
Date: Thu, 22 May 2025 01:54:35 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: GENERIC content can't be in GENERIC.local because of XEN3_DOM* kernels
X-Send-Pr-Version: www-1.0

>Number:         59438
>Category:       port-xen
>Synopsis:       GENERIC content can't be in GENERIC.local because of XEN3_DOM* kernels
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bad
>State:          needs-pullups
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 22 01:55:00 +0000 2025
>Closed-Date:    
>Last-Modified:  Thu May 22 11:18:49 +0000 2025
>Originator:     Taylor R Campbell
>Release:        
>Organization:
The XenBSD.local
>Environment:
>Description:
Various content in GENERIC can't be moved to -- or drafted in -- GENERIC.local because it breaks XEN3_DOM0 and XEN3_DOMU kernels.  For example, there's no virtio in the Xen kernels, so you can't put

vio9p* at virtio?

in GENERIC.local or it will break the Xen kernel builds.

This is silly.

https://mail-index.netbsd.org/tech-kern/2024/08/11/msg029672.html
>How-To-Repeat:
put `vio9p* at virtio?' in GENERIC.local
>Fix:
Stop including GENERIC.local in XEN3_DOM0 and XEN3_DOMU kernels.  Start including XEN3_DOM0.local and XEN3_DOMU.local, respectively, instead.  (XEN3_DOMU.local is already used, but XEN3_DOM0.local is not.)

Yes, this may break some local custom kernel configurations.  I don't think NetBSD has, or has ever had, any compatibility guarantees for custom kernel configurations, so I don't think this objection holds water (and nobody who raised that objection demonstrated any breakage that would actually happen, when requested).

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-xen-maintainer->bad
Responsible-Changed-By: bad@NetBSD.org
Responsible-Changed-When: Thu, 22 May 2025 08:58:23 +0000
Responsible-Changed-Why:
take


From: "Christoph Badura" <bad@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59438 CVS commit: src/sys/arch
Date: Thu, 22 May 2025 09:37:40 +0000

 Module Name:	src
 Committed By:	bad
 Date:		Thu May 22 09:37:40 UTC 2025

 Modified Files:
 	src/sys/arch/amd64/conf: XEN3_DOM0 XEN3_DOMU
 	src/sys/arch/i386/conf: XEN3PAE_DOM0 XEN3PAE_DOMU

 Log Message:
 make XEN3 configs include XEN3.local instead of GENERIC.local

 The XEN device tree is not compatible with the non-XEN device tree.

 This means that one can't enable in GENERIC.local many devices that are
 commented out in GENERIC. E.g,

     vio9p*	at virtio?
     i915drm* 	at drm?
     qat* 	at pci? dev ? function ?
     audio* 	at audiobus?

 Switch to including XEN3.local instead of GENERIC.local to have a common
 file for local XEN3 specific configuration.

 See https://mail-index.netbsd.org/tech-kern/2024/08/11/msg029672.html for
 the discussion.

 Note that GENERIC.local was added to most arches only in February 2023:
 https://mail-index.netbsd.org/source-changes/2023/02/12/msg143277.html

 Addresses: PR port-xen/59438: GENERIC content can't be in GENERIC.local because
 of XEN3_DOM* kernels

 Should probably be pulled up to -10 and -9.


 To generate a diff of this commit:
 cvs rdiff -u -r1.203 -r1.204 src/sys/arch/amd64/conf/XEN3_DOM0
 cvs rdiff -u -r1.105 -r1.106 src/sys/arch/amd64/conf/XEN3_DOMU
 cvs rdiff -u -r1.43 -r1.44 src/sys/arch/i386/conf/XEN3PAE_DOM0
 cvs rdiff -u -r1.24 -r1.25 src/sys/arch/i386/conf/XEN3PAE_DOMU

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Christoph Badura" <bad@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59438 CVS commit: src/sys/arch/amd64/conf
Date: Thu, 22 May 2025 09:53:26 +0000

 Module Name:	src
 Committed By:	bad
 Date:		Thu May 22 09:53:26 UTC 2025

 Modified Files:
 	src/sys/arch/amd64/conf: XEN3_DOM0

 Log Message:
 actually include "amd64/conf/XEN3_DOM0.local as intended

 Typoed in previous commit.

 PR port-xen/59438: GENERIC content can't be in GENERIC.local because of XEN3_DOM* kernels


 To generate a diff of this commit:
 cvs rdiff -u -r1.204 -r1.205 src/sys/arch/amd64/conf/XEN3_DOM0

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->needs-pullups
State-Changed-By: bad@NetBSD.org
State-Changed-When: Thu, 22 May 2025 11:18:49 +0000
State-Changed-Why:
Probably worth pulling up to -10 and perhaps -9.
I currently don't have the resources to test, though.


>Unformatted:

Home	PR Database Search