NetBSD Problem Report #59619

From diogo@mini.fritz.box  Sat Aug 30 13:10:29 2025
Return-Path: <diogo@mini.fritz.box>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 12E2A1A923E
	for <gnats-bugs@gnats.netbsd.org>; Sat, 30 Aug 2025 13:10:29 +0000 (UTC)
Message-Id: <20250830130355.4899C1B1188C@mini.fritz.box>
Date: Sat, 30 Aug 2025 15:03:54 +0200 (CEST)
From: db7@mini.fritz.box
Reply-To:
To: gnats-bugs@gnats.netbsd.org
Cc: db7@sdf.org 
Subject: textproc/lowdown: Compilation on Darwin 
X-Send-Pr-Version: 3.113.1
X-GNATS-Notify:

>Number:         59619
>Category:       pkg
>Synopsis:       Failing compilation of lowdown 2.0.2 on Darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 30 13:15:00 +0000 2025
>Closed-Date:    Wed Nov 19 14:45:28 +0000 2025
>Last-Modified:  Wed Nov 19 15:55:03 +0000 2025
>Originator:     db7@mini.fritz.box
>Release:        Darwin 24.6.0
>Organization:
>Environment:
System: Darwin mini 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:34 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T8103 arm64


>Description:
	With latest version of pkgsrc, the package textproc/lowdown (v2.0.2) does not compile properly.
	The original Makefile sets the symbol visibility to hidden and that causes some compatibility
	functions to "disappear" when linking the final binary.
>How-To-Repeat:
>Fix:
	The following patch removes the visibility=hidden option from Makefile for OPSYS = Darwin:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/lowdown/Makefile,v
retrieving revision 1.34
diff -u -p -r1.34 Makefile
--- Makefile	6 Jun 2025 23:10:26 -0000	1.34
+++ Makefile	30 Aug 2025 13:01:40 -0000
@@ -4,6 +4,7 @@ DISTNAME=		lowdown-2.0.2
 CATEGORIES=		textproc
 MASTER_SITES=		${MASTER_SITE_GITHUB:=kristapsdz/}
 GITHUB_TAG=		refs/tags/VERSION_${PKGVERSION_NOREV:S/./_/g}
+PKGREVISION=		1

 MAINTAINER=		pkgsrc-users@NetBSD.org
 HOMEPAGE=		https://kristaps.bsd.lv/lowdown/
@@ -32,4 +33,13 @@ TEST_TARGET=		regress
 pre-configure:
 	${ECHO} HAVE_SANDBOX_INIT=0 >> ${WRKSRC}/configure.local

+.include "../../mk/bsd.prefs.mk"
+.if ${OPSYS} == "Darwin"
+SUBST_CLASSES+=		hidden
+SUBST_SED.hidden+=	-e '/^CFLAGS.*visibility=hidden.*/d'
+SUBST_FILES.hidden=	Makefile
+SUBST_STAGE.hidden=	pre-build
+SUBST_MESSAGE.hidden=	Removing hidden visibility of symbols
+.endif
+
 .include "../../mk/bsd.pkg.mk"

>Release-Note:

>Audit-Trail:

From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59619 CVS commit: pkgsrc/textproc/lowdown
Date: Wed, 19 Nov 2025 14:36:03 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Wed Nov 19 14:36:03 UTC 2025

 Modified Files:
 	pkgsrc/textproc/lowdown: Makefile
 	pkgsrc/textproc/lowdown/patches: patch-Makefile

 Log Message:
 lowdown: fix builds on platforms that require compat functions

 Addresses PR pkg/59614 from Piper McCorkle (Linux) and PR pkg/59619
 from db7@mini.fritz.box (macOS).


 To generate a diff of this commit:
 cvs rdiff -u -r1.36 -r1.37 pkgsrc/textproc/lowdown/Makefile
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/textproc/lowdown/patches/patch-Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Wed, 19 Nov 2025 14:45:28 +0000
State-Changed-Why:
This should be fixed now in pkgsrc -current. (We're already patching
the make file, and this fix is relevant for other OSes, too, so I've
applied it differently, but the end result is the same.) Thanks for
the PR! Sorry this took a bit of time to get to.

From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59619 CVS commit: pkgsrc/textproc/lowdown
Date: Wed, 19 Nov 2025 15:54:26 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Wed Nov 19 15:54:26 UTC 2025

 Modified Files:
 	pkgsrc/textproc/lowdown: Makefile distinfo
 	pkgsrc/textproc/lowdown/patches: patch-Makefile

 Log Message:
 lowdown: fix compat function linking differently

 As of 2.0.4, upstream actually added context to handle this linking
 while keeping other symbol visibility hidden as they want. However, it
 wasn't factored in to the "libtoolization" changes that were made for
 pkgsrc purposes. (PR pkg/59614, PR pkg/59619.)


 To generate a diff of this commit:
 cvs rdiff -u -r1.37 -r1.38 pkgsrc/textproc/lowdown/Makefile \
     pkgsrc/textproc/lowdown/distinfo
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/textproc/lowdown/patches/patch-Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search