NetBSD Problem Report #59630
From www@netbsd.org Tue Sep 2 23:17:26 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits)
client-signature RSA-PSS (2048 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 921921A923A
for <gnats-bugs@gnats.NetBSD.org>; Tue, 2 Sep 2025 23:17:26 +0000 (UTC)
Message-Id: <20250902231725.439071A923E@mollari.NetBSD.org>
Date: Tue, 2 Sep 2025 23:17:25 +0000 (UTC)
From: thorpej@me.com
Reply-To: thorpej@me.com
To: gnats-bugs@NetBSD.org
Subject: fdtbus_todr_attach() should be rationalized with todr_attach()
X-Send-Pr-Version: www-1.0
>Number: 59630
>Category: kern
>Synopsis: fdtbus_todr_attach() should be rationalized with todr_attach()
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: thorpej
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Sep 02 23:20:00 +0000 2025
>Closed-Date: Mon Sep 08 13:07:13 +0000 2025
>Last-Modified: Mon Sep 08 13:07:13 +0000 2025
>Originator: Jason Thorpe
>Release: NetBSD-current as of 20250902
>Organization:
CISCy Business
>Environment:
Generic problem.
>Description:
fdtbus_todr_attach() is a wrapper around todr_attach(), to ensure that the correct (i.e. as specified in the device tree) RTC device is attach as the system RTC. Unfortunately, the way this interface is currently structured, drivers that wish to participate need to explicitly choose one or the other function call to register as the system RTC.
This should be handled in a more rational way that doesn't require drivers to explicitly opt-in.
>How-To-Repeat:
Code inspection.
>Fix:
Not (yet) provided.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->thorpej
Responsible-Changed-By: thorpej@NetBSD.org
Responsible-Changed-When: Tue, 02 Sep 2025 23:22:43 +0000
Responsible-Changed-Why:
Take.
State-Changed-From-To: open->analyzed
State-Changed-By: thorpej@NetBSD.org
State-Changed-When: Tue, 02 Sep 2025 23:22:43 +0000
State-Changed-Why:
Have an idea now to fix.
State-Changed-From-To: analyzed->closed
State-Changed-By: thorpej@NetBSD.org
State-Changed-When: Mon, 08 Sep 2025 13:07:13 +0000
State-Changed-Why:
todr_attach() has been enhanced to do the necessary filtering, and
fdtbus_todr_attach() has been removed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.