NetBSD Problem Report #7141

Received: (qmail 19561 invoked from network); 12 Mar 1999 04:22:49 -0000
Message-Id: <m10LJSy-000g5iC@most.weird.com>
Date: Thu, 11 Mar 1999 23:22:32 -0500 (EST)
From: woods@mail.weird.com
Reply-To: woods@weird.com
To: gnats-bugs@gnats.netbsd.org
Subject: a port of freebsd's security/libident package
X-Send-Pr-Version: 3.95

>Number:         7141
>Category:       pkg
>Synopsis:       a port of freebsd's security/libident package
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 11 20:35:01 +0000 1999
>Closed-Date:    Fri Mar 12 16:30:11 +0000 1999
>Last-Modified:  Fri Mar 12 16:30:54 +0000 1999
>Originator:     Greg A. Woods
>Release:        pkgsrc-current
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:

System: NetBSD 1.3.2
System: NetBSD 1.3.3
System: NetBSD-current

>Description:

	NetBSD is missing a native libident and is also missing
	pkgsrc/security/libident.

>How-To-Repeat:

	build something needing libident, such as smail-3

>Fix:

	install the following files in pkgsrc/security/libident

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	Makefile
#	files
#	files/md5
#	patches
#	patches/patch-aa
#	patches/patch-ab
#	pkg
#	pkg/COMMENT
#	pkg/DESCR
#	pkg/PLIST
#
echo x - Makefile
sed 's/^X//' >Makefile << 'END-of-Makefile'
X# New ports collection makefile for:	libident
X# Version required:	0.21
X# Date created:		9 October 1995
X# Whom:			torstenb@FreeBSD.ORG
X# NetBSD port by:	woods@planix.com (Greg A. Woods)
X#
X# $NetBSD$
X# $FreeBSD: Makefile,v 1.6 1998/01/25 20:42:37 torstenb Exp $
X#
X
XDISTNAME=	libident-0.21
XCATEGORIES=	devel net security
XMASTER_SITES=	ftp://ftp.lysator.liu.se/pub/ident/libs/
X
XMAINTAINER=	packages@NetBSD.org
X
XALL_TARGET=	netbsd
XMAN3=		ident.3
X
X.include <../../mk/bsd.pkg.mk>
END-of-Makefile
echo c - files
mkdir -p files > /dev/null 2>&1
echo x - files/md5
sed 's/^X//' >files/md5 << 'END-of-files/md5'
XMD5 (libident-0.21.tar.gz) = 34d95b7f60bf02b9c36be6397479e58c
END-of-files/md5
echo c - patches
mkdir -p patches > /dev/null 2>&1
echo x - patches/patch-aa
sed 's/^X//' >patches/patch-aa << 'END-of-patches/patch-aa'
X*** Makefile.o	Sat Jan 24 17:11:37 1998
X--- Makefile	Sat Jan 24 17:12:49 1998
X***************
X*** 8,14 ****
X  RANLIB=ranlib
X  AR=ar cq
X  
X! INSTROOT=/usr/local
X  LIBDIR=$(INSTROOT)/lib
X  INCDIR=$(INSTROOT)/include
X  MANDIR=$(INSTROOT)/man/man3
X--- 8,14 ----
X  RANLIB=ranlib
X  AR=ar cq
X  
X! INSTROOT=${PREFIX}
X  LIBDIR=$(INSTROOT)/lib
X  INCDIR=$(INSTROOT)/include
X  MANDIR=$(INSTROOT)/man/man3
X***************
X*** 19,25 ****
X  # Add -DHAVE_ANSIHEADERS if your system have the ANSI C header files
X  # needed for our purposes (stdlib, string, unistd).
X  #
X! CFLAGS = -O
X  
X  LDLIBS =
X  LIBIDENT = libident.a
X--- 19,25 ----
X  # Add -DHAVE_ANSIHEADERS if your system have the ANSI C header files
X  # needed for our purposes (stdlib, string, unistd).
X  #
X! #CFLAGS = -O
X  
X  LDLIBS =
X  LIBIDENT = libident.a
X***************
X*** 33,38 ****
X--- 33,39 ----
X  	@echo aix
X  	@echo bsd
X  	@echo bsd2.11
X+ 	@echo netbsd
X  	@echo dynix
X  	@echo hpux
X  	@echo irix
X***************
X*** 126,131 ****
X--- 127,134 ----
X  bsd2.11:
X  	@$(MAKE) all CC="$(CC)" CFLAGS="-O -DSIGRETURNTYPE=int -DHAVE_ANSIHEADERS"
X  
X+ netbsd:
X+ 	@$(MAKE) all CC="$(CC)" CFLAGS="${CFLAGS} -Wall -DHAVE_ANSIHEADERS"
X  
X  #
X  #
END-of-patches/patch-aa
echo x - patches/patch-ab
sed 's/^X//' >patches/patch-ab << 'END-of-patches/patch-ab'
X*** ident.h.orig	Thu Nov 23 14:44:36 1995
X--- ident.h	Tue Jan 19 10:55:43 1999
X***************
X*** 13,22 ****
X  #endif
X  
X  /* Sigh */
X! #ifdef __STDC__
X! #  if __STDC__ == 1
X! #    define IS_STDC 1
X! #  endif
X  #endif
X  
X  #ifdef __P
X--- 13,20 ----
X  #endif
X  
X  /* Sigh */
X! #if (0 - __STDC__) <= -1
X! #  define IS_STDC 1
X  #endif
X  
X  #ifdef __P
X***************
X*** 96,129 ****
X  #  include <bstring.h>
X  #endif
X  #include <sys/types.h>
X  #include <netinet/in.h>
X- #include <sys/time.h>
X  
X  #if defined(VMS) && !defined(FD_SETSIZE)
X  #  define FD_SETSIZE 64
X  #endif
X  
X- /*
X-  * Sigh, GCC v2 complains when using undefined struct tags
X-  * in function prototypes...
X-  */
X- #if defined(__GNUC__) && !defined(INADDR_ANY)
X- #  define __STRUCT_IN_ADDR_P	void *
X- #else
X- #  define __STRUCT_IN_ADDR_P	struct in_addr *
X- #endif
X- 
X- #if defined(__GNUC__) && !defined(DST_NONE)
X- #  define __STRUCT_TIMEVAL_P	void *
X- #else
X- #  define __STRUCT_TIMEVAL_P	struct timeval *
X- #endif
X- 
X- #if defined(__sgi) && defined(_POSIX_SOURCE)
X- #  undef  __STRUCT_TIMEVAL_P
X- #  define __STRUCT_TIMEVAL_P	void *
X- #endif
X- 	
X  #ifndef IDBUFSIZE
X  #  define IDBUFSIZE 2048
X  #endif
X--- 94,115 ----
X  #  include <bstring.h>
X  #endif
X  #include <sys/types.h>
X+ #if TIME_WITH_SYS_TIME
X+ # include <sys/time.h>
X+ # include <time.h>
X+ #else
X+ # if HAVE_SYS_TIME_H
X+ #  include <sys/time.h>
X+ # else
X+ #  include <time.h>
X+ # endif
X+ #endif
X  #include <netinet/in.h>
X  
X  #if defined(VMS) && !defined(FD_SETSIZE)
X  #  define FD_SETSIZE 64
X  #endif
X  
X  #ifndef IDBUFSIZE
X  #  define IDBUFSIZE 2048
X  #endif
X***************
X*** 149,167 ****
X  /* Low-level calls and macros */
X  #define id_fileno(ID)	((ID)->fd)
X  
X! extern ident_t * id_open __P((__STRUCT_IN_ADDR_P laddr,
X! 			   __STRUCT_IN_ADDR_P faddr,
X! 			   __STRUCT_TIMEVAL_P timeout));
X    
X  extern int    id_close __P((ident_t *id));
X    
X  extern int    id_query __P((ident_t *id,
X  			    int lport,
X  			    int fport,
X! 			    __STRUCT_TIMEVAL_P timeout));
X    
X  extern int    id_parse __P((ident_t *id,
X! 			    __STRUCT_TIMEVAL_P timeout,
X  			    int *lport,
X  			    int *fport,
X  			    char **identifier,
X--- 135,153 ----
X  /* Low-level calls and macros */
X  #define id_fileno(ID)	((ID)->fd)
X  
X! extern ident_t * id_open __P((struct in_addr * laddr,
X! 			   struct in_addr * faddr,
X! 			   struct timeval * timeout));
X    
X  extern int    id_close __P((ident_t *id));
X    
X  extern int    id_query __P((ident_t *id,
X  			    int lport,
X  			    int fport,
X! 			    struct timeval * timeout));
X    
X  extern int    id_parse __P((ident_t *id,
X! 			    struct timeval * timeout,
X  			    int *lport,
X  			    int *fport,
X  			    char **identifier,
X***************
X*** 174,180 ****
X  
X  extern char  *ident_id __P((int fd, int timeout));
X  
X! extern IDENT *ident_query __P(( __STRUCT_IN_ADDR_P laddr, __STRUCT_IN_ADDR_P raddr, int lport, int rport, int timeout));
X  
X  extern void   ident_free __P((IDENT *id));
X  
X--- 160,166 ----
X  
X  extern char  *ident_id __P((int fd, int timeout));
X  
X! extern IDENT *ident_query __P(( struct in_addr * laddr, struct in_addr * raddr, int lport, int rport, int timeout));
X  
X  extern void   ident_free __P((IDENT *id));
X  
END-of-patches/patch-ab
echo c - pkg
mkdir -p pkg > /dev/null 2>&1
echo x - pkg/COMMENT
sed 's/^X//' >pkg/COMMENT << 'END-of-pkg/COMMENT'
XA small library to interface the ident protocol server (rfc1413).
END-of-pkg/COMMENT
echo x - pkg/DESCR
sed 's/^X//' >pkg/DESCR << 'END-of-pkg/DESCR'
XCOPYRIGHT ISSUES:
X
X	This version of 'libident' is hereby released into the
X	Public Domain. It may be distributed for a fee or without
X	a fee. We only ask you not to pretend you wrote it.
X
XIf you make any changes, please send sources or a diff of it to
Xus (pen@lysator.liu.se or pell@lysator.liu.se), so we can keep
X_one_ unified version of libident available...
X
XCOMMENTS:
X
XThis is the second stab at a small library to interface to the Ident
Xprotocol server. Maybe this will work correctly on some machines.. :-)
X 
XThe ident-tester.c file is a small daemon (to be started from Inetd)
Xthat does an ident lookup on you if you telnet into it. Can be used
Xto verify that your Ident server is working correctly.
X 
XI'm currently running this "ident-tester" on port 114 at lysator.liu.se
X(130.236.254.1) if you wish to test your server.
END-of-pkg/DESCR
echo x - pkg/PLIST
sed 's/^X//' >pkg/PLIST << 'END-of-pkg/PLIST'
X@comment $NetBSD$
Xinclude/ident.h
Xlib/libident.a
Xman/man3/ident.3.gz
END-of-pkg/PLIST
exit

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: tron 
State-Changed-When: Fri Mar 12 08:30:11 PST 1999 
State-Changed-Why:  
Package added, thanks. 

From: woods@most.weird.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org (NetBSD GNATS submissions and followups),
    gnats-admin@netbsd.org,
    netbsd-bugs@NetBSD.ORG (NetBSD Bugs and PR posting List) 
Cc: tron@netbsd.org
Subject: Re: pkg/7141: a port of freebsd's security/libident package
Date: Sun, 14 Mar 1999 14:50:07 -0500 (EST)

 [ On , March 12, 1999 at 04:35:01 (-0000), gnats-bugs@gnats.netbsd.org wrote: ]
 > Subject: Re: pkg/7141: a port of freebsd's security/libident package
 >

 I see that my patch-ab wasn't included.  I don't know if this was
 oversight, or intentional.  Although this patch may not be necessary for
 compiling libident itself, it is necessary for other packages that will
 use the installed <ident.h> (and it certainly does no harm to the
 ability to compile libident itself).

 Here it (pkgsrc/security/libident/patches/patch-ab) is again, all by
 itself:

 *** ident.h.orig	Thu Nov 23 14:44:36 1995
 --- ident.h	Tue Jan 19 10:55:43 1999
 ***************
 *** 13,22 ****
   #endif

   /* Sigh */
 ! #ifdef __STDC__
 ! #  if __STDC__ == 1
 ! #    define IS_STDC 1
 ! #  endif
   #endif

   #ifdef __P
 --- 13,20 ----
   #endif

   /* Sigh */
 ! #if (0 - __STDC__) <= -1
 ! #  define IS_STDC 1
   #endif

   #ifdef __P
 ***************
 *** 96,129 ****
   #  include <bstring.h>
   #endif
   #include <sys/types.h>
   #include <netinet/in.h>
 - #include <sys/time.h>

   #if defined(VMS) && !defined(FD_SETSIZE)
   #  define FD_SETSIZE 64
   #endif

 - /*
 -  * Sigh, GCC v2 complains when using undefined struct tags
 -  * in function prototypes...
 -  */
 - #if defined(__GNUC__) && !defined(INADDR_ANY)
 - #  define __STRUCT_IN_ADDR_P	void *
 - #else
 - #  define __STRUCT_IN_ADDR_P	struct in_addr *
 - #endif
 - 
 - #if defined(__GNUC__) && !defined(DST_NONE)
 - #  define __STRUCT_TIMEVAL_P	void *
 - #else
 - #  define __STRUCT_TIMEVAL_P	struct timeval *
 - #endif
 - 
 - #if defined(__sgi) && defined(_POSIX_SOURCE)
 - #  undef  __STRUCT_TIMEVAL_P
 - #  define __STRUCT_TIMEVAL_P	void *
 - #endif
 - 	
   #ifndef IDBUFSIZE
   #  define IDBUFSIZE 2048
   #endif
 --- 94,115 ----
   #  include <bstring.h>
   #endif
   #include <sys/types.h>
 + #if TIME_WITH_SYS_TIME
 + # include <sys/time.h>
 + # include <time.h>
 + #else
 + # if HAVE_SYS_TIME_H
 + #  include <sys/time.h>
 + # else
 + #  include <time.h>
 + # endif
 + #endif
   #include <netinet/in.h>

   #if defined(VMS) && !defined(FD_SETSIZE)
   #  define FD_SETSIZE 64
   #endif

   #ifndef IDBUFSIZE
   #  define IDBUFSIZE 2048
   #endif
 ***************
 *** 149,167 ****
   /* Low-level calls and macros */
   #define id_fileno(ID)	((ID)->fd)

 ! extern ident_t * id_open __P((__STRUCT_IN_ADDR_P laddr,
 ! 			   __STRUCT_IN_ADDR_P faddr,
 ! 			   __STRUCT_TIMEVAL_P timeout));

   extern int    id_close __P((ident_t *id));

   extern int    id_query __P((ident_t *id,
   			    int lport,
   			    int fport,
 ! 			    __STRUCT_TIMEVAL_P timeout));

   extern int    id_parse __P((ident_t *id,
 ! 			    __STRUCT_TIMEVAL_P timeout,
   			    int *lport,
   			    int *fport,
   			    char **identifier,
 --- 135,153 ----
   /* Low-level calls and macros */
   #define id_fileno(ID)	((ID)->fd)

 ! extern ident_t * id_open __P((struct in_addr * laddr,
 ! 			   struct in_addr * faddr,
 ! 			   struct timeval * timeout));

   extern int    id_close __P((ident_t *id));

   extern int    id_query __P((ident_t *id,
   			    int lport,
   			    int fport,
 ! 			    struct timeval * timeout));

   extern int    id_parse __P((ident_t *id,
 ! 			    struct timeval * timeout,
   			    int *lport,
   			    int *fport,
   			    char **identifier,
 ***************
 *** 174,180 ****

   extern char  *ident_id __P((int fd, int timeout));

 ! extern IDENT *ident_query __P(( __STRUCT_IN_ADDR_P laddr, __STRUCT_IN_ADDR_P raddr, int lport, int rport, int timeout));

   extern void   ident_free __P((IDENT *id));

 --- 160,166 ----

   extern char  *ident_id __P((int fd, int timeout));

 ! extern IDENT *ident_query __P(( struct in_addr * laddr, struct in_addr * raddr, int lport, int rport, int timeout));

   extern void   ident_free __P((IDENT *id));



 -- 
 							Greg A. Woods

 +1 416 218-0098      VE3TCP      <gwoods@acm.org>      <robohack!woods>
 Planix, Inc. <woods@planix.com>; Secrets of the Weird <woods@weird.com>

From: woods@most.weird.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org (NetBSD GNATS submissions and followups) 
Cc: gnats-admin@netbsd.org,
    netbsd-bugs@NetBSD.ORG (NetBSD Bugs and PR posting List) ,
    tron@netbsd.org
Subject: Re: pkg/7141: a port of freebsd's security/libident package
Date: Sun, 14 Mar 1999 15:07:14 -0500 (EST)

 [ On Sunday, March 14, 1999 at 14:50:07 (-0500), Greg A. Woods wrote: ]
 > Subject: Re: pkg/7141: a port of freebsd's security/libident package
 >
 > [ On , March 12, 1999 at 04:35:01 (-0000), gnats-bugs@gnats.netbsd.org wrote: ]
 > > Subject: Re: pkg/7141: a port of freebsd's security/libident package
 > >
 > 
 > I see that my patch-ab wasn't included.  I don't know if this was
 > oversight, or intentional.  Although this patch may not be necessary for
 > compiling libident itself, it is necessary for other packages that will
 > use the installed <ident.h> (and it certainly does no harm to the
 > ability to compile libident itself).

 Never mind the previous -- I see now that the committed libident package
 was for 0.22, and now all these patches are necessary (or maybe they
 always were and I'd somehow screwed up my local copy of the distfile):

 # This is a shell archive.  Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file".  Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 #	patches/patch-ab
 #	patches/patch-ac
 #	patches/patch-ad
 #	patches/patch-ae
 #
 echo x - patches/patch-ab
 sed 's/^X//' >patches/patch-ab << 'END-of-patches/patch-ab'
 X*** ident.h-ORIG	Thu Nov 23 17:44:36 1995
 X--- ident.h	Sun Mar 14 14:56:33 1999
 X***************
 X*** 8,30 ****
 X  #ifndef __IDENT_H__
 X  #define __IDENT_H__
 X  
 X  #ifdef	__cplusplus
 X  extern "C" {
 X  #endif
 X  
 X  /* Sigh */
 X! #ifdef __STDC__
 X! #  if __STDC__ == 1
 X! #    define IS_STDC 1
 X! #  endif
 X! #endif
 X! 
 X! #ifdef __P
 X! #  undef __P
 X! #endif
 X!     
 X! #ifdef IS_STDC
 X! #  define __P(AL)	                  AL
 X  
 X  #ifdef IN_LIBIDENT_SRC
 X      
 X--- 8,21 ----
 X  #ifndef __IDENT_H__
 X  #define __IDENT_H__
 X  
 X+ #include <sys/cdefs.h>
 X+ 
 X  #ifdef	__cplusplus
 X  extern "C" {
 X  #endif
 X  
 X  /* Sigh */
 X! #if (0 - __STDC__) <= -1
 X  
 X  #ifdef IN_LIBIDENT_SRC
 X      
 X***************
 X*** 49,56 ****
 X      
 X  #else
 X  
 X- #  define __P(AL)	                  ()
 X- 
 X  #ifdef IN_LIBIDENT_SRC
 X      
 X  #  define __P1(t1,a1)                     (a1) \
 X--- 40,45 ----
 X***************
 X*** 85,94 ****
 X  #endif
 X  #endif
 X  
 X- #ifdef IS_STDC
 X- #  undef IS_STDC
 X- #endif
 X- 
 X  #ifdef _AIX
 X  #  include <sys/select.h>
 X  #endif
 X--- 74,79 ----
 X***************
 X*** 96,129 ****
 X  #  include <bstring.h>
 X  #endif
 X  #include <sys/types.h>
 X  #include <netinet/in.h>
 X- #include <sys/time.h>
 X  
 X  #if defined(VMS) && !defined(FD_SETSIZE)
 X  #  define FD_SETSIZE 64
 X  #endif
 X  
 X- /*
 X-  * Sigh, GCC v2 complains when using undefined struct tags
 X-  * in function prototypes...
 X-  */
 X- #if defined(__GNUC__) && !defined(INADDR_ANY)
 X- #  define __STRUCT_IN_ADDR_P	void *
 X- #else
 X- #  define __STRUCT_IN_ADDR_P	struct in_addr *
 X- #endif
 X- 
 X- #if defined(__GNUC__) && !defined(DST_NONE)
 X- #  define __STRUCT_TIMEVAL_P	void *
 X- #else
 X- #  define __STRUCT_TIMEVAL_P	struct timeval *
 X- #endif
 X- 
 X- #if defined(__sgi) && defined(_POSIX_SOURCE)
 X- #  undef  __STRUCT_TIMEVAL_P
 X- #  define __STRUCT_TIMEVAL_P	void *
 X- #endif
 X- 	
 X  #ifndef IDBUFSIZE
 X  #  define IDBUFSIZE 2048
 X  #endif
 X--- 81,102 ----
 X  #  include <bstring.h>
 X  #endif
 X  #include <sys/types.h>
 X+ #if TIME_WITH_SYS_TIME
 X+ # include <sys/time.h>
 X+ # include <time.h>
 X+ #else
 X+ # if HAVE_SYS_TIME_H
 X+ #  include <sys/time.h>
 X+ # else
 X+ #  include <time.h>
 X+ # endif
 X+ #endif
 X  #include <netinet/in.h>
 X  
 X  #if defined(VMS) && !defined(FD_SETSIZE)
 X  #  define FD_SETSIZE 64
 X  #endif
 X  
 X  #ifndef IDBUFSIZE
 X  #  define IDBUFSIZE 2048
 X  #endif
 X***************
 X*** 149,167 ****
 X  /* Low-level calls and macros */
 X  #define id_fileno(ID)	((ID)->fd)
 X  
 X! extern ident_t * id_open __P((__STRUCT_IN_ADDR_P laddr,
 X! 			   __STRUCT_IN_ADDR_P faddr,
 X! 			   __STRUCT_TIMEVAL_P timeout));
 X    
 X  extern int    id_close __P((ident_t *id));
 X    
 X  extern int    id_query __P((ident_t *id,
 X  			    int lport,
 X  			    int fport,
 X! 			    __STRUCT_TIMEVAL_P timeout));
 X    
 X  extern int    id_parse __P((ident_t *id,
 X! 			    __STRUCT_TIMEVAL_P timeout,
 X  			    int *lport,
 X  			    int *fport,
 X  			    char **identifier,
 X--- 122,140 ----
 X  /* Low-level calls and macros */
 X  #define id_fileno(ID)	((ID)->fd)
 X  
 X! extern ident_t * id_open __P((struct in_addr * laddr,
 X! 			   struct in_addr * faddr,
 X! 			   struct timeval * timeout));
 X    
 X  extern int    id_close __P((ident_t *id));
 X    
 X  extern int    id_query __P((ident_t *id,
 X  			    int lport,
 X  			    int fport,
 X! 			    struct timeval * timeout));
 X    
 X  extern int    id_parse __P((ident_t *id,
 X! 			    struct timeval * timeout,
 X  			    int *lport,
 X  			    int *fport,
 X  			    char **identifier,
 X***************
 X*** 174,180 ****
 X  
 X  extern char  *ident_id __P((int fd, int timeout));
 X  
 X! extern IDENT *ident_query __P(( __STRUCT_IN_ADDR_P laddr, __STRUCT_IN_ADDR_P raddr, int lport, int rport, int timeout));
 X  
 X  extern void   ident_free __P((IDENT *id));
 X  
 X--- 147,153 ----
 X  
 X  extern char  *ident_id __P((int fd, int timeout));
 X  
 X! extern IDENT *ident_query __P(( struct in_addr * laddr, struct in_addr * raddr, int lport, int rport, int timeout));
 X  
 X  extern void   ident_free __P((IDENT *id));
 X  
 END-of-patches/patch-ab
 echo x - patches/patch-ac
 sed 's/^X//' >patches/patch-ac << 'END-of-patches/patch-ac'
 X*** id_open.c-ORIG	Wed Nov  4 06:19:13 1998
 X--- id_open.c	Sun Mar 14 14:59:36 1999
 X***************
 X*** 38,52 ****
 X  #endif
 X  
 X  
 X- /*
 X  ident_t *id_open __P3(struct in_addr *, laddr,
 X  		      struct in_addr *, faddr,
 X  		      struct timeval *, timeout)
 X- */
 X- 
 X- ident_t *id_open __P((	__STRUCT_IN_ADDR_P laddr,
 X- 			__STRUCT_IN_ADDR_P faddr,
 X- 			__STRUCT_TIMEVAL_P timeout))
 X  {
 X      ident_t *id;
 X      int res, tmperrno;
 X--- 38,46 ----
 END-of-patches/patch-ac
 echo x - patches/patch-ad
 sed 's/^X//' >patches/patch-ad << 'END-of-patches/patch-ad'
 X*** id_query.c-ORIG	Wed Nov  4 06:19:13 1998
 X--- id_query.c	Sun Mar 14 15:00:56 1999
 X***************
 X*** 36,52 ****
 X  #include "ident.h"
 X  
 X  
 X- /*
 X  int id_query __P4(ident_t *, id,
 X  		  int, lport,
 X  		  int, fport,
 X  		  struct timeval *, timeout)
 X- */
 X- 
 X- int    id_query __P((	ident_t *id,                 
 X- 			int lport,                   
 X- 			int fport,                   
 X- 			__STRUCT_TIMEVAL_P timeout))
 X  {
 X  #ifdef SIGRETURNTYPE
 X      SIGRETURNTYPE (*old_sig)();
 X--- 36,45 ----
 END-of-patches/patch-ad
 echo x - patches/patch-ae
 sed 's/^X//' >patches/patch-ae << 'END-of-patches/patch-ae'
 X*** id_parse.c-ORIG	Wed Nov  4 06:19:13 1998
 X--- id_parse.c	Sun Mar 14 15:02:14 1999
 X***************
 X*** 38,44 ****
 X  #include "ident.h"
 X  
 X  
 X- /*
 X  int id_parse __P7(ident_t *, id,
 X  		  struct timeval *, timeout,
 X  		  int *, lport,
 X--- 38,43 ----
 X***************
 X*** 46,60 ****
 X  		  char **, identifier,
 X  		  char **, opsys,
 X  		  char **, charset)
 X- */
 X- 
 X- int id_parse __P((  ident_t *id,               
 X-                     __STRUCT_TIMEVAL_P timeout,
 X-                     int *lport,                
 X-                     int *fport,                
 X-                     char **identifier,         
 X-                     char **opsys,              
 X-                     char **charset))           
 X  {
 X      char c, *cp, *tmp_charset;
 X      fd_set rs;
 X--- 45,50 ----
 END-of-patches/patch-ae
 exit



 -- 
 							Greg A. Woods

 +1 416 218-0098      VE3TCP      <gwoods@acm.org>      <robohack!woods>
 Planix, Inc. <woods@planix.com>; Secrets of the Weird <woods@weird.com>

From: Matthias Scheler <tron@zhadum.de>
To: NetBSD GNATS submissions and followups <gnats-bugs@gnats.netbsd.org>
Cc:  Subject: Re: pkg/7141: a port of freebsd's security/libident package
Date: Sun, 14 Mar 1999 21:16:42 +0100

 On Sun, Mar 14, 1999 at 02:50:07PM -0500, Greg A. Woods wrote:
 > I see that my patch-ab wasn't included.

 Correct.

 > I don't know if this was oversight, or intentional.

 It was intentional because it breaked building the library.

 > ... it is necessary for other packages that will use the installed
 > <ident.h>

 Did you actually try that with version 0.22?

 > ... (and it certainly does no harm to the ability to compile libident
 > itself).

 See above.

 	Regards

 -- 
 Matthias Scheler                                http://home.owl.de/~tron/

From: Matthias Scheler <tron@zhadum.de>
To: "Greg A. Woods" <woods@most.weird.com>
Cc: NetBSD GNATS submissions and followups <gnats-bugs@gnats.netbsd.org>
Subject: Re: pkg/7141: a port of freebsd's security/libident package
Date: Sun, 14 Mar 1999 21:36:31 +0100

 On Sun, Mar 14, 1999 at 03:07:14PM -0500, Greg A. Woods wrote:
 > Never mind the previous -- I see now that the committed libident package
 > was for 0.22, and now all these patches are necessary ...

 No, they are not. I just wrote a little test program:

 #include <stdio.h>
 #include <ident.h>

 int main(int argc,char **argv)

 {
  (void)printf("%s\n", ident_id(4,1));
  return 0;
 }

 It builds and runs without any problems under 1.3.3 and -current.

 -- 
 Matthias Scheler                                http://home.owl.de/~tron/

From: woods@most.weird.com (Greg A. Woods)
To: Matthias Scheler <tron@zhadum.de>
Cc: NetBSD GNATS submissions and followups <gnats-bugs@gnats.netbsd.org>,
    netbsd-bugs@NetBSD.ORG (NetBSD Bugs and PR posting List) 
Subject: Re: pkg/7141: a port of freebsd's security/libident package
Date: Sun, 14 Mar 1999 17:43:56 -0500 (EST)

 [ On Sunday, March 14, 1999 at 21:36:31 (+0100), Matthias Scheler wrote: ]
 > Subject: Re: pkg/7141: a port of freebsd's security/libident package
 >
 > It builds and runs without any problems under 1.3.3 and -current.

 You're right!  I withdraw my patches!  ;-)

 There must be new fixes in 0.22 that eliminate the warnings I used to
 get from gcc.  Actually it appears the fixes were in 0.21 but because
 I'd automatically merged my changes from 0.17 and 0.18 I hadn't realized
 that some of them were not entirely necessary any more....

 -- 
 							Greg A. Woods

 +1 416 218-0098      VE3TCP      <gwoods@acm.org>      <robohack!woods>
 Planix, Inc. <woods@planix.com>; Secrets of the Weird <woods@weird.com>
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.