NetBSD Problem Report #760
From gnats Sat Jan 28 12:52:45 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with ESMTP id MAA16636 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sat, 28 Jan 1995 12:52:44 -0800
Message-Id: <199501282052.VAA07153@euterpe.owl.de>
Date: Sat, 28 Jan 1995 21:52:22 +0100
From: martin@euterpe.owl.de
Reply-To: martin@euterpe.owl.de
To: gnats-bugs@NetBSD.ORG
Subject: Make should ignore tab-only lines
X-Send-Pr-Version: 3.2
>Number: 760
>Category: bin
>Synopsis: Make can't parse files like "\t\n"
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: bin-bug-people
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat Jan 28 13:05:02 +0000 1995
>Closed-Date: Wed Feb 08 08:06:18 +0000 1995
>Last-Modified:
>Originator: Martin Husemann
>Release: -current as of Jan 27 1995
>Organization:
private
>Environment:
System: NetBSD euterpe.owl.de 1.0A NetBSD 1.0A (EUTERPE) #2: Sat Jan 28 12:35:00 MET 1995 root@euterpe.owl.de:/usr/src/sys/arch/i386/compile/EUTERPE i386
>Description:
A lot of people complained about the Makefiles with lines conaining
a single tab. One fix is to remove this tab - but I would prefer
'make' to silently skip those lines (as other 'make's do); there
are several sources out there which contain such "broken"
makefiles. I don't know what any `standard' says about this,
but I think invisible lines shouldn't break anything.
>How-To-Repeat:
printf '\t\n' >/tmp/Makefile; make -f /tmp/Makefile
>Fix:
--- src/usr.bin/make/parse.c.old Sat Jan 28 21:21:17 1995
+++ src/usr.bin/make/parse.c Sat Jan 28 21:35:33 1995
@@ -2404,8 +2404,9 @@
goto nextLine;
}
}
- if (*line == '#') {
- /* If we're this far, the line must be a comment. */
+ if (*line == '#' || *line == '\0') {
+ /* If we're this far, the line must be a comment.
+ (Empty lines are ignored as well) */
goto nextLine;
}
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: jtc
State-Changed-When: Wed Feb 8 08:06:18 1995
State-Changed-Why:
Make bug that complained about tabs has been fixed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.