NetBSD Problem Report #7670

Received: (qmail 2913 invoked from network); 30 May 1999 15:35:42 -0000
Message-Id: <199905301535.SAA15531@kolster.fi>
Date: Sun, 30 May 1999 18:35:04 +0300 (EEST)
From: Antti Kantee <pooka@iki.fi>
To: gnats-bugs@gnats.netbsd.org
Subject: mtools doesn't build
X-Send-Pr-Version: 3.95

>Number:         7670
>Category:       pkg
>Synopsis:       mtools doesn't build
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 30 08:50:01 +0000 1999
>Closed-Date:    Mon May 31 22:22:40 +0000 1999
>Last-Modified:  Mon May 31 22:23:44 +0000 1999
>Originator:     Antti Kantee
>Release:        NetBSD 1.4C
>Organization:
>Environment:
NetBSD/i386 1.4C

>Description:
	Trying to build mtools results in the build bombing out at floppyd.cpp

>How-To-Repeat:
	cd pkgsrc/sysutils/mtools && make

>Fix:
	The following patch makes it compile, also hopefully DTRT WRT running.


$NetBSD: patch-ac
--- floppyd.cpp.orig	Sun May 30 18:05:46 1999
+++ floppyd.cpp	Sun May 30 18:25:37 1999
@@ -527,12 +527,12 @@
 {
 	int					new_sock;
 	struct sockaddr_in	addr;
-	int					len;
+	socklen_t					len;

 	/*
 	 * Ignore dead servers so no zombies should be left hanging.
 	 */
-	signal(SIGCLD, SIG_IGN);
+	signal(SIGCHLD, SIG_IGN);

 	for (;;)
 	{
@@ -615,6 +615,7 @@
 	short			bind_port = FLOPPYD_DEFAULT_PORT;
 	uid_t			run_uid = 65535;
 	gid_t			run_gid = 65535;
+	pid_t			run_pid;
 	int			sock;
 	int			port_is_supplied = 0;
 	int			no_local = 0;
@@ -665,7 +666,7 @@
 	}
 	if(!run_as_server) {
 		struct sockaddr_in	addr;
-		int len = sizeof(addr);
+		socklen_t len = sizeof(addr);

 		/* try to find out port that we are connected to */
 		if(getsockname(0, (sockaddr*) &addr, &len) >= 0 && 
@@ -836,8 +837,8 @@
 			/*
 			 * Start a new session and group.
 			 */
-			setsid();
-			setpgrp();
+			run_pid = setsid();
+			setpgrp(0, run_pid);

 		  	close(2);
 			open("/dev/null", O_WRONLY);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: tron 
State-Changed-When: Sun May 30 17:08:20 PDT 1999 
State-Changed-Why:  
Our package neither builds nor installs "floppyd". So this patch is 
unnecessary unless you provide patches to enable "floppyd". 
State-Changed-From-To: feedback->closed 
State-Changed-By: tron 
State-Changed-When: Mon May 31 15:22:40 PDT 1999 
State-Changed-Why:  
Configuration fixed and patch applied, thanks. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.