NetBSD Problem Report #8038

Received: (qmail 4065 invoked from network); 20 Jul 1999 17:04:30 -0000
Message-Id: <E116ZDj-0000CL-00@decomino.localnet>
Date: Tue, 20 Jul 1999 12:42:07 +0000
From: Joseph Myers <jsm28@cam.ac.uk>
Reply-To: Joseph Myers <jsm28@cam.ac.uk>
To: gnats-bugs@gnats.netbsd.org
Cc: Joseph Myers <jsm28@cam.ac.uk>
Subject: [PATCH] Atc bug fix
X-Send-Pr-Version: 3.95

>Number:         8038
>Category:       bin
>Synopsis:       [PATCH] Atc bug fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 20 10:05:00 +0000 1999
>Closed-Date:    Wed Jul 21 13:11:43 +0000 1999
>Last-Modified:  Wed Jul 21 13:13:11 +0000 1999
>Originator:     Joseph S. Myers
>Release:        NetBSD-current of 1999-07-18
>Organization:
Trinity College, University of Cambridge, UK
>Environment:
[
System: Linux decomino 2.2.10 #1 Mon Jun 14 07:48:53 UTC 1999 i686 unknown
Architecture: i686
]
>Description:

When atc(6) parses its game definition files, the check for `width'
being defined more than once incorrectly checks for `height' having
been previously defined instead.

>How-To-Repeat:

Swap the definitions of `width' and `height' in any of the game
definitions included with atc (all of which define `width' first, so
this bug does not show up with them unmodified).

>Fix:

diff -ruN atc/grammar.y atc+/grammar.y
--- atc/grammar.y	Fri Oct 10 11:21:28 1997
+++ atc+/grammar.y	Tue Jul 20 12:37:15 1999
@@ -137,7 +137,7 @@
 wdef:
 	WidthOp '=' ConstOp ';'
 		{
-		if (sp->height != 0)
+		if (sp->width != 0)
 			return (yyerror("Redefinition of 'width'."));
 		else if ($3 < 3)
 			return (yyerror("'width' is too small."));
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: hubertf 
State-Changed-When: Wed Jul 21 06:11:43 PDT 1999 
State-Changed-Why:  

Fix applied, thanks! 


- Hubert 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.