NetBSD Problem Report #822

From gnats  Thu Feb 23 02:18:52 1995
Received: from uran.informatik.uni-bonn.de (uran.informatik.uni-bonn.de [131.220.8.49]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with ESMTP id CAA02239 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Thu, 23 Feb 1995 02:18:49 -0800
Message-Id: <199502231018.LAA04701@serpens.rhein.de>
Date: Thu, 23 Feb 1995 11:18:46 +0100
From: Michael van Elst <mlelstv@serpens.rhein.de>
Reply-To: mlelstv@serpens.rhein.de
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: 8bit Amiga console
X-Send-Pr-Version: 3.2

>Number:         822
>Category:       port-amiga
>Synopsis:       Amiga console is limited to 7bit
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 23 02:20:08 +0000 1995
>Closed-Date:    Thu Mar 02 04:38:59 +0000 1995
>Last-Modified:  
>Originator:     
>Release:        1.0
>Organization:
>Environment:
System: NetBSD serpens 1.0 NetBSD 1.0 (SERPENS) #30: Wed Feb 22 22:53:46 MET 1995 root@serpens:/usr2/src/sys/arch/amiga/compile/SERPENS amiga

>Description:
Amiga console is limited to 7bit characters because of 2 bugs in
sys/arch/amiga/dev/ite.c and sys/arch/amiga/dev/ite_cc.c.

In ite.c the VT-parser throws away all chars less than ' ' which
also catches chars above (char)128.

In ite_cc.c (and upper calling routines) and int is used for the
character code to be printed which is derived from a signed char.
This code is then compared against the code limits of the font
which are u_char. Casting to u_char makes the check and the use
as an index into the font table work.
Additionally I made it emit the last character in the font for
characters not in the font (usually a DEL symbol).

This still exists in the -current sources.

>How-To-Repeat:
Simply type an umlaut on a german keyboard. No char is output
although the character exists in the font.

>Fix:
*** ite.c.release	Thu Feb 23 11:09:22 1995
--- ite.c	Thu Feb 23 11:11:45 1995
***************
*** 2150,2156 ****
  		break;

  	default:
! 		if (c < ' ' || c == DEL)
  			break;
  		if (ip->imode)
  			ite_inchar(ip, 1);
--- 2150,2156 ----
  		break;

  	default:
! 		if ((c & 0x7f) < ' ' || c == DEL)
  			break;
  		if (ip->imode)
  			ite_inchar(ip, 1);
*** ite_cc.c.release	Thu Feb 23 11:11:09 1995
--- ite_cc.c	Thu Feb 23 11:11:51 1995
***************
*** 729,736 ****
  putc8(struct ite_softc *ip, int c, int dy, int dx, int mode)
  {
      register ipriv_t *cci = (ipriv_t *) ip->priv;
      if (c < ip->font_lo || c > ip->font_hi)
! 	return;

      put_func[mode](cci,
  		   cci->row_ptr[dy],
--- 729,738 ----
  putc8(struct ite_softc *ip, int c, int dy, int dx, int mode)
  {
      register ipriv_t *cci = (ipriv_t *) ip->priv;
+ 
+     c = (u_char)c;
      if (c < ip->font_lo || c > ip->font_hi)
! 	c = ip->font_hi;

      put_func[mode](cci,
  		   cci->row_ptr[dy],

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: chopps 
State-Changed-When: Wed Mar 1 20:38:59 PST 1995 
State-Changed-Why:  
fixed problem with 8 bit chars 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.