NetBSD Problem Report #8601

Received: (qmail 8890 invoked from network); 10 Oct 1999 15:34:51 -0000
Message-Id: <199910101534.AAA06315@life.biology.tohoku.ac.jp>
Date: Mon, 11 Oct 1999 00:34:38 +0900 (JST)
From: hashikaw@biology.tohoku.ac.jp
Reply-To: hashikaw@biology.tohoku.ac.jp
To: gnats-bugs@gnats.netbsd.org
Subject: ThinkPad 240 hangs when attaching eso* audio driver.
X-Send-Pr-Version: 3.95

>Number:         8601
>Category:       kern
>Synopsis:       ThinkPad 240 hangs when attaching eso* audio driver.
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    cgd
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 10 08:36:00 +0000 1999
>Closed-Date:    Sun Oct 17 21:16:10 +0000 1999
>Last-Modified:  Sun Oct 17 21:19:56 +0000 1999
>Originator:     Kouichi Hashikawa
>Release:        NetBSD 1.4K
>Organization:
>Environment:
	<machine, os, target, libraries (multiple lines)>
System: NetBSD himawari 1.4K NetBSD 1.4K (HIMAWARI) #0: Sun Oct 10 16:48:40 JST 1999 hashikaw@himawari:/usr/src/sys/arch/i386/compile/HIMAWARI i386


>Description:
	ThinkPad 240(2609-21J) has following device
	(This message is when disable 'eso* at pci? dev ? function ?'
	at kernel configuration):

	ESS Technology Inc SOLO-1 Audio Drive (audio multimedia, revision 0x02) at pci0 dev 11 function 0 not configured

	When I enable 'eso* at pci? dev ? function ?', my ThinkPad 240 hangs
	during boot (attaching eso0).

>How-To-Repeat:
	always, at machines which has 'ESS Solo-1 revision 0x02'.

>Fix:
	Please check following patch.
	'struct eso_rev2model' at eso.c(revision 1.8) has 2-items:

static const char * const eso_rev2model[] = {
	"ES1938",
	"ES1946"
};


	FYI: 
	1. applied following patch, my ThinkPad 240's ESS Solo-1 works
	   very well.
	2. I don't know the name of chip, 'ESS Solo-1 revision 0x02'.
	   IBM(Japan) don't describe the name at any manuals.


*** eso.c-1.8	Sun Oct 10 23:14:00 1999
--- eso.c	Sun Oct 10 23:18:19 1999
***************
*** 210,216 ****
  	sc->sc_revision = PCI_REVISION(pa->pa_class);

  	printf(": ESS Solo-1 PCI AudioDrive ");
! 	if (sc->sc_revision <=
  	    sizeof (eso_rev2model) / sizeof (eso_rev2model[0]))
  		printf("%s\n", eso_rev2model[sc->sc_revision]);
  	else
--- 210,216 ----
  	sc->sc_revision = PCI_REVISION(pa->pa_class);

  	printf(": ESS Solo-1 PCI AudioDrive ");
! 	if (sc->sc_revision <
  	    sizeof (eso_rev2model) / sizeof (eso_rev2model[0]))
  		printf("%s\n", eso_rev2model[sc->sc_revision]);
  	else
***************
*** 858,864 ****
  	strncpy(retp->name, "ESS Solo-1", sizeof (retp->name));
  	snprintf(retp->version, sizeof (retp->version), "0x%02x",
  	    sc->sc_revision);
! 	if (sc->sc_revision <=
  	    sizeof (eso_rev2model) / sizeof (eso_rev2model[0]))
  		strncpy(retp->config, eso_rev2model[sc->sc_revision],
  		    sizeof (retp->config));
--- 858,864 ----
  	strncpy(retp->name, "ESS Solo-1", sizeof (retp->name));
  	snprintf(retp->version, sizeof (retp->version), "0x%02x",
  	    sc->sc_revision);
! 	if (sc->sc_revision <
  	    sizeof (eso_rev2model) / sizeof (eso_rev2model[0]))
  		strncpy(retp->config, eso_rev2model[sc->sc_revision],
  		    sizeof (retp->config));

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->kleink 
Responsible-Changed-By: hwr 
Responsible-Changed-When: Sun Oct 10 08:45:25 PDT 1999 
Responsible-Changed-Why:  
Klaus wrote this driver. 
State-Changed-From-To: open->feedback 
State-Changed-By: cgd 
State-Changed-When: Sun Oct 10 11:51:31 PDT 1999 
State-Changed-Why:  
it was a trivial fix, and obviously correct, so i applied it. 
Please check the updated version to make sure it really does fix 
the problem for you (it should, since I just applied the patch, 
albeit by hand), then reply to this mail (being sure to cc 
gnats-bugs@netbsd.org to the PR will get a copy) indicating success. 


Responsible-Changed-From-To: kleink->cgd 
Responsible-Changed-By: cgd 
Responsible-Changed-When: Sun Oct 10 11:51:31 PDT 1999 
Responsible-Changed-Why:  
it's kinda silly to push around responsibility for trivial fixes. 

From: hashikaw@biology.tohoku.ac.jp (Kouichi Hashikawa)
To: cgd@netbsd.org
Cc: kleink@netbsd.org, gnats-bugs@netbsd.org, hashikaw@biology.tohoku.ac.jp
Subject: Re: kern/8601
Date: Sun, 17 Oct 1999 22:44:13 +0900 (JST)

 > Synopsis: ThinkPad 240 hangs when attaching eso* audio driver.
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: cgd
 > State-Changed-When: Sun Oct 10 11:51:31 PDT 1999
 > State-Changed-Why: 
 > it was a trivial fix, and obviously correct, so i applied it.
 > Please check the updated version to make sure it really does fix
 > the problem for you (it should, since I just applied the patch,
 > albeit by hand), then reply to this mail (being sure to cc
 > gnats-bugs@netbsd.org to the PR will get a copy) indicating success.
 > 
 > 
 > Responsible-Changed-From-To: kleink->cgd
 > Responsible-Changed-By: cgd
 > Responsible-Changed-When: Sun Oct 10 11:51:31 PDT 1999
 > Responsible-Changed-Why: 
 > it's kinda silly to push around responsibility for trivial fixes.
 > 
 I checked the updated version (eso.c, revision 1.9):
 	o attach ESS Solo-1 revision 0x02:	ok
 	o play a CD-quality sound data:		ok

 So, I think that PR#8601 is fixed. 

 Thank you, cgd and kleink!!

State-Changed-From-To: feedback->closed 
State-Changed-By: cgd 
State-Changed-When: Sun Oct 17 14:16:10 PDT 1999 
State-Changed-Why:  
submitter confirmed that the problem has been fixed. 

From: cgd@netbsd.org (Chris G. Demetriou)
To: hashikaw@biology.tohoku.ac.jp (Kouichi Hashikawa)
Cc: kleink@netbsd.org, gnats-bugs@netbsd.org
Subject: Re: kern/8601
Date: 17 Oct 1999 14:25:51 -0700

 hashikaw@biology.tohoku.ac.jp (Kouichi Hashikawa) writes:
 > So, I think that PR#8601 is fixed. 

 great.  i marked the PR closed.


 > Thank you, cgd and kleink!!

 Thank _you_ for finding and fixing a bug for us!  8-)



 chris
 -- 
 Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
 Disclaimer: Not speaking for NetBSD, just expressing my own opinion.

From: Klaus Klein <kleink@ira.uka.de>
To: hashikaw@biology.tohoku.ac.jp (Kouichi Hashikawa)
Cc: cgd@netbsd.org, gnats-bugs@netbsd.org, kleink@netbsd.org
Subject: Re: kern/8601
Date: 18 Oct 1999 13:04:12 +0200

 hashikaw@biology.tohoku.ac.jp (Kouichi Hashikawa) writes:


 > > Responsible-Changed-From-To: kleink->cgd
 > > Responsible-Changed-By: cgd
 > > Responsible-Changed-When: Sun Oct 10 11:51:31 PDT 1999
 > > Responsible-Changed-Why: 
 > > it's kinda silly to push around responsibility for trivial fixes.
 > > 
 > I checked the updated version (eso.c, revision 1.9):
 > 	o attach ESS Solo-1 revision 0x02:	ok
 > 	o play a CD-quality sound data:		ok
 > 
 > So, I think that PR#8601 is fixed. 
 > 
 > Thank you, cgd and kleink!!

 Actually, I didn't do anything about this bug other than introducing
 it in the first place :-), but I'd like to thank _you_ for using the
 driver and providing us with feedback!  I think it's OK now to
 consider a back-port of it to the 1.4 branch.


 -kjk
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.