NetBSD Problem Report #8635

Received: (qmail 21633 invoked by uid 1000); 17 Oct 1999 01:32:40 -0000
Message-Id: <87d7uehivc.fsf@redmail.netbsd.org>
Date: 16 Oct 1999 18:32:39 -0700
From: cgd@netbsd.org (Chris G. Demetriou)
To: joda@pdc.kth.se (Johan Danielsson)
Cc: gnats-bugs@gnats.netbsd.org, netbsd-bugs@netbsd.org
In-Reply-To: joda@pdc.kth.se's message of 15 Oct 1999 18:03:45 +0200
Subject: Re: there is no cardbus attachment for the com driver
References: <xofoge0sja6.fsf@blubb.pdc.kth.se>

>Number:         8635
>Category:       pending
>Synopsis:       Re: there is no cardbus attachment for the com driver
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 16 18:33:00 +0000 1999
>Closed-Date:    Sun Oct 31 07:49:42 +0000 1999
>Last-Modified:  Sun Oct 31 07:50:10 +0000 1999
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: cgd 
State-Changed-When: Sun Oct 31 00:49:42 PDT 1999 
State-Changed-Why:  
mis-filed reply to PR#8632. 
>Unformatted:
 joda@pdc.kth.se (Johan Danielsson) writes:
 > +    struct cardbus_attach_args *ca = aux;
 > +    if(PCI_CLASS(ca->ca_class) == PCI_CLASS_COMMUNICATIONS &&
 > +       PCI_SUBCLASS(ca->ca_class) == PCI_SUBCLASS_COMMUNICATIONS_SERIAL)
 > +	return 1;
 > +    return 0;

 This is not right.

 (1) it's not clear to me that all devices which report that
 class/subclass actually provide (only) a 16x50 interface at BAR 10.
 Inability to rely on this even for single-port devices is what drove
 me to create 'puc'.  If there is a PCI standard document which says
 that you can expect these values to mean 16x50 at BAR @ 0x10, i'd
 _love_ to see it.  Perhaps it's dependent on the programming interface
 field.

 (2) COMMUNICATIONS/MODEM (0x03) has several programming interfaces
 which are standardized to provide 16x50-compatible device via the BAR
 @ 0x10.  You should take them into account.

 Do the cardbus standards say anything relevant here, in a way that's
 more specific than PCI?


 > +    if(cardbus_mapreg_map(csc->ct, CARDBUS_BASE0_REG, 
 > +			  PCI_MAPREG_TYPE_IO, 
 > +			  0, &iot, &ioh, &adr, NULL) != 0)
 > +	panic("io alloc");

 Who's to say it'll be I/O?  At the very least, the PCI 2.2 spec
 specifically indicates (on page 261) that the 16x50-compatible
 COMMUNICATIONS/MODEM devices mapped via the BAR @ 0x10 may be in
 either memory OR I/O space.



 cgd
 -- 
 Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
 Disclaimer: Not speaking for NetBSD, just expressing my own opinion.

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.