NetBSD Problem Report #907

From gnats  Sat Mar 25 23:40:22 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.10/8.6.10) with ESMTP id XAA04485 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sat, 25 Mar 1995 23:40:21 -0800
Message-Id: <199503260743.CAA02043@freetocreate.cais.com>
Date: Sun, 26 Mar 1995 02:43:43 -0500
From: Rob.Leland@freetocreate.cais.com
Reply-To: root@freetocreate.cais.com
To: gnats-bugs@NetBSD.ORG
Subject: Adam Glass: gas read.c line 1017 still does not compile!~ 
X-Send-Pr-Version: 3.2

>Number:         907
>Category:       bin
>Synopsis:       gas read.c line 1017 also needs enclosing () to compile!
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 25 23:50:02 +0000 1995
>Closed-Date:    Sun Mar 26 08:11:15 +0000 1995
>Last-Modified:  
>Originator:     Rob Leland
>Release:        NetBSD-current 3/26/95 2:30 AM	<NetBSD-current source date>
>Organization:

>Environment:

System: NetBSD freetocreate.cais.com 1.0A NetBSD 1.0A (FREETOCREATE) #2: Sat Mar 25 14:05:42 EST 1995 root@freetocreate.cais.com:/usr/src/sys/arch/amiga/compile/FREETOCREATE amiga
Architecture: amiga

>Description:
Adam, The if statement still needs an enclosing ()
around the -entire- statement inorder to compile.

>How-To-Repeat:

>Fix:
Make present if statement which looks like if () && () {if block} 
make it look like if ( () && () ) {if block }
Sorry I didn't include a diff, but it will now compile.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: cgd 
State-Changed-When: Sun Mar 26 00:11:15 PST 1995 
State-Changed-Why:  
the present statement looks like: 
if (segment != SEG_ABSOLUTE && !SEG_NORMAL(segment) && 
segment != SEG_REGISTER) {  

as of yesterday, it looked like: 
if (segment != SEG_ABSOLUTE && !SEG_NORMAL(segment)) && 
segment != SEG_REGISTER) { 

deletion of the extra close-parenthesis, the logical fix to the problem 
reported by pr 905, fixes the problem in the most natural way.  (PR 905's 
solution to the problem was completely useless, and not a fix at all. 
PR 905's only use was that it pointed out the compilation problem.) 

In general: 
(1) problem reports submitted with gnats are not appropriate 
unless you're reasonably sure that the problem exists; the 
original pr, 905, was appropriate (though its fix was less 
than useful).  This one was not appropriate, because: 
(a) there was no way for the author to have observed 
the problem still existed (as the fixed sources haven't 
even been exported for FTP or sup yet), 
(b) it depends on the blind use of an ill-conceived fix 
which the author supplied, to have any relevance, 
(c) it assumes that when somebody says "we fixed the syntax 
error" that they were too clueless to actually fix 
the syntax error. 
(2) problem reports are not a substitute for e-mail; if someone 
says that they've fixed a bug, and you have concerns about 
their fix, it's not appropriate to file a PR to voice your 
concerns.  You should e-mail them. 
(3) do not assume that the patch applied to fix a bug will be 
in any way related to the patch supplied as a potential fix 
for the bug.  In many cases, there are different fixes that 
are in some way superior.  In the case of bug 905, the patch 
supplied was completely wrong-headed, and the author couldn't 
even have compiled the file he was attempting to fix, with it 
applied. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.