NetBSD Problem Report #9253

Received: (qmail 10990 invoked from network); 20 Jan 2000 02:59:17 -0000
Message-Id: <200001200259.PAA12634@city-art.mcs.vuw.ac.nz>
Date: Thu, 20 Jan 2000 15:59:10 +1300 (NZDT)
From: Mark Davies <mark@MCS.VUW.AC.NZ>
Reply-To: mark@MCS.VUW.AC.NZ
To: gnats-bugs@gnats.netbsd.org
Subject: current build fails due to out of date fsck_lfs
X-Send-Pr-Version: 3.95

>Number:         9253
>Category:       bin
>Synopsis:       current build fails due to out of date fsck_lfs
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    perseant
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 19 19:00:00 +0000 2000
>Closed-Date:    Fri Jan 21 21:50:29 +0000 2000
>Last-Modified:  Fri Jan 21 21:51:38 +0000 2000
>Originator:     Mark Davies
>Release:        19/1/2000
>Organization:
MCS, Victoria Uni. of Wellington, New Zealand.
>Environment:

System: NetBSD city-art.mcs.vuw.ac.nz 1.4P NetBSD 1.4P (MCS_WORKSTATION) #0: Thu Jan 13 02:02:39 PST 2000 root@fantail:/usr/src-current/sys/arch/i386/compile/MCS_WORKSTATION i386


>Description:
	With a source tree that is current as of last night, a make release
	fails when attempting to build sbin/fsck_lfs

	[...]
cc -O2 -g  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Werror   -I/usr/src-new/sbin/fsck_lfs/../fsck -nostdinc -idirafter /mnt/SAVE/base/usr/include -c /usr/src-new/sbin/fsck_lfs/setup.c
In file included from /usr/src-new/sbin/fsck_lfs/setup.c:57:
/usr/src-new/sbin/fsck_lfs/fsck.h:214: conflicting types for `lfs_ifind'
/mnt/SAVE/base/usr/include/ufs/lfs/lfs_extern.h:133: previous declaration of `lfs_ifind'
*** Error code 1

Stop.

Looks like this has not been updated to reflect the changes recently made for
lfs.

>How-To-Repeat:

>Fix:


cheers
mark
>Release-Note:
>Audit-Trail:

From: Konrad Schroder <perseant@hhhh.org>
To: Mark Davies <mark@MCS.VUW.AC.NZ>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: bin/9253: current build fails due to out of date fsck_lfs
Date: Thu, 20 Jan 2000 13:33:09 -0800 (PST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
   Send mail to mime@docserver.cac.washington.edu for more info.

 --0-1843749218-948403989=:8510
 Content-Type: TEXT/PLAIN; charset=US-ASCII

 On Thu, 20 Jan 2000, Mark Davies wrote:

 > >Description:
 > 	With a source tree that is current as of last night, a make release
 > 	fails when attempting to build sbin/fsck_lfs
 [...]
 > Looks like this has not been updated to reflect the changes recently made for
 > lfs.

 Quite right.  Try the enclosed patch (which I'm also committing now), and
 let me know if you have any other build problems....

 						Konrad Schroder
 						perseant@hhhh.org

 --0-1843749218-948403989=:8510
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="9253.diff"
 Content-Transfer-Encoding: BASE64
 Content-ID: <Pine.NEB.4.10.10001201333090.8510@hhhh.hitl.washington.edu>
 Content-Description: 
 Content-Disposition: attachment; filename="9253.diff"

 PyBub3BhcnQuZGlmZg0KPyBmc2NrX2xmcy5jYXQ4DQo/IGZzY2tfbGZzDQo/
 IDkyNTMuZGlmZg0KSW5kZXg6IGZzY2suaA0KPT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2Jhc2VzcmMvc2Jpbi9mc2NrX2xm
 cy9mc2NrLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjINCmRpZmYgLXUg
 LXIxLjIgZnNjay5oDQotLS0gZnNjay5oCTE5OTkvMDcvMDMgMTk6NTU6MDMJ
 MS4yDQorKysgZnNjay5oCTIwMDAvMDEvMjAgMjE6Mjk6MjQNCkBAIC0yMTEs
 OCArMjExLDcgQEANCiBzdHJ1Y3QgYnVmYXJlYSAqbGZzX2JnaW5vZGUgX19Q
 KChpbm9fdCkpOw0KIHN0cnVjdCBkaW5vZGUgKmdpbm9kZSBfX1AoKGlub190
 KSk7DQogc3RydWN0IGRpbm9kZSAqbGZzX2dpbm9kZSBfX1AoKGlub190KSk7
 DQotc3RydWN0IGRpbm9kZSAqbGZzX2lmaW5kIF9fUCgoc3RydWN0IGxmcyAq
 LCBpbm9fdCwgc3RydWN0IGRpbm9kZSAqKSk7DQotc3RydWN0IGRpbm9kZSAq
 bGZzX2lmaW5kIF9fUCgoc3RydWN0IGxmcyAqLCBpbm9fdCwgc3RydWN0IGRp
 bm9kZSAqKSk7DQorc3RydWN0IGRpbm9kZSAqbGZzX2RpZmluZCBfX1AoKHN0
 cnVjdCBsZnMgKiwgaW5vX3QsIHN0cnVjdCBkaW5vZGUgKikpOw0KIHN0cnVj
 dCBpZmlsZSAqbGZzX2llbnRyeSBfX1AoKGlub190KSk7DQogc3RydWN0IGlu
 b2luZm8gKmdldGlub2luZm8gX19QKChpbm9fdCkpOw0KIHZvaWQgZ2V0Ymxr
 IF9fUCgoc3RydWN0IGJ1ZmFyZWEgKiwgZGFkZHJfdCwgbG9uZykpOw0KSW5k
 ZXg6IGlub2RlLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl
 OiAvY3Zzcm9vdC9iYXNlc3JjL3NiaW4vZnNja19sZnMvaW5vZGUuYyx2DQpy
 ZXRyaWV2aW5nIHJldmlzaW9uIDEuMw0KZGlmZiAtdSAtcjEuMyBpbm9kZS5j
 DQotLS0gaW5vZGUuYwkxOTk5LzA3LzAzIDE5OjU1OjAzCTEuMw0KKysrIGlu
 b2RlLmMJMjAwMC8wMS8yMCAyMToyOToyNQ0KQEAgLTY0LDE0ICs2NCwxNCBA
 QA0KIC8qIHN0b2xlbiBmcm9tIGxmc19pbm9kZS5jICovDQogLyogU2VhcmNo
 IGEgYmxvY2sgZm9yIGEgc3BlY2lmaWMgZGlub2RlLiAqLw0KIHN0cnVjdCBk
 aW5vZGUgKg0KLWxmc19pZmluZChzdHJ1Y3QgbGZzICpmcywgaW5vX3QgaW5v
 LCBzdHJ1Y3QgZGlub2RlICpkaXApDQorbGZzX2RpZmluZChzdHJ1Y3QgbGZz
 ICpmcywgaW5vX3QgaW5vLCBzdHJ1Y3QgZGlub2RlICpkaXApDQogew0KICAg
 ICByZWdpc3RlciBpbnQgY250Ow0KIA0KICAgICBmb3IoY250PTA7Y250PElO
 T1BCKGZzKTtjbnQrKykNCiAgICAgICAgIGlmKGRpcFtjbnRdLmRpX2ludW1i
 ZXIgPT0gaW5vKQ0KICAgICAgICAgICAgIHJldHVybiAmKGRpcFtjbnRdKTsN
 Ci0gICAgLyogcHJpbnRmKCJsZnNfaWZpbmQ6IGRpbm9kZSAldSBub3QgZm91
 bmRcbiIsIGlubyk7ICovDQorICAgIC8qIHByaW50ZigibGZzX2RpZmluZDog
 ZGlub2RlICV1IG5vdCBmb3VuZFxuIiwgaW5vKTsgKi8NCiAgICAgcmV0dXJu
 IE5VTEw7DQogfQ0KIA0KQEAgLTIxMCw3ICsyMTAsNyBAQA0KICNpZiAxDQog
 ICAgIHN0cnVjdCBkaW5vZGUgKmlkaW5vZGU7DQogDQotICAgIGlkaW5vZGUg
 PSBsZnNfaWZpbmQoJnNibG9jayxzYmxvY2subGZzX2lmaWxlLCZpZmJsb2Nr
 KTsNCisgICAgaWRpbm9kZSA9IGxmc19kaWZpbmQoJnNibG9jayxzYmxvY2su
 bGZzX2lmaWxlLCZpZmJsb2NrKTsNCiAgICAgcmV0dXJuICgoaWRpbm9kZS0+
 ZGlfc2l6ZQ0KICAgICAgICAgICAgIC0gKHNibG9jay5sZnNfY2xlYW5zeiAr
 IHNibG9jay5sZnNfc2VndGFic3opICogc2Jsb2NrLmxmc19ic2l6ZSkNCiAg
 ICAgICAgIC8gc2Jsb2NrLmxmc19ic2l6ZSkgKiBzYmxvY2subGZzX2lmcGIg
 LSAxOw0KQEAgLTIyNCw3ICsyMjQsNyBAQA0KICAgICBzdGF0aWMgc3RydWN0
 IGRpbm9kZSAqaWRpbm9kZTsNCiANCiAgICAgaWYoIWlkaW5vZGUpIHsgICAg
 ICAgICAgICAgIC8qIG9ubHkgbmVlZCB0byBkbyB0aGlzIG9uY2UgKi8NCi0g
 ICAgICAgIGlkaW5vZGUgPSBsZnNfaWZpbmQoJnNibG9jayxzYmxvY2subGZz
 X2lmaWxlLCZpZmJsb2NrKTsNCisgICAgICAgIGlkaW5vZGUgPSBsZnNfZGlm
 aW5kKCZzYmxvY2ssc2Jsb2NrLmxmc19pZmlsZSwmaWZibG9jayk7DQogICAg
 ICAgICBpZihkaW5fdGFibGVbTEZTX0lGSUxFX0lOVU1dDQogICAgICAgICAg
 ICAmJiBkaW5fdGFibGVbTEZTX0lGSUxFX0lOVU1dLT5kaV9nZW4gPiBpZGlu
 b2RlLT5kaV9nZW4pIHsNCiAgICAgICAgICAgICBwcmludGYoIlhYWCByZXBs
 YWNpbmcgSUZJTEUgZ2VuICVkIHdpdGggZ2VuICVkXG4iLA0KQEAgLTMwMSw3
 ICszMDEsNyBAQA0KICAgICAgICAgICAgICAgIGlmcC0+aWZfZGFkZHIsIGRh
 dG9zbigmc2Jsb2NrLGlmcC0+aWZfZGFkZHIpKTsNCiAgICAgfQ0KICAgICBw
 YnAgPSBnZXRkZGJsayhpZnAtPmlmX2RhZGRyLHNibG9jay5sZnNfYnNpemUp
 Ow0KLSAgICBkaW49bGZzX2lmaW5kKCZzYmxvY2ssIGludW1iZXIsIHBicC0+
 Yl91bi5iX2Rpbm9kZSk7DQorICAgIGRpbj1sZnNfZGlmaW5kKCZzYmxvY2ss
 IGludW1iZXIsIHBicC0+Yl91bi5iX2Rpbm9kZSk7DQogDQogICAgIC8qIGRl
 YnVnICovDQogICAgIGlmKGRpbiAmJiBkaW4tPmRpX2ludW1iZXIgIT0gaW51
 bWJlcikNCkluZGV4OiBwYXNzMS5jDQo9PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 DQpSQ1MgZmlsZTogL2N2c3Jvb3QvYmFzZXNyYy9zYmluL2ZzY2tfbGZzL3Bh
 c3MxLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjMNCmRpZmYgLXUgLXIx
 LjMgcGFzczEuYw0KLS0tIHBhc3MxLmMJMTk5OS8wNy8wMyAxOTo1NTowMwkx
 LjMNCisrKyBwYXNzMS5jCTIwMDAvMDEvMjAgMjE6Mjk6MjUNCkBAIC03Nyw3
 ICs3Nyw3IEBADQogICAgICAgICBzdHJ1Y3QgaWZpbGUgKmlmcDsNCiAgICAg
 ICAgIENMRUFORVJJTkZPICpjcDsNCiANCi0gICAgICAgIGlkaW5vZGUgPSBs
 ZnNfaWZpbmQoJnNibG9jayxzYmxvY2subGZzX2lmaWxlLCZpZmJsb2NrKTsN
 CisgICAgICAgIGlkaW5vZGUgPSBsZnNfZGlmaW5kKCZzYmxvY2ssc2Jsb2Nr
 Lmxmc19pZmlsZSwmaWZibG9jayk7DQogDQogICAgICAgICAvKg0KICAgICAg
 ICAgICogV2Ugbm93IGhhdmUgdGhlIGlmaWxlJ3MgaW5vZGUgYmxvY2sgaW4g
 Y29yZS4gIFJlYWQgb3V0IHRoZQ0K
 --0-1843749218-948403989=:8510--

From: John Darrow <John.P.Darrow@wheaton.edu>
To: he@netbsd.org, source-changes@netbsd.org, gnats-bugs@netbsd.org
Cc: perseant@netbsd.org
Subject: bin/9253 (Re: CVS commit: syssrc)
Date: Thu, 20 Jan 2000 15:37:45 -0600 (CST)

 Note that, with this pullup, fsck_lfs is now broken on both -current and
 the netbsd-1-4 branch, due to a namespace collision resulting in
 conflicting declarations of lfs_ifind in syssrc/sys/ufs/lfs/lfs_extern.h
 and basesrc/sbin/fsck_lfs/fsck.h, with the breakage occuring during
 compilation of basesrc/sbin/fsck_lfs/setup.c (which uses lfs_sb_cksum
 from lfs_extern.h) and basesrc/sbin/fsck_lfs/pass0.c (which uses cksum
 from lfs_extern.h).  (Both cksum functions are found in
 syssrc/sys/ufs/lfs/lfs_cksum.c, which is pulled in via a .PATH directive)

 Also note that basesrc/sbin/dump_lfs/lfs_inode.c also has a lfs_ifind
 function with the same declaration as in fsck_lfs, but doesn't at this
 time include lfs_extern.h.  Which means now it's an accident waiting to
 happen.

 Are there specific namespace guidelines regarding these *_extern.h include
 files, other than "always test before committing" and all that...?

 jdarrow

 -- 
 John Darrow - Senior Technical Specialist               Office: 630/752-5201
 Computing Services, Wheaton College, Wheaton, IL 60187  Fax:    630/752-5968
 Alphapage: 6303160707@alphapage.airtouch.com            Pager:  630/316-0707
 Email:     John.P.Darrow@wheaton.edu


 In article <200001202101.NAA23404@nb00.nas.nasa.gov>,
 Havard Eidnes <he@netbsd.org> wrote:

 >Module Name:	syssrc
 >Committed By:	he
 >Date:		Thu Jan 20 21:01:33 UTC 2000

 >Modified Files:
 >	syssrc/sys/ufs/lfs [netbsd-1-4]: lfs_extern.h

 >Log Message:
 >Pull up revision 1.16 (requested by perseant):
 >  Files removed (through unlink, rmdir) are now really removed, though the
 >  removal is postponed until the dirop is complete to ensure validity of
 >  the filesystem through a crash.  Use a separate per-fs lock, instead of
 >  ufs_hashlock, to protect the inode free list.  Change calling semantics
 >  of lfs_ifind, to give better error reporting:  If fed a struct buf, it
 >  can report the block number of the offending inode block as well as the
 >  inode number.


 >To generate a diff of this commit:
 >cvs rdiff -r1.13.2.1 -r1.13.2.2 syssrc/sys/ufs/lfs/lfs_extern.h

 >Please note that diffs are not public domain; they are subject to the
 >copyright notices on the relevant files.



From: Havard.Eidnes@runit.sintef.no
To: John.P.Darrow@wheaton.edu
Cc: source-changes@netbsd.org, gnats-bugs@netbsd.org, perseant@netbsd.org
Subject: Re: bin/9253 (Re: CVS commit: syssrc)
Date: Fri, 21 Jan 2000 01:41:39 +0100

 > Note that, with this pullup, fsck_lfs is now broken on both
 > -current and the netbsd-1-4 branch, due to a namespace
 > collision [...]

 I think by the pullups now processed, this should now be fixed.

 Regards,

 - H=E5vard

From: Mark Davies <mark@MCS.VUW.AC.NZ>
To: Konrad Schroder <perseant@hhhh.org>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: bin/9253: current build fails due to out of date fsck_lfs 
Date: Fri, 21 Jan 2000 15:05:44 +1300

 	From:  Konrad Schroder <perseant@hhhh.org>
 	Date:  Thu, 20 Jan 2000 13:33:09 -0800 (PST)

 > Quite right.  Try the enclosed patch (which I'm also committing now), and
 > let me know if you have any other build problems....

 Built fine after that patch.

 cheers
 mark


State-Changed-From-To: open->closed 
State-Changed-By: perseant 
State-Changed-When: Fri Jan 21 13:50:29 PST 2000 
State-Changed-Why:  
Patch made, pulled up; submitter confirms that this fixes the problem. 


Responsible-Changed-From-To: bin-bug-people->perseant 
Responsible-Changed-By: perseant 
Responsible-Changed-When: Fri Jan 21 13:50:29 PST 2000 
Responsible-Changed-Why:  
I am responsible for LFS-related problems. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.