NetBSD Problem Report #9320
Received: (qmail 23798 invoked from network); 30 Jan 2000 23:25:32 -0000
Message-Id: <200001302325.IAA05545@edge.sky.yamashina.kyoto.jp>
Date: Mon, 31 Jan 2000 08:25:30 +0900 (JST)
From: Takahiro Kambe <taca@sky.yamashina.kyoto.jp>
Reply-To: taca@sky.yamashina.kyoto.jp
To: gnats-bugs@gnats.netbsd.org
Subject: /etc/security output incorrect report about "Root umask"
X-Send-Pr-Version: 3.95
>Number: 9320
>Category: security
>Synopsis: /etc/security output incorrect report about "Root umask"
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: security-officer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jan 30 15:27:00 +0000 2000
>Closed-Date: Fri Jul 07 10:02:24 +0000 2000
>Last-Modified: Fri Jul 07 10:02:24 +0000 2000
>Originator: Takahiro Kambe
>Release: NetBSD-current 2000/1/25
>Organization:
>Environment:
System: NetBSD edge.sky.yamashina.kyoto.jp 1.4Q NetBSD 1.4Q (CF-M33) #95: Sun Jan 30 13:01:27 JST 2000 taca@edge.sky.yamashina.kyoto.jp:/usr/src/sys/arch/i386/compile/CF-M33 i386
>Description:
/etc/security output incorrect report about "Root umask" even if
umask is really set. When /etc/security checks umask setting,
it dosen't care about comment lines.
>How-To-Repeat:
Add a comment line including "umask" before the setting umask line.
# set root umask
umask 022
>Fix:
Here is a sample fix.
--- security.orig Sun Jan 16 13:37:20 2000
+++ security Mon Jan 31 08:10:56 2000
@@ -187,10 +187,10 @@
list="/etc/csh.cshrc /etc/csh.login ${rhome}/.cshrc ${rhome}/.login"
for i in $list ; do
if [ -f $i ] ; then
- if egrep umask $i > /dev/null ; then
+ if sed -n -e '/^#/d' -e '/umask/p' $i > /dev/null ; then
umaskset=yes
fi
- egrep umask $i |
+ sed -n -e '/^#/d' -e '/umask/p' $i |
awk '$2 % 100 < 20 \
{ print "\tRoot umask is group writeable" }
$2 % 10 < 2 \
@@ -232,10 +232,10 @@
list="/etc/profile ${rhome}/.profile"
for i in $list; do
if [ -f $i ] ; then
- if egrep umask $i > /dev/null ; then
+ if sed -n -e '/^#/d' -e '/umask/p' $i > /dev/null ; then
umaskset=yes
fi
- egrep umask $i |
+ sed -n -e '/^#/d' -e '/umask/p' $i |
awk '$2 % 100 < 20 \
{ print "\tRoot umask is group writeable" } \
$2 % 10 < 2 \
>Release-Note:
>Audit-Trail:
From: Takahiro Kambe <taca@sky.yamashina.kyoto.jp>
To: gnats-bugs@gnats.netbsd.org
Cc: netbsd-bugs@netbsd.org
Subject: Re: security/9320: /etc/security output incorrect report about
"Root umask"
Date: Mon, 31 Jan 2000 09:23:02 +0900
Oops. This fix may be a little bit better.
--
Takahiro Kambe <taca@sky.yamashina.kyoto.jp>
--- security.orig Sun Jan 16 13:37:20 2000
+++ security Mon Jan 31 09:19:52 2000
@@ -187,15 +187,16 @@
list="/etc/csh.cshrc /etc/csh.login ${rhome}/.cshrc ${rhome}/.login"
for i in $list ; do
if [ -f $i ] ; then
- if egrep umask $i > /dev/null ; then
+ if sed -n -e '/^#/d' -e '/umask/p' $i > /dev/null ; then
umaskset=yes
fi
- egrep umask $i |
- awk '$2 % 100 < 20 \
- { print "\tRoot umask is group writeable" }
- $2 % 10 < 2 \
- { print "\tRoot umask is other writeable" }' \
- >> $OUTPUT
+ awk '/^#/ { next } \
+ /umask/ { \
+ if ($2 % 100 < 20) \
+ {print "\tRoot umask is group writeable"} \
+ else if ($2 % 10 < 2) \
+ {print "\tRoot umask is other writeable"} \
+ }' $i >> $OUTPUT
SAVE_PATH=$PATH
unset PATH
/bin/csh -f -s << end-of-csh > /dev/null 2>&1
@@ -232,15 +233,16 @@
list="/etc/profile ${rhome}/.profile"
for i in $list; do
if [ -f $i ] ; then
- if egrep umask $i > /dev/null ; then
+ if sed -n -e '/^#/d' -e '/umask/p' $i > /dev/null ; then
umaskset=yes
fi
- egrep umask $i |
- awk '$2 % 100 < 20 \
- { print "\tRoot umask is group writeable" } \
- $2 % 10 < 2 \
- { print "\tRoot umask is other writeable" }' \
- >> $OUTPUT
+ awk '/^#/ { next } \
+ /umask/ { \
+ if ($2 % 100 < 20) \
+ {print "\tRoot umask is group writeable"} \
+ else if ($2 % 10 < 2) \
+ {print "\tRoot umask is other writeable"} \
+ }' $i >> $OUTPUT
SAVE_PATH=$PATH
unset PATH
/bin/sh << end-of-sh > /dev/null 2>&1
State-Changed-From-To: open->feedback
State-Changed-By: sommerfeld
State-Changed-When: Sun Jul 2 14:56:56 PDT 2000
State-Changed-Why:
Slightly different fix committed to -current src/etc/security 1.45.
State-Changed-From-To: feedback->closed
State-Changed-By: sommerfeld
State-Changed-When: Fri Jul 7 03:02:07 PDT 2000
State-Changed-Why:
submitter agrees with fix
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.