NetBSD Problem Report #97

From gnats  Mon Jan 24 21:58:32 1994
Received: from bloom-beacon.mit.edu (BLOOM-BEACON.MIT.EDU [18.70.0.232]) by sun-lamp.cs.berkeley.edu (8.6.4/8.6.4) with SMTP id VAA22280 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Mon, 24 Jan 1994 21:50:13 -0800
Message-Id: <199401250532.AAA00335@orchard.medford.ma.us>
Date: Tue, 25 Jan 1994 00:32:48 -0500
From: sommerfeld@orchard.medford.ma.us
Reply-To: sommerfeld@orchard.medford.ma.us
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: sbintr dereferences null pointer on stray interrupt. 
X-Send-Pr-Version: 3.01.6

>Number:         97
>Category:       kern
>Synopsis:       sbintr calls through NULL on stray intr
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 24 22:05:03 +0000 1994
>Closed-Date:    Wed Jul 20 07:02:10 +0000 1994
>Last-Modified:  Thu Jan 02 18:15:26 +0000 2014
>Originator:     Bill Sommerfeld
>Release:        -current
>Organization:
	None
>Environment:

System: NetBSD orchard.medford.ma.us 0.9a ORCHARD#7 i386


>Description:
	the soundblaster driver, /sys/arch/i386/isa/sb.c, in sbintr(),
	calls through the dma completion routine (sc->sc_intr) function
	pointer without checking first to see if it's NULL.
	My system occasionally generates stray interrupts on IRQ 7, which
	is the IRQ that the soundblaster is on..

>How-To-Repeat:
	happens under load occasionally; seems to be related to using multiple
	serial lines at once.
>Fix:
(untested as of yet).	
*** 1.1	1994/01/25 05:26:04
--- sb.c	1994/01/25 05:27:08
***************
*** 622,630 ****
  	if (sc->sc_mintr != 0) {
  		int c = rdsp(sc->sc_base);
  		(*sc->sc_mintr)(sc->sc_arg, c);
! 	} else
  		(*sc->sc_intr)(sc->sc_arg);
! 
  	return (1);
  }

--- 622,630 ----
  	if (sc->sc_mintr != 0) {
  		int c = rdsp(sc->sc_base);
  		(*sc->sc_mintr)(sc->sc_arg, c);
! 	} else if (sc->sc_intr != 0) {
  		(*sc->sc_intr)(sc->sc_arg);
! 	}
  	return (1);
  }

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mycroft 
State-Changed-When: Wed Jul 20 00:02:10 PDT 1994 
State-Changed-Why:  
This was fixed a long time ago. 

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.