NetBSD Problem Report #9842

Received: (qmail 5200 invoked from network); 8 Apr 2000 17:55:03 -0000
Message-Id: <200004081754.NAA02782@gduzan.static.shore.net>
Date: Sat, 8 Apr 2000 13:54:42 -0400 (EDT)
From: Gary Duzan <gary@gduzan.static.shore.net>
Reply-To: gary@gduzan.static.shore.net
To: gnats-bugs@gnats.netbsd.org
Subject: ata dependency on wdc, triggered by umass
X-Send-Pr-Version: 3.95

>Number:         9842
>Category:       kern
>Synopsis:       ata dependency on wdc, triggered by umass
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 08 17:56:00 +0000 2000
>Closed-Date:    Mon Apr 10 06:44:24 +0000 2000
>Last-Modified:  Mon Apr 10 06:44:24 +0000 2000
>Originator:     Gary Duzan
>Release:        Sat Apr  8 10:04:49 EDT 2000
>Organization:
	Not a lot
>Environment:
System: NetBSD wheel 1.4X NetBSD 1.4X (WHEEL) #0: Wed Mar 29 15:58:18 EST 2000 gary@wheel:/usr/tmp/src/sys/arch/i386/compile/WHEEL i386


>Description:
	In a kernel with umass (which pulls in atapi) configured,
	but no atapibus or wdc configured, ata.c (which refers to
	symbols in wdc) is pulled in, but not wdc, leading to
	unresolved symbols at link time.

ld -Ttext c0100000 -e start -X -o netbsd ${SYSTEM_OBJ} vers.o
ata.o: In function `ata_get_params':
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:74: undefined reference to `wdcdebug_mask'
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:91: undefined reference to `wdcdebug_mask'
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:98: undefined reference to `wdc_exec_command'
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:99: undefined reference to `wdcdebug_mask'
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:104: undefined reference to `wdcdebug_mask'
ata.o: In function `ata_set_mode':
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:147: undefined reference to `wdcdebug_mask'
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:157: undefined reference to `wdc_exec_command'
ata.o: In function `ata_dmaerr':
/root/src/sys/arch/i386/compile/WHEEL/../../../../dev/ata/ata.c:178: undefined reference to `wdc_downgrade_mode'
*** Error code 1

>How-To-Repeat:
	Configure a fairly minimal kernel with umass enabled, but
	no wdc/atapibus, and try to build it.
>Fix:
	Protecting all of ata.c with "#if NATAPIBUS > 0" lets me
	compile, at least, but doesn't seem right. Either prevent
	ata from being pulled in or pull in wdc with it.
>Release-Note:
>Audit-Trail:

From: Manuel Bouyer <bouyer@antioche.lip6.fr>
To: Gary Duzan <gary@gduzan.static.shore.net>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: kern/9842: ata dependency on wdc, triggered by umass
Date: Sun, 9 Apr 2000 12:43:39 +0200

 --SUOF0GtieIMvvwua
 Content-Type: text/plain; charset=us-ascii

 On Sat, Apr 08, 2000 at 01:54:42PM -0400, Gary Duzan wrote:
 > >Fix:
 > 	Protecting all of ata.c with "#if NATAPIBUS > 0" lets me
 > 	compile, at least, but doesn't seem right. Either prevent
 > 	ata from being pulled in or pull in wdc with it.

 Could you try the attached patch and re-run 'config' ? It should solve the
 problem.

 --
 Manuel Bouyer <bouyer@antioche.eu.org>
 --

 --SUOF0GtieIMvvwua
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=diff

 --- dev/ata/files.ata.old	Sun Apr  9 12:40:26 2000
 +++ dev/ata/files.ata	Sun Apr  9 12:40:40 2000
 @@ -11,4 +11,4 @@
  file	dev/ata/wd.c				wd needs-flag
  file	dev/ata/ata_wdc.c			wd & wdc_base

 -file	dev/ata/ata.c				ata | atapi
 +file	dev/ata/ata.c				(ata | atapi) & wdc_base

 --SUOF0GtieIMvvwua--

From: Gary Duzan <gary@gduzan.static.shore.net>
To: Manuel Bouyer <bouyer@antioche.lip6.fr>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: kern/9842: ata dependency on wdc, triggered by umass 
Date: Sun, 09 Apr 2000 14:35:41 -0400

    That does it. Thanks.

 					Gary Duzan


 In Message <20000409124339.A784@antioche.eu.org> ,
    Manuel Bouyer <bouyer@antioche.lip6.fr> wrote:

 =>
 =>--SUOF0GtieIMvvwua
 =>Content-Type: text/plain; charset=us-ascii
 =>
 =>On Sat, Apr 08, 2000 at 01:54:42PM -0400, Gary Duzan wrote:
 =>> >Fix:
 =>> 	Protecting all of ata.c with "#if NATAPIBUS > 0" lets me
 =>> 	compile, at least, but doesn't seem right. Either prevent
 =>> 	ata from being pulled in or pull in wdc with it.
 =>
 =>Could you try the attached patch and re-run 'config' ? It should solve the
 =>problem.
 =>
 =>--
 =>Manuel Bouyer <bouyer@antioche.eu.org>
 =>--
 =>
 =>--SUOF0GtieIMvvwua
 =>Content-Type: text/plain; charset=us-ascii
 =>Content-Disposition: attachment; filename=diff
 =>
 =>--- dev/ata/files.ata.old	Sun Apr  9 12:40:26 2000
 =>+++ dev/ata/files.ata	Sun Apr  9 12:40:40 2000
 =>@@ -11,4 +11,4 @@
 => file	dev/ata/wd.c				wd needs-flag
 => file	dev/ata/ata_wdc.c			wd & wdc_base
 => 
 =>-file	dev/ata/ata.c				ata | atapi
 =>+file	dev/ata/ata.c				(ata | atapi) & wdc_base
 =>
 =>--SUOF0GtieIMvvwua--
State-Changed-From-To: open->closed 
State-Changed-By: bouyer 
State-Changed-When: Sun Apr 9 23:43:59 PDT 2000 
State-Changed-Why:  
I just commited a fix. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.