NetBSD Problem Report #9945
Received: (qmail 22375 invoked from network); 21 Apr 2000 01:00:12 -0000
Message-Id: <200004210059.UAA02406@bauhaus.degler.net>
Date: Thu, 20 Apr 2000 20:59:47 -0400 (EDT)
From: sdegler@degler.net
Reply-To: sdegler@degler.net
To: gnats-bugs@gnats.netbsd.org
Cc: sdegler@degler.net
Subject: if_ppp.c minor bug
X-Send-Pr-Version: 3.95
>Number: 9945
>Category: kern
>Synopsis: mru typo prevents mru to be set below 1500 bytes.
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Apr 21 01:01:00 +0000 2000
>Closed-Date: Thu Oct 26 01:27:16 +0000 2000
>Last-Modified: Thu Oct 26 01:27:16 +0000 2000
>Originator: Stephen Degler
>Release: NetBSD-current as of Thu Apr 20 20:50:17 2000
>Organization:
degler.net
>Environment:
System: NetBSD bauhaus.degler.net 1.4X NetBSD 1.4X (BAUHAUS) #1: Thu Apr 20 01:10:01 EDT 2000 root@bauhaus.degler.net:/vol2/src/sys/arch/alpha/compile/BAUHAUS alpha
>Description:
while debugging pppoe with mouse-ppoe pkg I saw what appears to be
a typo in if_ppp.c. It looks as if the mru cannot be set below 1500
bytes which will screw up pppoe (needs mtu 1492) because the value
gets used for lcp negotiation.
>How-To-Repeat:
Eyeball following patch. I changed multiple variables at the
same time (I also fixed problems with mouse-pppoe), but this
looks obviously wrong. I have things working correctly with
this patch in place.
>Fix:
--- if_ppp.c.orig Thu Apr 20 12:24:21 2000
+++ if_ppp.c Wed Apr 19 22:27:36 2000
@@ -395,7 +395,7 @@
if ((error = suser(p->p_ucred, &p->p_acflag)) != 0)
return (error);
mru = *(int *)data;
- if (mru >= PPP_MRU && mru <= PPP_MAXMRU)
+ if (mru >= PPP_MINMRU && mru <= PPP_MAXMRU)
sc->sc_mru = mru;
break;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: wiz
State-Changed-When: Wed Oct 25 18:26:33 PDT 2000
State-Changed-Why:
Applied the patch after confirmation by is@netbsd.org, that it's okay.
Thanks for the PR & fix!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.