NetBSD Problem Report #41061

From www@NetBSD.org  Mon Mar 23 04:35:53 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 6D6FA63B9E6
	for <gnats-bugs@gnats.netbsd.org>; Mon, 23 Mar 2009 04:35:53 +0000 (UTC)
Message-Id: <20090323043553.406C663B84D@www.NetBSD.org>
Date: Mon, 23 Mar 2009 04:35:53 +0000 (UTC)
From: sbd@users.sf.net
Reply-To: sbd@users.sf.net
To: gnats-bugs@NetBSD.org
Subject: 'mtree -d' show symlinks when comparing (patch)
X-Send-Pr-Version: www-1.0

>Number:         41061
>Category:       bin
>Synopsis:       'mtree -d' show symlinks when comparing (patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 23 04:40:00 +0000 2009
>Closed-Date:    Wed Mar 28 03:45:52 +0000 2012
>Last-Modified:  Wed Mar 28 03:45:52 +0000 2012
>Originator:     Steven Drake
>Release:        mtree-20081105
>Organization:
>Environment:
System: Linux idran.drake.org.nz 2.6.28.7 #1 PREEMPT Sun Mar 15 20:29:52 NZDT 2009 i686 pentium4 i386 GNU/Linux
Architecture: pentium4
Machine: i686
pkgsrc-2008Q4

>Description:
        Option -d "Ignore everything except directory type files"
        prints unknow symlinks as well as unknow directorys when
        comparing/verifing.

        eg. (from How-To-Repeat)
extra: otherdir

>How-To-Repeat:
        cd `mktemp -d`
        mkdir newdir
        mtree -c| mtree -Ck uid,gid,mode >mtree.spec
        ln -s newdir otherdir
        mtree -d <mtree.spec
>Fix:
--- verify.c.orig
+++ verify.c
@@ -163,7 +163,7 @@ vwalk(void)
                if (ep)
                        continue;
  extra:
-               if (!eflag) {
+               if (!eflag && !(dflag && p->fts_info == FTS_SL)) {
                        printf("extra: %s", RP(p));
                        if (rflag) {
                                if ((S_ISDIR(p->fts_statp->st_mode)

>Release-Note:

>Audit-Trail:

From: "Jukka Ruohonen" <jruoho@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41061 CVS commit: src/tests/usr.sbin/mtree
Date: Mon, 19 Mar 2012 06:39:22 +0000

 Module Name:	src
 Committed By:	jruoho
 Date:		Mon Mar 19 06:39:22 UTC 2012

 Modified Files:
 	src/tests/usr.sbin/mtree: t_mtree.sh

 Log Message:
 Add a case for PR bin/41061.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/tests/usr.sbin/mtree/t_mtree.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41061 CVS commit: src/usr.sbin/mtree
Date: Sun, 25 Mar 2012 12:07:04 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Mar 25 16:07:04 UTC 2012

 Modified Files:
 	src/usr.sbin/mtree: verify.c

 Log Message:
 PR/41061: Steven Drake: mtree -d complains about extra symlinks


 To generate a diff of this commit:
 cvs rdiff -u -r1.39 -r1.40 src/usr.sbin/mtree/verify.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41061 CVS commit: src/tests/usr.sbin/mtree
Date: Sun, 25 Mar 2012 12:10:14 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Mar 25 16:10:14 UTC 2012

 Modified Files:
 	src/tests/usr.sbin/mtree: t_mtree.sh

 Log Message:
 PR/41061 fixed


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/tests/usr.sbin/mtree/t_mtree.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 25 Mar 2012 16:27:15 +0000
State-Changed-Why:
Does christos' commit fix it for you?


State-Changed-From-To: feedback->closed
State-Changed-By: sbd@NetBSD.org
State-Changed-When: Wed, 28 Mar 2012 03:45:52 +0000
State-Changed-Why:
Should do, it's the patch I suggested.


>Unformatted:

Home	PR Database Search