NetBSD Problem Report #45104

From www@NetBSD.org  Tue Jun 28 09:13:23 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 5988B63BC32
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 28 Jun 2011 09:13:23 +0000 (UTC)
Message-Id: <20110628091322.4C2B763B970@www.NetBSD.org>
Date: Tue, 28 Jun 2011 09:13:22 +0000 (UTC)
From: ftigeot@wolfpond.org
Reply-To: ftigeot@wolfpond.org
To: gnats-bugs@NetBSD.org
Subject: devel/cppunit misses a destructor for CppUnit::Message
X-Send-Pr-Version: www-1.0

>Number:         45104
>Category:       pkg
>Synopsis:       devel/cppunit misses a destructor for CppUnit::Message
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 28 09:15:00 +0000 2011
>Closed-Date:    Tue Jun 28 09:28:42 +0000 2011
>Last-Modified:  Tue Jun 28 09:30:03 +0000 2011
>Originator:     François Tigeot
>Release:        Various, including non-NetBSD
>Organization:
>Environment:
DragonFly akane.zefyris.com 2.10-RELEASE DragonFly v2.10.1.7.g20061-RELEASE #6: Wed May  4 13:22:37 CEST 2011     ftigeot@akane.zefyris.com:/usr/obj/usr/src/sys/X86_64_GENERIC_SMP  x86_64
>Description:
devel/cppunit misses a destructor declaration for one of its classes

The compiler generates an implicit destructor but in certain circonstances this leads to crashes.

More information is available in this bug report on Red Hat's tracker:

https://bugzilla.redhat.com/show_bug.cgi?id=641350
>How-To-Repeat:
Try to build LibreOffice with the --enable-debug configure option and
cppunit from devel/cppunit
>Fix:
Apply the patch in RedHat's bug report:
https://bugzilla.redhat.com/attachment.cgi?id=452340

diff -up cppunit-1.12.1/include/cppunit/Message.h.dt cppunit-1.12.1/include/cppunit/Message.h
--- cppunit-1.12.1/include/cppunit/Message.h.dt	2010-10-08 14:02:26.514477964 +0200
+++ cppunit-1.12.1/include/cppunit/Message.h	2010-10-08 14:02:15.411948098 +0200
@@ -57,6 +57,8 @@ public:
            const std::string &detail2,
            const std::string &detail3 );

+  ~Message();
+
   Message &operator =( const Message &other );

   /*! \brief Returns the short description.
diff -up cppunit-1.12.1/src/cppunit/Message.cpp.dt cppunit-1.12.1/src/cppunit/Message.cpp
--- cppunit-1.12.1/src/cppunit/Message.cpp.dt	2010-10-08 14:02:39.421768852 +0200
+++ cppunit-1.12.1/src/cppunit/Message.cpp	2010-10-08 14:02:54.066829633 +0200
@@ -47,6 +47,10 @@ Message::Message( const std::string &sho
   addDetail( detail1, detail2, detail3 );
 }

+Message::~Message()
+{
+}
+
 Message &
 Message::operator =( const Message &other )
 {

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 28 Jun 2011 09:28:42 +0000
State-Changed-Why:
Committed, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45104 CVS commit: pkgsrc/devel/cppunit
Date: Tue, 28 Jun 2011 09:28:25 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue Jun 28 09:28:25 UTC 2011

 Modified Files:
 	pkgsrc/devel/cppunit: Makefile distinfo
 Added Files:
 	pkgsrc/devel/cppunit/patches: patch-include_cppunit_Message.h
 	    patch-src_cppunit_Message.cpp

 Log Message:
 devel/cppunit misses a destructor declaration for one of its classes.
 The compiler generates an implicit destructor but in certain circonstances this leads to crashes.
 More information is available in this bug report on Red Hat's tracker:
 https://bugzilla.redhat.com/show_bug.cgi?id=641350

 From Francois Tigeot in PR 45104.

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/devel/cppunit/Makefile
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/cppunit/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/devel/cppunit/patches/patch-include_cppunit_Message.h \
     pkgsrc/devel/cppunit/patches/patch-src_cppunit_Message.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search